Paragon: cross-class talents + Warrior stance bypass + Mirror Image spellbook draw

Server-side cross-class wildcard pass for several talents that were previously locked to a single SpellFamilyName, plus a server+client Warrior stance bypass and a Paragon-aware Mirror Image rebuild that mimics the owner's spellbook instead of stock Frostbolt/Fire Blast. Talent expansions (Paragon owners only; stock classes unchanged): - Cold Snap (11958): resets cooldown of any Frost-school spell. - Nature's Swiftness (17116, 16188) + Predator's Swiftness (69369): instant-cast on any Nature-school spell. - Vampiric Embrace (15286): leech-heals from any single-target Shadow-school spell. - Fingers of Frost (44543/44545) + Frostbite (11071/12496/12497): proc from any Frost-school chill effect (DK Howling Blast / Icy Touch / Chains of Ice, Hunter Frost Trap, Shaman Frost Shock, cross-class chill auras via SPELL_AURA_MOD_DECREASE_SPEED). - Maelstrom Weapon (53817): now also affects Mage Fireball (133), Frostbolt (116), and Arcane Blast (30451) at every rank, both for cast-time/cost spellmod and for stack consumption. Warrior stance bypass: - SpellInfo::CheckShapeshift returns SPELL_CAST_OK whenever a Paragon caster hits any Stances!=0 spell (no SpellFamilyName gate). Stock classes still see the regular form rules. - Client side: patch-enUS-4.MPQ now zeroes Stances on every SPELLFAMILY_WARRIOR Spell.dbc row (105 spells) so the engine's pre-cast "Must be in Battle/Defensive/Berserker Stance" check no longer eats CMSG_CAST_SPELL packets for Paragons. Server bypass enforces the actual decision; stock Warriors still error mid-cast if they actually click while out of stance. - patch-enUS-5.MPQ Lua tooltip post-processor recolors and appends "(Paragon: bypassed)" to "Requires *Stance*" lines on Warrior abilities, plus Paragon notes on Maelstrom Weapon and Mirror Image tooltips. Action-bar UseAction wrapper routes stance-gated Warrior spell clicks through CastSpellByName so the stance-zero DBC + server bypass actually run. Mirror Image: - npc_pet_mage_mirror_image rebuilds its spell list from the Paragon owner's spellbook on InitializeAI AND JustEngagedWith (the second pass + events.Reset clears any stale events the CasterAI base scheduler may have queued from stock 59637 / 59638 entries before the rebuild ran). - Curated filter keeps single-target damaging spells (instant, cast-time, or channeled) with a base cooldown <=10s, with the "damaging" definition expanded to include SPELL_EFFECT_TRIGGER_MISSILE and SPELL_AURA_PERIODIC_TRIGGER_SPELL so Arcane Missiles qualifies. Rejects passives, AoE, melee/ranged weapon strikes, item/reagent/stance/equip-gated, and lower spell ranks. - UpdateAI picks a random spell from the curated list per cast and reschedules the next pick by the actually-cast spell's cast/channel duration + 750ms breather, so a 5s Arcane Missiles channel waits its full duration before re-rolling rather than visually looping across four images. Helpers: - Unit::IsParagonWildcardCaller / Unit::ParagonFamilyMatches used by Spell.cpp, SpellInfo.cpp, Player.cpp, SpellAuraEffects.cpp, and the spell scripts. - SpellInfo::CheckShapeshift signature gains an optional caster pointer; all call sites updated. SQL migrations under modules/mod-paragon/data/sql/db-world/updates/: - 2026_05_11_01.sql Vampiric Embrace spell_proc relax + script gate (CheckProc enforces stock for non-Paragon). - 2026_05_11_02.sql Maelstrom Weapon spell_proc relax (initial, superseded by _04 below for stack-consumption fix). - 2026_05_11_03.sql Fingers of Frost / Frostbite spell_proc relax and spell_script_names binding. - 2026_05_11_04.sql Maelstrom Weapon spell_proc fixup: restore SpellPhaseMask=1 (CAST) and AttributesMask=8 (REQ_SPELLMOD); previous _02 set 8/0 which silently dropped every proc event. Diagnostics from this debugging session demoted from LOG_INFO to LOG_DEBUG (silent at default info level) so production logs stay quiet but the probes remain available for reproducing future regressions: pet_mage.cpp MirrorImage probe/kept/rebuild/init/ engage/cast lines and SpellInfo.cpp CheckShapeshift bypass line. CLIENT-PATCHES.md updated to document the new Warrior stance DBC patcher (_patch_spell_dbc_stances.py), the spell-tooltip post- processor and stance UseAction wrapper in patch-enUS-5.MPQ, and the Mirror Image / Maelstrom Weapon Paragon notes. Co-authored-by: Cursor <cursoragent@cursor.com>
2026-05-11 14:54:05 -04:00
parent a1c9172beb
commit e649402163
16 changed files with 874 additions and 39 deletions
@@ -1790,6 +1790,44 @@ class spell_sha_maelstrom_weapon : public AuraScript
        });
    }

+    // Fractured / Paragon: spell_proc row 53817 is data-relaxed (wildcard
+    // family/mask) so cross-class spells can reach this CheckProc. We
+    // restore the original Shaman gating here for stock callers and add
+    // the Paragon-only Mage Fireball / Frostbolt / Arcane Blast allowlist
+    // mirroring the IsAffectedBySpellMod hook in SpellInfo.cpp.
+    bool CheckProc(ProcEventInfo& eventInfo)
+    {
+        SpellInfo const* procSpell = eventInfo.GetSpellInfo();
+        if (!procSpell)
+            return false;
+
+        // Stock allowlist (Shaman): Lightning Bolt, Chain Lightning,
+        // Lesser Healing Wave, Healing Wave, Hex. Encoded as the original
+        // SpellFamilyMask values from the pre-relaxation spell_proc row
+        // (Mask0 = 451, Mask1 = 32768).
+        bool stockMatch = procSpell->SpellFamilyName == SPELLFAMILY_SHAMAN
+            && ((procSpell->SpellFamilyFlags[0] & 451u)
+                || (procSpell->SpellFamilyFlags[1] & 32768u));
+        if (stockMatch)
+            return true;
+
+        if (!IsParagonWildcardCaller(GetUnitOwner()))
+            return false;
+
+        // Paragon path: also accept the curated Mage cast-time nukes.
+        if (procSpell->SpellFamilyName == SPELLFAMILY_MAGE)
+        {
+            SpellInfo const* first = procSpell->GetFirstRankSpell();
+            uint32 firstId = first ? first->Id : procSpell->Id;
+            if (firstId == 133 /*Fireball*/
+                || firstId == 116 /*Frostbolt*/
+                || firstId == 30451 /*Arcane Blast*/)
+                return true;
+        }
+
+        return false;
+    }
+
    void HandleBonus(AuraEffect const* /*aurEff*/, AuraEffectHandleModes /*mode*/)
    {
        if (GetStackAmount() < int32(GetSpellInfo()->StackAmount))
@@ -1805,6 +1843,7 @@ class spell_sha_maelstrom_weapon : public AuraScript

    void Register() override
    {
+        DoCheckProc += AuraCheckProcFn(spell_sha_maelstrom_weapon::CheckProc);
        OnEffectApply += AuraEffectApplyFn(spell_sha_maelstrom_weapon::HandleBonus, EFFECT_0, SPELL_AURA_ADD_PCT_MODIFIER, AURA_EFFECT_HANDLE_CHANGE_AMOUNT);
    }
 };