Commit Graph
214 Commits
Author SHA1 Message Date
SatyandClaude Opus 5.5 bfe8e635d9 Document kept WoWFix335 patches, restore original tradeskill tool flags
- one-line notes on the four community fixes present in the IDB input
  (gamma, melee swing, turn attack anim, pre-cast anim)
- GetTradeSkillTools: FindTotemCategory flags 0 as in the signed exe;
  the IDB's push -0x15 is the misplaced naked-character-issue patch

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 17:48:42 +02:00
SatyandClaude Opus 5.5 ecf481aedd Restamp verify backlog after luaL_error returns and field renames
- 360 Script_* re-approved: only change since approval is return 0
  after luaL_error (semdiff vs binary)
- realm id field renames and TotemInfo m_guid (+0x8) checks re-approved
- CGlueMgr::OnKickReasonMsg passes via InitTokenSeed alias

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 17:27:37 +02:00
SatyandClaude Opus 5.5 211a43a44a Tag deleting dtors and ICF stubs, fix RepairCache key/record layout
- OFFSET tags for scalar deleting destructors of IOUnit, IOMpqUnit,
  IOMpqArchiveUnit, IOMpqDiskUnit, IOMpqReadUnit, IOAlignUnit, SFileImpl
- [dtor, ??_G] tags for IOMpqWriteUnit, ParameterItem, ServerItem,
  FileItem, TransportHttpCallback, TrackerHttpDataDownloadCallBack
- IOMpqArchiveReadUnit::Write 0x426880, LocalObject<SFileFatalInfo>::New
- RepairKey index is int64; RepairRecord {md5, index, offset, size};
  RepairEntry has no flags field (0x440B10/0x440BD0)

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 17:22:16 +02:00
SatyandClaude Opus 5.5 c790ecb4a0 Port Streaming/Storage/Transport/HTTP, Mopaq write path and missing-function batches
- Streaming: StreamingManager, Manifests, Storage (.part files, write queue),
  Transport (HTTP split download, throttle), Tracker/StartupReport, streaming
  filestack verbs (s_streamstack, StreamingOpen), RepairCache static
- URL: HttpRequest, InternetCallback, ReadResponseData, DownloadURL
- Mopaq write path: SFileCreateArchive/CreateFile/WriteFile, IOMpqWriteUnit,
  WriteArchiveChanges, RebuildHashTable, listfile acquire/release;
  SComp::Compress with RLE/zlib/bzip2/pkware compressors; MPQEncrypt::Encrypt
- LaunchChildProcessWithArguments, Debug::DefaultCallback/Breakpoint
- Earlier batches: ComSat, Battlenet Tumor, Glue/Ui/WowServices fixes,
  luaL_error returns in Script_ files

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 16:51:23 +02:00
SatyandClaude Opus 5.5 2fc01591aa Fix bugs found by asmwalk/semdiff, add luaL_error returns, typed template tags
- luaB_getfenv: look up __environment metafield like 12340
- DSPSfxReverb::setParameterInternal: set mUpdate for REFLECTIONSLEVEL and REVERBLEVEL
- CGGameUI::DestroyTotem, Script_SetTotem: test the totem GUID, not unk_0004
- Missing return 0 after luaL_error in script functions
- OFFSET tags of template instances carry their instance type: [0xXXXXXX<Type>]

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 10:11:32 +02:00
SatyandClaude Opus 5.5 312ab9ac65 Port batch 1 missing functions and add missing luaL_error returns found by semdiff
Batch 1: weather templates, client console commands, loading screen paths,
glue script events, AddOns/AccountData/Battlenet getters, simple camera and
camera vehicle offsets, Warden module path, BLL loader, FFX effects, Grunt
and GruntLogin matrix/file handlers, CGlueMgr char customize/faction change/
kick reason.

semdiff: 251 Lua script functions called luaL_error without the return 0 that
12340 has after every call site (each confirmed per call site in the binary).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 05:48:17 +02:00
SatyandClaude Opus 5.5 b76f1b443a Port packs w3-w5: objects/vehicles, LCD stack, ComSat voice chat, map dtors, misc missing functions
- Object/vehicle/spell-visual/world/MapObj functions from pack w3
- Logitech LCD stack (CLCDBase..CLCDConnection, CLCDText/Bitmap/Page, CEzLcd, CEzLcdPage, CLCDUtils) and CGLCD
- ComSat client: voice start/stop, mute, sound group fade, tick, event dispatch; s_comsatCallbacks is a growable array
- ShipPath pause/offset, Transport state progress, vehicle bone anim/passenger removal, NetClient redirect
- Map class destructors (CMapArea/Chunk/DoodadDef/Entity/ObjDefGroup), CMapChunk +0xB4 is a TSLink
- Character rename/customize, ClientServices login/survey wrappers, glue Lua scripts, DayNight light overrides
- Template instance and deleting-dtor OFFSETs

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 03:16:42 +02:00
SatyandClaude Opus 5.5 7c83a8297a Port Ui missing functions: KB, AccountMsg, Minigame, Dance, EquipmentManager, InstanceEncounter, macro conditions, Trade, Rune, misc LeaveWorld handlers
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 18:37:56 +02:00
SatyandClaude Opus 5.5 d9e4c5f644 Fix signed/unsigned count types and KB luaL_error returns found by the harness
Counts the binary converts as unsigned (fild + jge + fadd 2^32) or signed
(sar, plain fild) now use the matching types; KB count scripts return
luaL_error's result like the binary.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 16:40:46 +02:00
SatyandClaude Opus 5.5 393769ff36 Port single-missing-function modules
LeaveWorld handlers, game object type checks, corpse/dynamic object
virtuals, loot/voice/macro helpers, declined words, ProcessAgreement,
ObjectCreateStaticEx, FFX death/fog-seed/nether-blur passes, software
snow renderer, streaming decal, QuestCache copy, trajectory encoder and
deleting destructor tags. Fixes the missing CMapStaticEntity destructor
model release.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 14:39:43 +02:00
SatyandClaude Opus 5.5 761ba11682 Port Tooltip module
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 13:44:40 +02:00
SatyandClaude Opus 5.5 46b5adf64f Port FriendList, Player_C, Unit_C and GameObject_C modules
- FriendList: remaining methods and 28 Lua scripts, FriendListModuleLoaded
- Player_C: remaining functions incl. click-to-move (ClickToMove, CTMFace,
  CTMClickTerrain, CTMAttackUnit, CTMInteractGO), dance, virtual items,
  sound and skill-rank overrides
- Unit_C: tracking (HandleTracking and helpers, SetTrackingTarget/Direction),
  selection circles, spell visual overrides, mirror image, flag-2 changes,
  scale update, missile trajectory (ComputeMissileTrajectory,
  SendFinalMissileTrajectoryUpdate, StartMissileTrajectoryTargeting) and
  CMissileCollision (Init, unit ranking, hit spheres)
- GameObject_C: IsLocked, UseObject, TypeBase CanUseNow/CheckRange/Use/
  CanChangeCursor, Ritual and MeetingStone types, virtual overrides,
  property helpers named from the binary's property table
- Dependencies: ProjectTex::Render2d, weapon trail chain (SWING,
  WTOBJECT::SetDrawTrail), GxSwizzleColor, CAaBox::Expand/Center,
  CVehicle_C::PlayBoneAnimOrFallback, RuneInfo/PetitionInfo/ClassTrainer/
  ComSat helpers, CalendarEventTables ctor
- DBCache: InvalidateIntKey, RetryItem, SetTemporary, ~DBCACHEHASH
- Template instances, deleting dtors and TSHashTable/WowClientDB instances
  recorded in their OFFSET lists

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 12:07:58 +02:00
SatyandClaude Opus 5.5 2d1e72f545 Port TradeSkillFrame module
Remaining CGTradeSkillInfo methods (SetTradeSkill, SetLink, list link,
filters, sorting, Profession_FilterSpell), the static Script_* functions,
and CaseAccentInsensitiveParse. s_itemModTokens is now shared from Tooltip.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 09:30:02 +02:00
SatyandClaude Opus 5.5 bbf3de4926 Record skipped template instances and ChatChannel ctor
Template instance addresses added to stpl.h (TSList::UnlinkNode,
~TSHashTable deleting destructors, TSGrowableArray::SetCount,
~TSFixedArray) and WowClientDB::GetRecordByIndex. ChatChannel default
constructor 0x502960 ported (user-provided: sets +0x9C/+0xA0 to 1).
M2Shared.cpp: VERIFY re-stamp only.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 09:11:39 +02:00
SatyandClaude Opus 5.5 a20872895b Port LFGInfo module and the rest of QuestLog
LFG search results: LFGListPlayer/LFGListParty/LFGLIST layouts from the
binary, LFGHandler::ReadGroupInfo/ReadPlayerInfo, party add/remove, list
copy/clear/remove/reindex, SMSG_LFG_SEARCH_RESULTS, sort comparators.
CGLookingForGroup: leave, proposal response/member/encounter, boot vote,
role check member, search join, clear dungeon, queue status index,
ClearPartyInfo, ResortLFGLists; all remaining LFG scripts;
CGGameUI::GetInstanceDifficulty.

QuestLog: GetQuestWorldMapAreaID, GetQuestLeaderBoardForItem, quest watch
sorting and POI distance, UpdateQuestPOIFromUserServer and the UpdatePOI
console command. QuestWatch +8 is the sort distance (m_distance).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 09:11:39 +02:00
SatyandClaude Opus 5.5 12f5b14fb5 Port ChatFrame module
72 ChatFrame functions: remaining chat scripts (channels, voice, chat
logging, complaints, saved instances, chat window/colour reset, emotes,
join from script), complaint record lookup, voice roster/session updates,
user list add/remove and title earned handlers, honor/feed pet/tradeskill/
open lock combat log messages, pending user list display.

Callees ported: ComSatClient_LeaveAllSessions and its member notify,
PlayDance, CGDanceStudio::HasDance (dance table keyed by name),
GetMaxPlayersForMap, CGPlayer_C::SendTextEmote, CGUnit_C::Unk724410.

0x4CFB80 (m_paused++) renamed CGChat::Pause; CGChat::LeaveWorld is now
0x4FB190. Pause/Resume/IsPaused and m_paused moved from
SoundInterface2Foley.cpp to ChatFrame.cpp.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 08:35:26 +02:00
SatyandClaude Opus 5.5 74f50d713b M2Shared: allocate x64 .anim and vertex overflow buffers near m_data
M2Array stores a signed 32-bit self-relative offset. On x64 a separate
heap block can lie more than 2 GB from m_data, so relocated low-priority
.anim sequence data wrapped and crashed in ProcessEventCallbacks.

Add OsAllocNear/OsFreeNear (Win64): reserve a block within 1.5 GB of an
anchor. x64 now uses it for .anim buffers (load, cancel, destructor) and
for the skin vertex overflow, which again follows the Win32 structure
(m_flags |= 8, freed in ~CM2Shared). Texture combo arrays keep growing
m_data. All new code is under WOWDECOMP_ARCH_64.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 08:35:26 +02:00
SatyandClaude Opus 5.5 b3125780a7 Port achievement module, quest POI frame, addon and player helpers
Achievements: BuildOutputString, ReleaseInspect, IsRealAchievement,
IsSupersededByCompleted and all remaining Script_ functions (info,
criteria, statistics, comparison, tracking, links, completed quests).
Adds CGTooltip::GetAchievementHyperlink and GetCurrencyShortText.

Also: CGQuestPOIFrame blob merge/outline/render data, Render, AddQuest,
RemoveQuest and scripts; CGQuestLog POI lookups; CGGameUI::Reload;
CGPlayer_C::UpdateGhostStatus and TogglePlayerFlag; addon URL/update
helpers and glue addon scripts.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 07:55:55 +02:00
SatyandClaude Opus 5.5 0470ad7933 M2Shared: x64-safe combo/vertex arrays, ignore runtime header bits from files
- x64: texture combo, transform combo and converted vertex arrays are
  appended to a grown m_data buffer instead of separate heap blocks, so
  the self-relative 32-bit M2Array offsets always reach them; they are
  freed with m_data (destructor frees only on Win32)
- FinishLoading clears header bits 0x20/0x40 from the file; the client
  uses them to mark arrays it allocated, and later-expansion models set
  them, which made the destructor free a pointer into the file buffer

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 07:11:14 +02:00
SatyandClaude Opus 5.5 e9c8ecab21 Add WOWDECOMP_DISABLE_SIGNATURE_CHECKS build option
When ON (DISABLE_SIGNATURE_CHECKS=1), the client skips the signaturefile
MPQ MD5 checks, FrameXML_CheckSignature reports .toc files as valid with
the digest of the files on disk, and GlueXML, FrameXML and AddOn loading
skip their post-load digest comparison. OFF keeps the original checks.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 06:54:51 +02:00
SatyandClaude Opus 5.5 d71b1fbe38 WowClient: output name override, stand-in link launcher, continue option
- WOWCLIENT_OUTPUT_OVERRIDE names the executable (Waystone / WaystoneDev
  from re/tools/build)
- WOWCLIENT_STANDIN_LINKER runs a link launcher that turns unresolved
  symbols into stand-ins (Ninja / Visual Studio CMake builds)
- WOWCLIENT_STANDIN_CONTINUE compiles the stand-in runtime to log and
  continue by default
- Ignore out/ and the local CMakeSettings.json

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 06:33:43 +02:00
SatyandClaude Opus 5.5 bbc9c6ee58 Port the calendar module
- CGCalendarEvent with its real layout: invites, sorting, setters, packets
- CGCalendar: send-calendar handler, invite/lockout/alert handlers,
  context menu actions, event alarms, pending invite list
- All remaining calendar Lua scripts
- CalendarDayEvent fields, CalendarEventData clipboard base, pending
  invite node and dynamic holiday texture name
- Helpers: CGameTime callback register/unregister, CanEditGuildEvent,
  FriendList::IsFriend, FixCharacterNameCase
- RemoveEvent sends the guild flag as u8 (width check)

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 05:58:30 +02:00
SatyandClaude Opus 5.5 88b375105b Port run-87 hit stand-ins and fix world map zone lookup
- WorldMap: GetMapAreaFromPos indexed the zone grid with x/y swapped
- FriendList: SMSG_FRIEND_STATUS handling chain with name callbacks
- ChatFrame: channel roster display, name query callback
- Calendar: day event lists, holidays, filters, event occurrence
- Grunt LogonStoredSession, CGUnit_C::UpdateUnitNameColor

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 05:22:05 +02:00
SatyandClaude Opus 5.5 246f7ceb60 Port run-86 hit stand-ins: calendar, LFG, voice, party stats, quest POI icons
Ports the 19 stand-ins hit in run 86 with their direct dependencies:
calendar month/event-index scripts and helpers, LFG comment/leave,
voice and mute status, party member stats packet with stat change
build/dispatch and arena opponent slots, auto-complete flag removal,
knowledge base setup failure event, and quest POI icon placement.

Fixes: quest POI icon coordinates are int32 (binary uses fild), POI
overlap radius truncates the map span to int, calendar day event count
is unsigned, party pet name is a char field.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 04:41:22 +02:00
SatyandClaude Opus 5.5 6027112a59 Port stand-ins after run 85: UI script modules, AuctionHouse, Commentator
Ports the stand-ins hit since run 85 and the follow-up script batches:
RaidInfo, PartyFrame, BarberShop, ArenaTeamInfo, SkillInfo, InputControl,
petitions/guild registrar, ItemText, Tutorial, ContainerFrame, QuestLog,
ActionBar, ClassTrainer, UIMacros, GuildBank, AuctionHouse and Commentator.

Fixes found on the way: AuctionHouse sell items are a fixed inline array
(IsItemForSell read garbage), GetSellItem returns the container GUID,
Commentator instance key is read/written as u32/u16/u8 and skirmish
commands send a u32 flag, GetArenaMember returns uint64 in edx:eax.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 04:14:58 +02:00
SatyandClaude Opus 5.5 6a3666e4b6 Port run-83 hit stand-ins and fix phantom terrain walls blocking movement
- Fix CMap::GetChunkFacets: impassable test uses the chunk MapObjFlag
  (MAPOBJ_FLAG_IMPASSABLE at +0xC) like 12340, not MCNK header flag 0x40
  (vertex colours). Most chunks got 32000-high wall facets, so the player
  could jump but not walk.
- Ship paths: GetPosition, path time, accel/decel distance, roll/pitch.
- Transports: Transport::UpdateMovement, CollideWithTransport, owner matrix.
- Map objects: IsAllLoaded, footprints, TriData query chain (QueryTris,
  GetTrisTerrain/Chunk, GetTriSubchunk, QueryTrisMapObjDefs),
  QueryIntersectingModels.
- Water ripples, projected-texture shadow drawing (shadow.cpp).
- World states, LFG best random dungeon, quest POI, ComSat session lookup,
  blood record, virtual items, guild roster query.
- Logout path: tradeskill close, LCD, DBCache_ClearPending, chat/macro/
  saved-variable/account-data saving, tracked quests/achievements/
  tutorials, UnloadAddOns, SaveAddOnEnableState, ~CGWorldFrame,
  SmartScreenRectShutdown.
- Fixes: TriData batch heights stored as float* (was truncating uint32 on
  x64), TimeInRange is a ShipPath member, ComSat lookup takes the session
  type, roll/pitch names swapped in MapObjTransport::UpdateMovement,
  removed windows.h from Object/Passenger.h.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 15:33:24 +02:00
SatyandClaude Opus 5.5 dab29ba6ad Add AssetCheck tool: scan MPQs and loose Data files the way the game loads them
Checks M2/skin/anim, WMO root/group, BLP, ADT/WDT/WDL and DBC files in
game archive order and priority, multithreaded via per-thread Mopaq
handles, with errors, warnings and listfile findings in separate logs.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 10:57:56 +02:00
SatyandClaude Opus 5.5 f24e731415 Port hit stand-ins: unit swim/flight/vehicle, footprints, shadow query, liquid sounds, weather, world states, game object types, friend list packet
Old list #26-#77 and new list #1-#25: unit movement/vehicle passengers,
missile trajectory, trade skills, corpse/spirit healer UI, map flight
bounds, footprints, low detail render, shadow query gather/render,
CMapArea liquid sounds, weather type/pos deltas, world state init/set,
transport/chair/animated game objects, contact list packet, macros,
tracked achievements, tutorials, dungeon difficulty.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 10:10:31 +02:00
SatyandClaude Opus 5.5 37d966a503 Port hit stand-ins #1-#23: LFG, autocomplete, nether/fog FFX, BN friends, skills, account vars, macros, area triggers, FriendList, auto mouseover, GameUI message handler
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 08:02:45 +02:00
SatyandClaude Opus 5.5 9ddddebc34 Port minimap, item moves, cursor, character info, names, nameplates, combat text
- Fix RsSet render-target upload check (indoor rendering corruption)
- Minimap tracking/hover, world map refresh
- Bag/bar item moves, swaps, equip, item sounds, spell on cursor
- Character info stats, titles, model preview
- Unit/player names (PLAYERNAMEDESC render, name strings, raid icons)
- Nameplates: CGNamePlateFrame, CGSimpleHealthBar, unit glue, SmartScreenRect overlap solver
- Floating combat text: WORLDTEXTSTRING, render batch, PlayerName text slots
- Fix unescaped raid-icon texture path in PlayerNameInitialize

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 07:00:36 +02:00
SatyandClaude Opus 5.5 175f55b399 Port spells, loot, effects, missiles, level-up and non-gameplay UI stand-ins
Gameplay:
- Spell system pieces, spell effects lifecycle (CEffect), special effects,
  procedural/loot effects, impact visuals
- Unit anim events: AnimEventCallback, HandleAnimEvent, HandleCombatAnimEvent,
  parry anims, vehicle bone grab/throw events
- CGUnit_C::CreateMissile (target, point, point-array overloads)
- Loot: CGLootInfo/LootWindow/LootDisplay, loot rolls, loot packets and scripts
- Bags/items: FindItem, container/inventory mirror handlers, UseContainerItem
  (sell/bank/mail/trade/auction/guild bank), UseItem, item lock/unlock
- Threat, power regen, XP gain, quest item updates, skill changes
- Packet_Group_9 (level up, item push, exploration, taxi, bind, roll, ...)
- ChatBubbleShow/Remove
- x64 fix: map entity callback param is uintptr_t (pointer was truncated)

Non-gameplay (parallel batch): chat channels/settings, chat bubble frame,
game/server time, minimap POIs and init, mail, class trainer, skills,
achievements, currencies, calendar, world states, world map arrow/ping,
commentator, merchant buyback, battleground/arena info, EnterWorld for
~15 UI modules

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 03:06:16 +02:00
SatyandClaude Opus 5.5 be4da66e93 Port quest mirror handlers and quest giver dialog
- CGPlayer_C::SetActiveMirrorHandlers / UnsetActiveMirrorHandlers, OnUpdateQuest,
  QuestAcceptCallback: quest log refreshes on accept/abandon
- CGQuestInfo helpers (accept, decline, query, complete, reward, item info,
  quest list/item request) and the 18 QuestFrame Script_ functions
- Quest giver packet handlers: quest list, request items, complete,
  invalid, failed (+ reward/failed/complete callbacks)
- CurrencyBreakdown, GetCurrencyText, CGQuestLog::IsQuestExpiredByID,
  RemoveQuestPointDisplay, CGGameObject_C::GetPageTextMaterial,
  DBCache<QuestCache>::GetRecord offset

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 12:16:24 +02:00
SatyandClaude Opus 5.5 6f9f1d9835 QuestLog: port objectives, quest text tokens, turn-in, XP, faction rewards, POI data
- QuestParserParseToken ($N $C $R $G $T $B $W $E $D $K $A), countdown text
- GetQuestLeaderBoardByID/ForObject, QuestLogLeaderBoardParams real layout,
  Lua GetQuestLogLeaderBoard, quest log query callbacks
- OnQuestGiverOfferReward, CalculateExperience, quest XP aura multiplier
- ProcessQuestLogRewardFactions / ProcessQuestRewardFactions
- HandlePOIQueryResponse, POI slot recycling, IsOnQuest, LoadTrackedQuests,
  AddQuestPointDisplay, display race/class name helpers

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 11:48:04 +02:00
SatyandClaude Opus 5.5 e6b538a70c Gossip/Merchant/QuestLog: port Lua scripts, quest log update and quest cache insert
- Gossip quest lists, option/quest selection, IsLowLevel
- Merchant item info/links/costs, buy/buyback/sell cursors, repair
  (CanUseItem, BuyItem, buyback price, pvp medal helpers)
- Quest log: CGQuestLog::Update, FilterAndSortQuests, sort comparators,
  collapse/expand, watches, special item, 69 Script_* functions
- QuestLog helpers: GetQuestIndex, IsQuestCompleteEx, HasNoObjectives,
  titles/tags/levels/sort ids, leaderboard counts, item drop counts
- DBCache::AddItem generic template (quest cache records were dropped)

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 11:29:38 +02:00
SatyandClaude Opus 5.5 e41a19fe93 Gossip/Quest/Merchant: port NPC reply handlers
- Packet_SMSG_GOSSIP_MESSAGE, CGGossipInfo::ClearOptions/SetGossipText
  (NPC text cache, weighted text pick, emotes, translation)
- CGPlayer_C::OnQuestGiverQuestDetails, CGQuestInfo::SetState,
  SetLogDescription, AddReward, ClearState, ClearQuestItems
- CGPlayer_C::OnListInventory, RequestAllItemPurchaseData,
  CGMerchantInfo::SetMerchant and its item-stats callback
- QuestParserParseText (token handler still a stand-in),
  CGUnit_C::PlayEmotes

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 10:51:33 +02:00
SatyandClaude Opus 5.5 e664d4c121 WorldFrame/Player: port mouseover hit test, cursor tracking and NPC right-click
- CGWorldFrame hit test (HitTestPoint, FindClosestModel, selection legality)
  and cursor tree (OnLayerTrackObject, CursorTrack*), Cursor mode helpers
- Spell_C targeting predicates used by the hit test and cursor
- CGPlayer_C::HandleOnRightClick and the TalkTo*/ShopFromMerchant requests
- CGGameUI Set/Clear/CloseInteraction and the per-frame close functions
  (gossip, quest, merchant, bank, guild bank, registrar, stable, petition,
  battlemaster, trainer), mail ClearSendMail, talk emotes
- Zero-initialize 23 WOWGUID locals that were read uninitialized

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 10:34:48 +02:00
SatyandClaude Opus 5.5 1154792edb Tooltip: port item tooltips, item/name caches and hyperlinks
- CGTooltip::SetItem with section helpers, TooltipItemCallback,
  Script_SetBagItem, Script_SetInventoryItem, Script_SetHyperlink
- DBCache AddItems/DenyItem/Invalidate; NameCache AddItem, reverse
  name index (non-owning key), NameCache::Copy
- ItemLinkInfo::GetItemIdFromLink, CGMerchantInfo::GetRepairCost,
  CGUnit_C::GetPlayerDiscount, CGEquipmentManager::GetSetList/GetSetByID
- item/player/enchant helpers used by the item tooltip
- fix SetSpell callers passing the last rank arguments in the wrong order

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 09:43:18 +02:00
SatyandClaude Opus 5.5 b5ee377ba5 Tooltip: port spell tooltip, spell description parser and formula engine
CGTooltip::SetSpell (split into inlined section helpers), Lua SetSpell/SetSpellByID,
QuestTextParser spell text parser, MathState formula engine with MATHOP enum,
spell math (min/max points, duration, cast time, range) and talent tooltip text.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 08:00:10 +02:00
SatyandClaude Opus 5.5 8643d3761e Spellbook: port spell book Lua scripts and spell/rune helpers
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 07:10:25 +02:00
SatyandClaude Opus 5.5 9beb4faf5d Glue: port TokenEntered
- Script_TokenEntered (0x4DC4D0)
- CGlueMgr::LoginEnterToken (0x4D8080): status dialog, forward token
- ClientServices::LoginEnterToken (0x6B0AA0): login object EnterToken

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 07:04:07 +02:00
SatyandClaude Opus 5.5 9d660c24f5 Glue: port LaunchURL and GetCreditsText
- ClientServices::LaunchURL (0x6B0F30) -> OsLaunchURL
- Script_LaunchURL (0x4DC1C0), Script_GetCreditsText (0x4DCD60)

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 06:41:23 +02:00
SatyandClaude Opus 5.5 3b76648777 Client bring-up: Lua stand-in ports, add-on loading, world map, combat log, locale fix
- Port hit-order Lua stand-ins (unit tokens, tooltips, combat log filters and
  current entry, bags/containers, quest POI, minimap, titles, world states,
  trade, group roles, runes, mirror timers, saved-variable registration, Quit)
- LoadAddOn: real add-on loading (Blizzard_CombatLog etc. now load)
- CombatLogEntry::PushEvent: COMBAT_LOG_EVENT arguments
- World map chain: SetMapToCurrentZone, SetMap, GetWorldPosition, landmarks,
  overlays, highlight, zones, dungeon levels, player position
- OpenArchives: locale index was off by one (enUS read the koKR DBC slot,
  leaving zone/map names empty)
- Zone/area sound chain, invisible units (spline mode read size), raid/bag
  crash fixes, stand-in console, waystone icon for all executables
- Coding-rule cleanups: statics/includes at the top, event enums, Lua
  _Scripts layout

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 06:31:10 +02:00
SatyandClaude Opus 5.5 18c46cb87e Client bring-up: in-world camera, input, movement, unit rendering
Ports verified against 12340 that take the x64 client from character
login to a playable world:

- Camera: SetView/ResetView, motion, free-look facing, tracking, bobs,
  liquid bump, world collision; camera Lua scripts
- Input: world frame key/mouse layers, default action, mouselook,
  turn/pitch player, TurnOrAction/CameraOrSelectOrMove scripts
- Movement: legal facing range, turn/pitch/raw facing events, transport
  status, move spline copy, unit update info, smooth facing, anim end
- Units: component and extended display init, model fade/scale,
  entity sort table, RenderEntitys, split-body culling
- Interiors: WMO group bounds, BSP segment link query, face linking,
  interior lighting
- Collision: CMap::QueryFacets closure with frustum queries and NDCClip
- UI: game UI mouse filters, client control state, faction standing
  packet, many *_Scripts.cpp Lua tables; name generator dictionary fix

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-29 23:04:53 +02:00
SatyandClaude Opus 5.5 3b857f3eb0 Object port: object classes, object manager, input control, WOWGUID type
- CGObject_C base, CEffect, CObjectEffect/CObjectEffectManager effect states
- Unit, Player, Item/Container/Bag, Corpse, DynamicObject, GameObject and
  all GameObject type classes (vtables matched slot by slot), Movement,
  MovementShared, Missile, Vehicle/Passenger/Camera, combat log, caches
- Client object manager (0x4D3100-0x4D7880) incl. SMSG_UPDATE_OBJECT,
  SMSG_COMPRESSED_UPDATE_OBJECT, SMSG_DESTROY_OBJECT; type ctors/PostInit
- CGGameUI::CanPerformAction and the ready part of CGInputControl
- Layouts named from descriptor fields and code; CM2Model 0x134 matrix,
  CClientObjCreate tail, CGUnit_C/CGPlayer_C sizes 0x1008/0x1958
- WOWGUID struct replaces the IDB's WGUID low/high pair and guid uint64_t;
  SmartGUID derives from it; member functions returning a guid keep
  uint64_t (MSVC returns class types from members via hidden pointer);
  structs with 4-aligned guids in 12340 use pack(4)

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-29 12:27:05 +02:00
SatyandClaude Opus 5.5 15f9e2e10a Liquid: define the inlined IEnvironment/IGeomFactory destructors
Both are empty in 12340 and only exist inlined into the derived
destructors; the MapViewer hit them as stand-ins on shutdown.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-29 07:58:22 +02:00
SatyandClaude Opus 5.5 a549f3ed45 World port: CMapStaticEntity::ModelEventCallback
Doodad M2 events: looping/one-shot/stop sound kits on the doodad's
sound object, and transport game object effect states. Declares
CObjectEffectManager::EnterState/ExitState (not ported yet) and names
CGObject_C::m_effectManager (0xCC).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-29 07:55:33 +02:00
SatyandClaude Opus 5.5 380d639080 World port: occluder, occlusion volume and debug frustum draws
RenderDetailDoodads now ends with the three draws 12340 calls there:
RenderOccluders (draws and recycles the visible occluders),
RenderOcclusionVolumes (Enable_PortalVis) and RenderDebugFrustum
(never enabled in 12340). Names are guesses, see docs/<offset>.md.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-29 07:50:19 +02:00
SatyandClaude Opus 5.5 4a571e727c World port: WMO water, fog, area updates, purge chain, detail doodads
- Barriers, shadow/portal queries, underwater selection, hit testing
- Interior water: PolyClipper, ClipGroupGeometry, liquid index fix
- Area updates, barrier updates, purge/free chain for areas, chunks,
  doodad and map object defs, detail doodad update list
- Water ripples, terrain pixel shader path, liquid shader toggles
- Detail doodads: creation per chunk, pools, batching, vertex/index
  fill, shader and fixed-function render state, RenderDetailDoodads
  (trailing occluder/debug draws still to port), CMapChunk::SelectLights
- DayNight moved to WoW/Source/WorldClient
- MapViewer: fog, WMO water, detail doodads; diagnostics removed

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-29 07:43:15 +02:00
SatyandClaude Opus 5.5 f6d07ea346 World port: liquids, map load chain, terrain rendering in MapViewer
Liquid system ported from 12340 (LiquidSystem module, chunk/WMO liquid, wave
manager, geometry factories); CMap load chain (Load, LoadWdt, low-detail WDL,
lights, CreateMapObjDef, PurgeMaps); CMapChunk create/batch/vertex/index code;
CMapRenderChunk; frustum stack and scene cull helpers. MapViewer renders
terrain through a viewer-only shortcut (ViewerWorld.cpp). Engine fix: int
render-state setters write the full pointer-sized slot (x64 texture crash).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-28 08:07:38 +02:00
SatyandClaude Opus 5.5 d39896a422 Move CWFrustum to Tempest; remove unused SHA1Broken and XML headers
- CWFrustum (CFrustum + free-list link at 0xF4, RTTI .?AVCWFrustum@@) moves from
  _Triage to Engine/Source/Tempest; the redundant forward declaration is gone
- _Triage/SHA1Broken.h and _Triage/XML.h had no users

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-28 02:53:08 +02:00