5608 Commits
Author SHA1 Message Date
TS-CaandTS-Ca a6d82e9a3c Images: decode TIFF screen and link proxies at a reduced size (#2381) (#3016)
* Images: decode TIFF screen and link proxies at a reduced size (#2381)

Stream placed TIFFs a strip or tile row at a time through
craft_image_codecs::TiffBands into 1/2, 1/4 or 1/8 RGBA buffers (512 MiB
per band, 1 GiB reduced output) with alpha-weighted box averaging and
embedded ICC / working-CMYK display conversion.

Wire reduced TIFF sizes and estimates into designcraft-render's screen
mip cache (clamping oversized rasters to reduced levels when zooming in
so decode_full does not poison the cache entry) and linked-file proxy
generation.

* Images: round up in finest_level and cover 512 MiB single-strip cap (#2381)

Match the reduced decoder's round-up dimensions (`div_ceil(2)`) when
selecting `finest_level` so odd oversized widths such as 131071x128 pick
a level whose decoded buffer fits `Pixmap` and the 1 GiB RGBA cap before
cropping.

Replace the truncated header-only single-strip assertion with a complete
zlib-compressed single-strip CMYK TIFF above the 512 MiB band limit.

* Images: count orientation/float/Lab in reduced TIFF estimate and lighten tests (#2381)

* Images: include partial-cell map bound in reduced TIFF peak estimate (#2381)

---------

Co-authored-by: TS-Ca <[email protected]>
2026-11-21 13:00:28 -05:00
Dylan M. Taylor d7401b647b images: restore strict JPEG APP1 EXIF scan (craft-libs#785) (#3105) 2026-11-21 12:36:17 -05:00
Dylan M. Taylor 0fc7a7894c images: replace local JPEG EXIF and PNG pHYs scans with shared readers (craft-libs#785) (#3101)
* images: use shared JPEG EXIF and PNG pHYs readers (craft-libs#785)

* images: repin craft-libs and use png_probe::pixels_per_meter (craft-libs#785)

* Cargo: patch vendored vello/linesweeper from craft-libs

* xtask: update pdf-deps craft-libs rev to c60e7a20
2026-11-21 12:14:16 -05:00
aiongg 706560d10c Merge pull request #2796 from aiongg/open-background
Open: read and parse documents off the UI thread
2026-11-21 00:39:04 -05:00
Dylan M. Taylor 4000591c66 render, images: align JPEG export guards and add export/probe parity tests (storytold/craft-libs#778) (#3073) 2026-11-20 12:52:22 -05:00
Dylan M. Taylor 63138e5642 mcp: add protocol transcript tests for initialize, cancel, and batch (#3071) 2026-11-20 11:36:54 -05:00
Dylan M. Taylor 77f32556ad images, render: align JPEG density/orientation and PNG output parity (storytold/craft-libs#778) (#3062)
* images, render: align JPEG density/orientation and PNG output parity (storytold/craft-libs#778)

* test(images): fix borrow in tiff_bytes_with_orientation helper

* test(images): avoid u32 shift overflow in irb_app helper
2026-11-20 08:40:35 -05:00
Dylan M. Taylor e8ac8790c9 idml: delegate remaining IDML part schema emission to craft-idml (#778) (#3047) 2026-11-20 07:16:52 -05:00
Dylan M. Taylor 055b590931 images: share resolution and header probes (#3022)
* deps: pin craft-libs uniformly to 3dff4793

* images: share resolution and header probes via craft-image-codecs
2026-11-20 06:21:41 -05:00
aiongg 0f9ea61053 Adopt the shared AGENTS.md (RFC-0072) and test rules (RFC-0071) (#3046) 2026-11-20 18:09:15 +07:00
Dylan M. Taylor a354990c2b idml: separate designmap schema emission to craft-idml (#778) (#3044)
* idml: delegate designmap schema emission to craft-idml (#778)

* deps: align craft-xml rev with craft-idml (2f1e0a2a)

* fix(idml): remove redundant String::into() for clippy
2026-11-19 18:56:55 -05:00
Dylan M. Taylor 2ac602c134 mcp: cut over JSON-RPC/MCP framing to craft-mcp-server (#3042)
* mcp: cut over JSON-RPC/MCP framing to craft-mcp-server

* mcp: set tool_errors_as_results for transcript parity

* mcp: preserve stdio and resource errors and synchronize lockfile
2026-11-19 18:07:48 -05:00
FredApps 129abd936b Merge pull request #3017 from FredApps/refactor/shared-bmp-density
Images: use the shared BMP density probe
2026-11-19 23:19:53 +07:00
FredApps 17a557c79d Merge pull request #3019 from FredApps/fix/3018-arabic-system-ui-fallback
fix(ui): discover installed Arabic fallback fonts
2026-11-19 23:17:54 +07:00
FredApps d6bac4dc20 fix(ui): discover installed Arabic fallback fonts (#3018) [skip ci] 2026-11-19 17:05:28 +01:00
Codex 265220f737 Integrate merged shared dependency prerequisite [skip ci] 2026-11-19 16:46:51 +01:00
.CooCooandCodex 209c8ab919 Dependencies: unify craft-libs at 30a568b97 for shared cutovers (#2889)
* Dependencies: take craft-libs main at 3af718585c

Every craft-libs dependency and patch in Cargo.toml now uses one
revision, craft-libs main at 3af718585c60d8e9bab05c241d7a28282c61f85c.
Cargo.lock changes only craft-libs packages.

The newer crates need these changes:

- craft-xml is at one revision, so the craft-xml-dtd alias is removed
  and the DTD adapter uses craft_xml::dtd.
- craft-svg's gradient paint carries its stops and its pattern paint
  carries its tile. Paste uses the first stop's color as before, and
  skips embedded image nodes, which the scene still counts for the
  paste warning.
- craft_svg::sniff::viewbox_size came from a craft-libs commit that is
  not in main. The IDML importer keeps the same bounded viewBox sizing
  as a local function and no longer depends on craft-svg.
- craft-svg's Limits has tree_depth, the depth after references such as
  <use> are followed. Images set it to MAX_SVG_DEPTH, and a test checks
  that a long <use> chain is refused.
- craft-ui adds the flyout width and top layout actions, which the
  iconic dock sends when a flyout's side or top edge is dragged.
  window.panel.layout rejected every action it did not list, so both
  are now checked like the other per-panel actions. A test checks that
  they are kept for a registered panel and refused for an unknown one.

* Panels: a group docked back keeps its flyout's width and top

craft-ui at 3af718585c saves a dock group's flyout width and top when the
group floats and restores them in its own restore path. Dock Panel for a
group that floated as a whole goes through DesignCraft's own path, which
replayed the height, minimized state and column but not the two flyout
values, so a widened or moved flyout came back at its default size and
place. The path now replays ResizeFlyoutWidth and MoveFlyoutTop with the
other saved state.

The images test's doc comment gives the nesting depth of its `<use>`
chain as four levels, counting the root as one.

* PDF: pdf-deps expects craft-libs 3af718585c

`cargo xtask pdf-deps` checks that craft-pdf, Krilla and the Hayro
crates resolve to one craft-libs revision named in xtask. The workspace
now takes them at 3af718585c, so the check expects that revision, and
docs/pdf-backend.md names it.

* IDML: a placed SVG with a byte order mark keeps its viewBox size

The importer's viewBox sizing looked for `<` as the first byte, so a
linked viewBox-only SVG that starts with a UTF-8 byte order mark was
placed at its GraphicBounds instead of its viewBox size. The mark is now
skipped first.

* Tests: the discarded-pass input test clears its texture changes

discarded_pass_does_not_acknowledge_injected_input dropped its frame
output without clearing textures_delta, so epaint panicked on drop
whenever the frame carried a texture change. With craft-ui at
3af718585c it failed in 2 of 3 full ui-egui test runs. The test now
clears it, as the tests around it do.

* Dependencies: take craft-libs crates from craft-libs main at 453b0da782

Every craft-libs git dependency and [patch.crates-io] entry moves from
3af718585c to 453b0da782, and xtask pdf-deps and docs/pdf-backend.md
name the new commit.
Cargo.lock changes only the source revision of the 50 craft-libs
packages; no package is added or removed and no registry package
changes version.

craft-update now inspects a release the app offers on a thread of its
own (storytold/craft-libs#1149), so the prompt opens at a later tick
instead of inside offer. updates_ui's startup_prompt_shows_and_closes
waits for that answer: it ticks on each immediate repaint request the
offer's thread makes until the prompt is open.

* Updates: the startup prompt test fails instead of waiting forever

offer_and_wait waits for the one immediate repaint the offer's thread
requests after it answers, ticks once, and then asserts that the prompt
is open. Before, it waited for a repaint after every tick, so an offer
that ended without a prompt (the launcher pinning the app while the
files were read) blocked the test instead of failing it.

NOTICE names craft-libs 453b0da782 as the source of the patched Hayro
crates, the revision Cargo.toml fetches them at, adds hayro-postscript,
which is patched from the same revision, and names the PdfCraft
revision the snapshots were re-synced to.

* IDML: a placed SVG's viewBox size comes from its root tag alone

svg_viewbox_size reads only the root's start tag instead of parsing the
whole file, so placing the same large linked SVG many times no longer
parses it each time. Files over 16 MiB still give no size. A viewBox
with a value that is not a number, such as "0 0 junk 200 100", now
gives no size, so the frame's GraphicBounds size the graphic; before,
the bad value was dropped and the other numbers were read as the
viewBox.

* IDML: a placed SVG's root tag is read with craft-xml's first_start

svg_viewbox_size reads the root's start tag with Options::first_start and a
pattern that matches any name, in place of its own event loop. A file whose
root is not an svg element still gives no viewBox size; the placement test has
a case for it.

* Cargo: drop the unused craft-xml-dtd alias again

The merge of main kept the craft-xml-dtd alias at craft-libs a5ac3aa05c, which this branch had removed. No crate uses it, and Cargo.lock does not change.

* chore: resolve shared BMP dependency pin with Cargo [skip ci]

* test(color): align FOGRA39 references and isolate no-BPC accuracy [skip ci]

---------

Co-authored-by: Codex <[email protected]>
2026-11-19 22:45:28 +07:00
Codex 81ca3defc4 refactor: use shared BMP density probe [skip ci] 2026-11-19 16:01:54 +01:00
Codex 06324f5291 chore: resolve shared BMP dependency pin with Cargo [skip ci] 2026-11-19 15:46:38 +01:00
Codex c4507ad3e6 prepare: integrate reviewed Design pin sources for lock generation [skip ci] 2026-11-19 15:40:51 +01:00
Dylan M. Taylor 88f5a00e38 test(images): fit 1-component progressive JPEG test under 512 MiB decoder budget (#2998)
* test(images): fit 1-component progressive JPEG test under 512 MiB decoder budget

* test(render): update reduced JPEG peak estimate to 16 B/px for craft_jpeg
2026-11-18 23:20:04 -05:00
Alejandro Castrillóncoderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>aiongg
c0721c08b4 fix(canvas): restart the text caret blink on typing, caret moves and clicks (#1953)
* fix(canvas): restart the text caret blink on typing, caret moves and clicks

* fix(canvas): stop caret blink repaints in an unfocused window

* Update crates/ui-egui/src/canvas/tests.rs

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Apply review fixes

- crates/ui-egui/src/canvas/input.rs
- crates/ui-egui/src/canvas/text_overlay.rs

* Apply review fixes

- crates/ui-egui/src/canvas/input.rs
- crates/ui-egui/src/canvas/text_overlay.rs

* Fix failing CI check

- crates/ui-egui/src/canvas/input.rs

* remove focus guard and respective test

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: aiongg <[email protected]>
2026-11-19 08:37:12 +07:00
Dylan M. Taylor a8f6be842e cutover: use craft_jpeg::decode_reduced (#2991) 2026-11-18 19:08:41 -05:00
dotCooCoo b23918dfbe Cargo: drop the unused craft-xml-dtd alias again
The merge of main kept the craft-xml-dtd alias at craft-libs a5ac3aa05c, which this branch had removed. No crate uses it, and Cargo.lock does not change.
2026-11-18 15:31:44 -08:00
Dylan M. Taylor a73e3def53 Merge pull request #2550 from pepen11/up/psd-resolution
Place: a Photoshop file comes in at its own resolution
2026-11-18 18:02:40 -05:00
dotCooCoo 5b05c876f8 Merge main into chore/craft-libs-3af7185 2026-11-18 13:56:05 -08:00
Dylan M. Taylor 12fe81ca01 images: cut over EPS bounding_box and is_eps to craft-ps (#2972) 2026-11-18 16:30:59 -05:00
Dylan M. Taylor 77de9c4f5f Place: reconcile PSD resolution with shared parser
Preserve Josef Mlčůch’s PSD placement work and tests while adapting resource lookup to the current shared zero-copy HeadView and ResolutionInfo. Keep current main decoding and sanity limits.
2026-11-18 15:27:36 -05:00
autocraft-bot[bot] 5ce12193af Merge pull request #2954 from makesomethingshit/fix/2694-idml-data-merge-counts
Data Merge: count fields after reopening IDML (#2694)
2026-11-18 15:00:20 +00:00
autocraft-bot[bot] 05f08db538 Apply review fixes
- crates/engine/src/cmd/datamerge.rs
- crates/engine/src/cmd/datamerge/tests.rs
2026-11-18 14:22:41 +00:00
autocraft-bot[bot] f5a94959f9 Merge pull request #2946 from Hamza0101/fix/separations-say-when-dpi-is-lowered
Separations: say when the resolution was lowered to fit the plate size
2026-11-18 13:36:30 +00:00
.CooCoo 14fb342b26 Story Editor: View › Story Editor › Show/Hide Style Name Column, and a draggable column width (#1797)
View › Story Editor › Show/Hide Style Name Column shows or hides the
column of paragraph style names. The column width can be dragged
between 40 and 400 points, and the bar follows the pointer back from
those limits. The setting is remembered.
2026-11-18 20:00:41 +07:00
autocraft-bot[bot] 53b80e7196 Apply review fixes
- crates/engine/src/separations.rs
2026-11-18 13:00:36 +00:00
Hamza Naveed 0c90568d97 Hyphenation: a Korean word or an address is not broken by English rules (#1754)
A whitespace-delimited token that carries Hangul, kana or Han, or that
reads as an address, is not hyphenated by English rules. Breaking at a
hyphen the author typed is still allowed. The ligature / visible-source
follow-up is in #2196 and #2197.

Fixes #1688.
2026-11-18 19:35:21 +07:00
autocraft-bot[bot] 294cef70d6 Apply review fixes
- crates/engine/src/separations.rs
2026-11-18 12:24:49 +00:00
Hamza Naveed 1d547b307f A cross-reference's PDF link covers the text it generated (#1495)
A cross-reference's PDF link annotation covers the text it generated,
not only the first letter of the marker. List labels and decorative
zero-length glyphs are left out of the rectangle, and clickable spans
are split around unselected visual text.

Related to #1446.
2026-11-18 19:04:59 +07:00
makesomethingshit 9c9641c848 #2694: count data merge markers after IDML reopening 2026-11-18 20:59:05 +09:00
Hamza 15ec895e4f Separations: the params text says A5 at 300 dpi is already lowered 2026-11-18 16:39:41 +05:00
Hamza 0ff88f981d Separations: say when the resolution was lowered to fit the plate size (#2945)
ink.separations accepts 9-300 dpi, but craft-prepress renders each plate within 4 megapixels, so a page larger than A5 at 300 dpi was separated at less with an empty warnings list. separate() now adds a warning naming the resolution used and the one asked for, and the command's params text says the resolution is lowered to fit 4 megapixels per plate.
2026-11-18 16:39:17 +05:00
Weyert de Boer 57890e43c2 Scroll overflowing document tabs (#2357)
Document tabs that overflow the bar scroll (trackpad, wheel, or arrows), keep the active tab in view, and list every open document in a menu.

Fixes #2358.
2026-11-18 18:08:50 +07:00
Hamza Naveed b12196eaf0 Fonts: the PostScript name of a variable font's named instance (#1864)
`name` ID 6 names a variable font's default instance, so every instance
was previously embedded under that same name. A named instance's
PostScript name is now built as Adobe TN #5902 prescribes.

Related to #1690.
2026-11-18 17:06:16 +07:00
Adithya Shankaran 697279c56f Automation roots: refuse a network, device or non-disk verbatim path before the file system is asked about it (#2799)
Refuse UNC, device and non-disk verbatim paths in automation roots by their form, before any file-system lookup, and judge each symlink from its own text. This closes the NTLM/WebDAV leak where canonicalize was asked about a path first.
2026-11-18 16:31:52 +07:00
.CooCoo 13bd801db2 Tables: Cell Options › Diagonal Lines draws diagonal lines across cells (#1793)
Adds Cell Options › Diagonal Lines so cells can be drawn with diagonal lines. The dialog applies only to the cells and document it opened for, and PowerPoint export writes the diagonals as cell borders. Includes Swedish catalog rows for the new strings.
2026-11-18 16:31:13 +07:00
makesomethingshit b1bf440cbb fix(fonts): discover named instances before listing paragraph styles (#1246)
For a catalog-only variable family, named instances are discovered before the Font Style combo and the Family menu list their styles, so the first opening is complete. Styles are cached once per popup opening. Synthetic fvar regressions run by default.

Related to #1210.
2026-11-18 16:30:06 +07:00
dotCooCoo 21ddca7344 IDML: a placed SVG's root tag is read with craft-xml's first_start
svg_viewbox_size reads the root's start tag with Options::first_start and a
pattern that matches any name, in place of its own event loop. A file whose
root is not an svg element still gives no viewBox size; the placement test has
a case for it.
2026-11-17 17:50:02 -08:00
autocraft-bot[bot] 3930cff80d Merge pull request #2904 from Hamza0101/fix/create-outlines-vertical-upright
Create Outlines: vertical text keeps its upright glyphs and its columns
2026-11-17 13:55:25 +00:00
autocraft-bot[bot] a7f341fa3a Apply review fixes
- crates/ui-egui/src/canvas/text_overlay.rs
2026-11-17 13:17:34 +00:00
Hamza c4478f92c3 Create Outlines: vertical text keeps its upright glyphs and its columns
Create Outlines built each glyph's outline as horizontal text does. In a
vertical frame the canvas and the PDF export also turn each upright glyph
(PlacedGlyph::vertical_xf), and a frame of several columns put each line in a
group whose children had no transform, losing the frame's quarter turn. CJK
glyphs lay on their sides and the columns became rows.

Each upright glyph now takes its turn, as the renderer applies it, and each
line in the group takes the frame's text turn (Document::text_local).

Fixes #2895
2026-11-17 17:23:10 +05:00
dotCooCoo 56bedabc77 IDML: a placed SVG's viewBox size comes from its root tag alone
svg_viewbox_size reads only the root's start tag instead of parsing the
whole file, so placing the same large linked SVG many times no longer
parses it each time. Files over 16 MiB still give no size. A viewBox
with a value that is not a number, such as "0 0 junk 200 100", now
gives no size, so the frame's GraphicBounds size the graphic; before,
the bad value was dropped and the other numbers were read as the
viewBox.
2026-11-16 23:34:05 -08:00
dotCooCoo 3d6973aa20 Updates: the startup prompt test fails instead of waiting forever
offer_and_wait waits for the one immediate repaint the offer's thread
requests after it answers, ticks once, and then asserts that the prompt
is open. Before, it waited for a repaint after every tick, so an offer
that ended without a prompt (the launcher pinning the app while the
files were read) blocked the test instead of failing it.

NOTICE names craft-libs 453b0da782 as the source of the patched Hayro
crates, the revision Cargo.toml fetches them at, adds hayro-postscript,
which is patched from the same revision, and names the PdfCraft
revision the snapshots were re-synced to.
2026-11-16 23:25:34 -08:00