Commit Graph
1607 Commits
Author SHA1 Message Date
Tanish Manku d96752f8ed Keep an https plugin's headers and session on its own address when it redirects (R1.5) 2026-11-19 19:45:42 -07:00
Tanish Manku cf791b1933 Claim the https plugin redirects line (R1.5) 2026-11-19 19:35:35 -07:00
Tanish Manku aa21ef79f1 Record the gaps found in this week's reviews (R2.9, R5.2, R1.5, R2.7) (#2187)
* Record the gaps found reviewing #1641 and #2043 (R2.9)

* Record the gaps found reviewing #1721, #1849, #2098, #2121, #2154 and #2180
2026-11-19 19:34:11 -07:00
Dylan M. Taylor ee72e20d4a formats: cut over GPU texture and pixel decoding to craft-dds (#778) (#2191) 2026-11-19 20:40:11 -05:00
Dylan M. Taylor 365eade2e6 docs(formats): classify single-app inspector formats (craft-libs#778) (#2192)
* docs(formats): classify single-app formats and add ASAR/AXML/ARSC boundary tests (storytold/craft-libs#778)

* fix(formats): accept Truncated or Malformed for short ARSC header

* test(formats): use < 8 byte header in arsc short header test
2026-11-19 20:23:45 -05:00
Dylan M. Taylor bf7a40f500 Cut over MCP line and JSON-RPC envelope framing to craft-libs (#2188)
* Cut over MCP line and JSON-RPC envelope framing to craft-libs (#778)

* mcp: clone request id before worker thread spawn

* chore: update Cargo.lock for craft-jsonrpc

* mcp: add deterministic stdio transcript parity and framing bounds tests

* chore: repin craft-jsonrpc and craft-mcp-server to craft-libs main
2026-11-19 20:23:15 -05:00
Dylan M. Taylor 539dc205a5 formats: cut over SQLite varint and serial-type length decoding to craft-sqlite (#2190)
* formats: cut over SQLite varint and serial-type length decoding to craft-sqlite

* chore: repin craft-sqlite to craft-libs main
2026-11-19 18:57:31 -05:00
Dylan M. Taylor 1e95b35cba formats: cut over CMS SignedData/SignerInfo framing to craft-pkcs7 (#2189) 2026-11-19 18:34:24 -05:00
ad9660febb Plan honest usage counts and a cost-limit design in the roadmap (R5.3) (#1162)
* Plan honest usage counts and a cost-limit design in the roadmap (R5.3)

* Say a limit that holds has to treat the turn's price as an estimate (R5.3)

---------

Co-authored-by: Simon Koch-Sultan <[email protected]>
Co-authored-by: Tanish Manku <[email protected]>
2026-11-19 16:07:01 -07:00
RRFZandTanish Manku e030b330fc Validate MCP HTTP URLs, refuse HTTPS downgrades, and keep loopback redirects on this computer (R1.5) (#2098)
* Claim R1.5: mcp-http-cleartext-guard

* Validate MCP HTTP URLs and refuse cleartext or loopback redirects (R1.5)

- Parse `url_allowed` inputs with `ureq::http::Uri`, reject userinfo (`@`), validate `https://` hosts/IPv6 brackets and `u16` ports, and delegate `http://` loopback checks to `craft_anything_platform::standin_server::host_is_loopback` so malformed or spoofed authorities (`http://[::1].evil.example.com`, `http://evil.example.com\@127.0.0.1`, `https:///...`) cannot pass.
- Trim `ServerUrl::url` in `Http::new` to match `url_allowed`.
- Enforce `.https_only(true)` on `https://` MCP requests (reporting `RequireHttpsOnly` without echoing the redirect target URI) and `.max_redirects(0)` on loopback `http://` requests so plugin headers and payloads never follow redirects off loopback or across cleartext HTTP.

* Reject mid-host brackets and signed ports, and drain POST bodies in tests (R1.5)

- Reject mid-host square brackets (`!host.contains(['[', ']'])`) and leading `+` signs on ports across `https://` and loopback `http://` authorities in `url_allowed`.
- Drain incoming HTTP `POST` headers and `Content-Length` bodies (and clear inherited socket non-blocking mode) before sending `302` replies in the redirect regression fixtures.

* Follow loopback MCP HTTP redirects that stay on this computer (R1.5)

* Keep MCP redirect hops in one deadline, cancellable, and without configured headers off the configured origin (R1.5)

* Lengthen the per-hop delay in the MCP redirect deadline test and update STATUS (R1.5)

* Keep MCP redirect hops within the caller's deadline and the configured origin (R1.5)

Pass the caller's deadline into post without a one-second minimum, compare origins by scheme, host and effective port, refuse a session started by another origin, keep the path for query-only redirects, give the cancellation notice 2 s, and report a late answer body as a timeout.

* fix(engines): keep malformed MCP redirect targets out of errors and send cancel notices only for sent calls (R1.5)

* Discard the cached MCP client after a send-side protocol error (R1.5)

---------

Co-authored-by: Tanish Manku <[email protected]>
2026-11-19 16:06:53 -07:00
Alex Joaquim PereiraandTanish Manku 936bfff9b6 Check both comparison backends before building either (R2.9) (#1009)
* Check both comparison backends before building either (R2.9)

* Keep the API refusal test independent of provider keys (R2.9)

---------

Co-authored-by: Tanish Manku <[email protected]>
2026-11-19 16:06:46 -07:00
RRFZandTanish Manku 04ef228d1f Check when list summaries build nested lookup tables (R5.7) (#2127)
* Check which list lookups run at the summary cap (R5.7)

* Record the list lookup boundary regression (R5.7)

* Use the workspace minimum Rust API for the lookup test (R5.7)

---------

Co-authored-by: Tanish Manku <[email protected]>
2026-11-19 15:29:12 -07:00
6204350380 Let a Codex builder call the paid asset tools within the project's budget (#1464) (#2016)
* Claim R2.2 Codex asset tool approval (#1464)

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* Let a Codex builder call the paid asset tools within the project's budget (#1464)

codex exec can't ask for approval, so it refused assets_image_generate and
assets_model_generate before our server saw the call. Approve them on Codex's
side too, like rebuild_start: our own limits still apply (the project's
generated-assets switch, its budget, and the question before going over it).

Co-Authored-By: Claude Opus 5.5 <[email protected]>

---------

Co-authored-by: Claude Opus 5.5 <[email protected]>
Co-authored-by: Tanish Manku <[email protected]>
2026-11-19 15:29:03 -07:00
BFlatandTanish Manku 542fa57f67 Say to remove npm's OpenCode 1.x before installing 2.x (#1282) (#1283)
Co-authored-by: Tanish Manku <[email protected]>
2026-11-19 15:28:52 -07:00
BFlatandTanish Manku ad91fdbb17 Say that OpenRouter takes its own key when it rejects one from the model's maker (#1507)
Co-authored-by: Tanish Manku <[email protected]>
2026-11-19 15:28:44 -07:00
Ahmed FadlallaandTanish Manku 9bc38e2445 Find a Rust build only Cargo places (workspace member, CARGO_BUILD_TARGET_DIR, Cargo's home config) by reading files (#2180)
* Find a build only Cargo places by reading files, starting no process

The file lookup (the Project screen's Play and "Pin this build", a saved Live
pin) now also reads CARGO_BUILD_TARGET_DIR, build.target-dir in Cargo's home
config, and the closest workspace's target/. Every folder outside the app still
gives only a program whose build record names the app's sources.

* Say which of Cargo's rules the file lookup approximates; read a Cargo.toml only when it is a file under 1 MiB

A relative CARGO_HOME means no home config is read (not ~/.cargo).

* Bound the read of Cargo's config too; a decoy for CARGO_BUILD_TARGET_DIR; STATUS says what a Live pin asks and which rules aren't followed

* Test that Play looks in the folder Cargo names; say exactly which settings files are capped and what asks Cargo

---------

Co-authored-by: Tanish Manku <[email protected]>
2026-11-19 15:28:36 -07:00
92d2d2e781 Build development code with line tables only and dependencies without debug information (R5.2) (#1622)
* Claim: keep development builds from filling the disk with debug information (R5.2)

Co-Authored-By: Claude Fable 5.2 <[email protected]>

* Build development code with line tables only and dependencies without debug information (R5.2)

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* Say how to bring back dependencies' debug information too

Co-Authored-By: Claude Opus 5.5 <[email protected]>

---------

Co-authored-by: Claude Fable 5.2 <[email protected]>
Co-authored-by: Tanish Manku <[email protected]>
2026-11-19 15:28:28 -07:00
Rudy Mizrahi CelekliandTanish Manku 71b4e50844 Verify existing Go projects with real build and test checks (R2.7) (#1849)
* Claim the live Go project checks (R2.7)

* Exercise rebuild checks with a real Go project (R2.7)

* Record live Go project check evidence (R2.7)

---------

Co-authored-by: Tanish Manku <[email protected]>
2026-11-19 15:15:22 -07:00
BFlatandTanish Manku 7c381754a3 Take a pasted JSON array as a plugin's arguments (R2.9) (#2154)
* Claim pasted JSON plugin arguments (R2.9)

* Take a pasted JSON array as a plugin's arguments (R2.9)

---------

Co-authored-by: Tanish Manku <[email protected]>
2026-11-19 15:15:14 -07:00
BFlatandTanish Manku c71cef7df5 Drop an AI list read before the one already shown, so a save isn't undone (#1721)
Every job that changes an AI hands back a snapshot of the AI list and its options, and the app showed whichever finished last. A snapshot read before a save but finished after it put the old values back on screen until the next refresh, which is also why claude_codes_account_folder_is_set_in_settings failed about one CI run in ten. Snapshots are now numbered as they're read, and one older than the snapshot already shown is dropped.

Co-authored-by: Tanish Manku <[email protected]>
2026-11-19 15:15:06 -07:00
FuryNocturnTV (Tare Fernandez)andTanish Manku 35c9c60f7d Format in batches that fit Windows' command line: cargo xtask fmt (R5.2) (#1779)
* Claim formatting in batches that fit Windows' command line (R5.2)

* Format in batches that fit Windows' command line: cargo xtask fmt (R5.2)

* Say what cargo xtask fmt formats, and run the rustfmt RUSTFMT names

---------

Co-authored-by: Tanish Manku <[email protected]>
2026-11-19 15:14:57 -07:00
Afloat d6b0e584c5 Report unreadable folder names without merging file identities (R3.11) (#2176)
* Claim unreadable folder entry names (R3.11)

* Report unreadable entry names without merging file identities (R3.11)

* Format unreadable entry regression iterator

* Keep invalid filename fixtures off Apple targets

APFS rejects the raw filename bytes used by the two disk-backed regressions.
Keep the iterator-only limit coverage enabled on Unix and record the fixture
constraint in the contributor pitfalls.

Signed-off-by: Afloat <[email protected]>

---------

Signed-off-by: Afloat <[email protected]>
2026-11-19 15:02:41 -07:00
BFlatandTanish Manku c9e21e82a5 Start a new Claude Code conversation when the saved one has grown too long (R2.9) (#2043)
* Claim R2.9: start a new Claude Code conversation when the saved one is too long (#2042)

* Start a new Claude Code conversation when the saved one has grown too long (R2.9)

A conversation past what the model accepts made Claude Code refuse every later turn with "Prompt is too long", and Try again resumed the same conversation, so the project was stuck (#2042). That refusal is now read like a saved conversation that isn't on this computer: the saved session is dropped and the next message starts a new one from what the project already has.

---------

Co-authored-by: Tanish Manku <[email protected]>
2026-11-19 15:02:34 -07:00
BFlatandTanish Manku a6f2a491cd Drop Claude's stale thinking blocks after a summary instead of failing the build (#1586)
Co-authored-by: Tanish Manku <[email protected]>
2026-11-19 15:02:13 -07:00
BFlatandTanish Manku 5dd662d6e0 Ask the GPU for its own texture limit so very wide displays don't abort the app (#1641)
egui-wgpu requests textures of 8192 px at most whatever the GPU supports, and the window's surface can't be larger, so on a display wider than that the app aborted before its window showed (#1639). The device request now keeps egui-wgpu's settings and raises the texture limit to the GPU's own, never lower than before.

Co-authored-by: Tanish Manku <[email protected]>
2026-11-19 15:02:02 -07:00
Ahmed Fadlalla f3329b5769 Correct what Arch's Ghidra package installs, and what a Ghidra file setting accepts (#2174)
* Correct what Arch's Ghidra package installs, and what a Ghidra file setting accepts

Arch's extra repository ships ghidra (12.2), with /usr/bin/ghidra and
/usr/bin/ghidra-analyzeHeadless as links into /opt/ghidra; the earlier
text said it had no package and described a start script that was
written for the test. That real layout is found with each setting.
A Ghidra file setting is kept when it is a short text file naming the
launcher, which is not checked to run it; the wording said it was.

* Say that any file in a Ghidra folder gives its launcher, and that only Arch's own package was tried
2026-11-19 14:54:59 -07:00
BFlat df2270904c Merge pull request #2165 from Afloat16/bugfix/r3.12-sqlite-partial-schema-20261119
A readable sqlite_schema row could still hold a partial value (an overflow chain that ends
early, loops or leaves the file, or text cut at a schema budget), so a table's column list could
be short while the schema was reported complete. Such records now set schema_truncated and add
a counted integrity note; the object's readable name and metadata are kept.
2026-11-19 20:02:00 +07:00
Afloat 3f2aedfe7e Disclose partial SQLite schema records 2026-11-19 20:44:12 +08:00
Afloat e865276f84 Claim R3.12 partial SQLite schema records 2026-11-19 20:43:54 +08:00
Dylan M. Taylor 642d5a2567 Merge pull request #2167 from storytold/refactor/shared-cms-certificate-listing
formats: use shared CMS inspection for certificate listings
2026-11-19 06:33:40 -05:00
Dylan M. Taylor b858e2b12c Use shared CMS wire inspection for certificate listings 2026-11-19 05:44:15 -05:00
Dylan M. Taylor 640fd94218 Merge pull request #2166 from storytold/refactor/shared-der-inspection-metadata
formats: use shared DER inspection length metadata
2026-11-19 05:39:44 -05:00
Dylan M. Taylor c9b4b8b660 Reuse shared inspection length metadata in the DER adapter 2026-11-19 05:07:33 -05:00
BFlat 6e11ce469f Merge pull request #2163 from Afloat16/bugfix/r3.12-old-squashfs-block-layout-20261119
A squashfs 2.x or 3.x superblock was taken as a filesystem on its magic, version and bytes used
alone. The firmware scan now also requires its block size to match its block_log, from 4 KiB to
1 MiB, as version 4's already must. A superblock cut before those fields is no longer reported.
2026-11-19 14:36:50 +07:00
Afloat 054d721ff2 Validate legacy SquashFS block sizes before identifying filesystems (R3.12) 2026-11-19 15:19:54 +08:00
Afloat 0bad618774 Claim R3.12 legacy SquashFS block layout validation 2026-11-19 14:08:54 +08:00
Justin John ecf650402c Hand notes to an API-backend builder between tool calls (R2.2) (#2162)
A note added while an API-backend builder worked waited for its whole turn to end, which can be
hundreds of steps. After each tool step the loop now claims the waiting notes and adds them
after that step's results, in the wording the coding-agent hook uses. Claimed notes are marked
read, so the build shows them in the feed and doesn't send them again after the turn.
2026-11-19 12:52:25 +07:00
Dylan M. Taylor c28f8ba58d formats: reuse shared definite TLV reader (partial PKCS#7 cutover) (#2149)
* formats: cut over pkcs7 and der to craft-pkcs7

* Preserve signature inspection while reusing shared definite TLV reader
2026-11-18 23:25:04 -05:00
Justin John a9130cabed Say in the feed when a request waits for its rate limit (#2158)
An API backend with requests_per_minute set held each request back without a word, so a paced
build looked stuck. A wait of two seconds or more now puts a line in the feed saying how long
it waits and why (#668).
2026-11-19 09:26:57 +07:00
BFlat 893aa76646 Merge pull request #2156 from mansur-akhmadi/bugfix/r3.12-sqlite-schema-incomplete
The schema listing dropped its b-tree walk's incomplete flag and notes, so a schema with an
unreadable child page or row was listed as the whole schema, with complete coverage. The
overview now marks such a schema truncated and carries the walk's first notes, and
db_sqlite_show adds a schema_incomplete limitation, partial coverage, and an unknown-table
error that says only the listed part was searched.
2026-11-19 09:17:53 +07:00
Mansur Akhmadi 348897e808 Say when a SQLite schema couldn't be read whole (R3.12) 2026-11-19 08:57:21 +07:00
Fury dcd23a8fc0 Walk a folder tree in path order, so a cut inventory is a prefix of the tree (R3.11) (#2101)
The walk listed a folder's files before opening any of its subfolders, so when the file limit stopped it, a file inside an earlier folder was dropped for later ones and the inventory's sort couldn't bring it back. It now opens a subfolder where its name sorts in its parent, and results are sorted folder by folder (`path_order`), so a limit cuts the tree where a listing of it would end. Only the listings of the folders on the current path are held, within the same entry limit. When the entry limit runs out early, fewer entries are reported than before: the honest prefix.
2026-11-19 08:56:40 +07:00
Mansur Akhmadi ff7e266354 Claim the SQLite schema walk's lost incompleteness (R3.12) 2026-11-19 08:22:13 +07:00
BFlat bbfd5177f0 Merge pull request #2155 from mansur-akhmadi/bugfix/r3.12-squashfs-v3-block-size
The scan read every squashfs region's block size at offset 12, where only version 4 keeps it;
in 2.x and 3.x that is the uid table's start, and the block size is at offset 51. Older images
now report the block size they declare, and their description no longer names a compression
read from a field those versions don't have.
2026-11-19 07:06:09 +07:00
Mansur Akhmadi d4b6816074 Keep squashfs 4.0's compression and block_log out of older images' description (R3.12) 2026-11-19 06:45:03 +07:00
Mansur Akhmadi 146c6b8668 Read a squashfs 2.x or 3.x image's block size where those versions keep it (R3.12) 2026-11-19 06:36:40 +07:00
Mansur Akhmadi 7d20e64a4b Claim the squashfs 2.x/3.x block size in the firmware scan (R3.12) 2026-11-19 06:26:52 +07:00
Dylan M. Taylor cf91402bdd Update craft-tar to storytold/craft-libs main (#2151) 2026-11-18 17:45:02 -05:00
BFlat 7f0c877f8c Merge pull request #2147 from mansur-akhmadi/bugfix/r2.9-stack-steps-literal-values
The build steps filled {editor}, {player} and {ext} with chained replace calls, so an editor
installed under a folder named like a later placeholder reached the builder with a different
path. The one-pass fill moves to platform::text::fill, which both the build steps and i18n::trf
use.
2026-11-19 04:58:24 +07:00
Mansur Akhmadi 4d6e834d11 Keep the steps test to paths only one-pass filling keeps; note the fill in platform's docs 2026-11-19 04:39:02 +07:00