Compare commits

...

3 Commits

Author SHA1 Message Date
KnackAtNite d2eb40b450 v1.0.8.13: Item tooltips (TryGetRow + base item ID)
Co-authored-by: Cursor <cursoragent@cursor.com>
2026-02-10 21:55:38 -05:00
KnackAtNite cdffaeb168 v1.0.8.12: Item/HQ icons draw on hotbar (iconId >= 1000000 encoding)
Co-authored-by: Cursor <cursoragent@cursor.com>
2026-02-10 21:51:04 -05:00
KnackAtNite 346969835a v1.0.8.11: Hotbar tooltip crash fix (Lumina GetRow)
Co-authored-by: Cursor <cursoragent@cursor.com>
2026-02-10 21:37:10 -05:00
6 changed files with 35 additions and 10 deletions
+3 -3
View File
@@ -9,9 +9,9 @@
<PropertyGroup> <PropertyGroup>
<AssemblyName>HSUI</AssemblyName> <AssemblyName>HSUI</AssemblyName>
<AssemblyVersion>1.0.8.10</AssemblyVersion> <AssemblyVersion>1.0.8.13</AssemblyVersion>
<FileVersion>1.0.8.10</FileVersion> <FileVersion>1.0.8.13</FileVersion>
<InformationalVersion>1.0.8.10</InformationalVersion> <InformationalVersion>1.0.8.13</InformationalVersion>
</PropertyGroup> </PropertyGroup>
<PropertyGroup> <PropertyGroup>
+1 -1
View File
@@ -2,7 +2,7 @@
"Author": "Knack117", "Author": "Knack117",
"Name": "HSUI", "Name": "HSUI",
"InternalName": "HSUI", "InternalName": "HSUI",
"AssemblyVersion": "1.0.8.10", "AssemblyVersion": "1.0.8.13",
"Description": "HSUI provides a highly configurable HUD replacement for FFXIV, recreated from DelvUI using KamiToolKit, FFXIVClientStructs, and Dalamud. Features unit frames, castbars, job gauges, nameplates, party frames, status effects, enemy list, configurable hotbars with drag-and-drop, and profiles.", "Description": "HSUI provides a highly configurable HUD replacement for FFXIV, recreated from DelvUI using KamiToolKit, FFXIVClientStructs, and Dalamud. Features unit frames, castbars, job gauges, nameplates, party frames, status effects, enemy list, configurable hotbars with drag-and-drop, and profiles.",
"ApplicableVersion": "any", "ApplicableVersion": "any",
"RepoUrl": "https://github.com/Knack117/HSUI", "RepoUrl": "https://github.com/Knack117/HSUI",
+4 -1
View File
@@ -27,7 +27,10 @@ namespace HSUI.Helpers
try try
{ {
GameIconLookup lookup = new GameIconLookup(iconId + stackCount, false, hdIcon); // Game encodes item icons: iconId >= 1000000 means HQ; actual icon = iconId % 1000000
uint actualIconId = iconId >= 1000000 ? (iconId % 1000000) + stackCount : iconId + stackCount;
bool itemHq = iconId >= 1000000;
GameIconLookup lookup = new GameIconLookup(actualIconId, itemHq, hdIcon);
return Plugin.TextureProvider.GetFromGameIcon(lookup).GetWrapOrDefault(); return Plugin.TextureProvider.GetFromGameIcon(lookup).GetWrapOrDefault();
} }
catch catch
+17 -4
View File
@@ -1152,6 +1152,19 @@ namespace HSUI.Interface.GeneralElements
} }
private static unsafe (string title, string text) GetSlotTooltip(ActionBarsManager.SlotInfo slot) private static unsafe (string title, string text) GetSlotTooltip(ActionBarsManager.SlotInfo slot)
{
try
{
return GetSlotTooltipCore(slot);
}
catch
{
// Lumina GetRow can throw for invalid/transitional row IDs (e.g. during inventory drag-drop)
return ("", "");
}
}
private static unsafe (string title, string text) GetSlotTooltipCore(ActionBarsManager.SlotInfo slot)
{ {
// GeneralAction uses a different ID space: GeneralAction 7 = Teleport links to Action 5. Look up via GeneralAction sheet. // GeneralAction uses a different ID space: GeneralAction 7 = Teleport links to Action 5. Look up via GeneralAction sheet.
if (slot.SlotType == RaptureHotbarModule.HotbarSlotType.GeneralAction) if (slot.SlotType == RaptureHotbarModule.HotbarSlotType.GeneralAction)
@@ -1428,13 +1441,13 @@ namespace HSUI.Interface.GeneralElements
if (slot.SlotType == RaptureHotbarModule.HotbarSlotType.Item) if (slot.SlotType == RaptureHotbarModule.HotbarSlotType.Item)
{ {
var row = Plugin.DataManager.GetExcelSheet<Item>()?.GetRow(slot.ActionId); uint baseItemId = slot.ActionId >= 1000000 ? slot.ActionId - 1000000 : slot.ActionId;
if (row.HasValue) if (Plugin.DataManager.GetExcelSheet<Item>()?.TryGetRow(baseItemId, out var itemRow) == true)
{ {
string name = row.Value.Name.ToString(); string name = itemRow.Name.ToString();
try try
{ {
string desc = row.Value.Description.ToDalamudString().ToString(); string desc = itemRow.Description.ToDalamudString().ToString();
if (!string.IsNullOrEmpty(desc)) if (!string.IsNullOrEmpty(desc))
desc = EncryptedStringsHelper.GetString(desc); desc = EncryptedStringsHelper.GetString(desc);
return (name, desc); return (name, desc);
+9
View File
@@ -1,3 +1,12 @@
# 1.0.8.13
- **Hotbars**: Fixed item tooltips not showing — use TryGetRow for Item sheet and base item ID so tooltip no longer fails for some items.
# 1.0.8.12
- **Hotbars**: Fixed item icons not drawing on hotbar — game encodes HQ items as iconId + 1000000; now use iconId % 1000000 and itemHq flag so item icons (including HQ) display correctly.
# 1.0.8.11
- **Hotbars**: Fixed tooltip crash — Lumina GetRow can throw for invalid/transitional row IDs (e.g. during inventory drag-drop); GetSlotTooltip now catches and returns empty instead of crashing.
# 1.0.8.10 # 1.0.8.10
- **Hotbars**: Fixed crash when dragging items from inventory to hotbar — GetFromGameIcon can throw for invalid/unsupported icon IDs; now handled gracefully. - **Hotbars**: Fixed crash when dragging items from inventory to hotbar — GetFromGameIcon can throw for invalid/unsupported icon IDs; now handled gracefully.
- **Build**: Release builds no longer emit PDBs to avoid local path leakage in user crash logs. - **Build**: Release builds no longer emit PDBs to avoid local path leakage in user crash logs.
+1 -1
View File
@@ -1 +1 @@
[{"Author":"Knack117","Name":"HSUI","Punchline":"A modern HUD replacement built for customization.","Description":"HSUI provides a highly configurable HUD replacement for FFXIV, recreated from DelvUI using KamiToolKit, FFXIVClientStructs, and Dalamud. Features unit frames, castbars, job gauges, nameplates, party frames, status effects, enemy list, configurable hotbars with drag-and-drop, and profiles.","Changelog":"1.0.8.10: Hotbar crash fix when dragging inventory items; Release builds strip PDBs. 1.0.8.9: Gearset persists on slot (fix CommandId 0 treated as empty). 1.0.8.8: Gearset drag-drop fix; allow first gearset (index 0) on bar. 1.0.8.7: Fixed Gearset/Job Gear Set icon clearing when first equipment slot changes. 1.0.8.6: Crafting action tooltips now show full description instead of action name. 1.0.8.4: Alliance Frames 1 and 2 fix in raids; crafting action tooltips; Hide in duty no longer hides alliance frames. 1.0.8.3: Fix left-click staying broken after disable. 1.0.8.2: Charge icons stay lit until all charges spent.","InternalName":"HSUI","AssemblyVersion":"1.0.8.10","RepoUrl":"http://brassnet.ddns.net:33983/KnackAtNite/HSUI","ApplicableVersion":"any","Tags":["UI","HUD","Unit Frames","Nameplates","Party Frames","Hotbars"],"CategoryTags":["UI"],"DalamudApiLevel":14,"IconUrl":"http://brassnet.ddns.net:33983/KnackAtNite/HSUI/raw/branch/main/Media/Images/icon.png","ImageUrls":[],"DownloadLinkInstall":"http://brassnet.ddns.net:33983/KnackAtNite/HSUI/releases/download/v1.0.8.10/latest.zip","IsHide":false,"IsTestingExclusive":false,"DownloadLinkTesting":"http://brassnet.ddns.net:33983/KnackAtNite/HSUI/releases/download/v1.0.8.10/latest.zip","DownloadLinkUpdate":"http://brassnet.ddns.net:33983/KnackAtNite/HSUI/releases/download/v1.0.8.10/latest.zip","LastUpdate":"1760227200"}] [{"Author":"Knack117","Name":"HSUI","Punchline":"A modern HUD replacement built for customization.","Description":"HSUI provides a highly configurable HUD replacement for FFXIV, recreated from DelvUI using KamiToolKit, FFXIVClientStructs, and Dalamud. Features unit frames, castbars, job gauges, nameplates, party frames, status effects, enemy list, configurable hotbars with drag-and-drop, and profiles.","Changelog":"1.0.8.13: Item tooltips now show. 1.0.8.12: Item/HQ icons now draw on hotbar. 1.0.8.11: Hotbar tooltip crash fix (Lumina GetRow). 1.0.8.10: Hotbar crash fix when dragging inventory items; Release builds strip PDBs. 1.0.8.9: Gearset persists on slot (fix CommandId 0 treated as empty). 1.0.8.8: Gearset drag-drop fix; allow first gearset (index 0) on bar. 1.0.8.7: Fixed Gearset/Job Gear Set icon clearing when first equipment slot changes. 1.0.8.6: Crafting action tooltips now show full description instead of action name. 1.0.8.4: Alliance Frames 1 and 2 fix in raids; crafting action tooltips; Hide in duty no longer hides alliance frames. 1.0.8.3: Fix left-click staying broken after disable. 1.0.8.2: Charge icons stay lit until all charges spent.","InternalName":"HSUI","AssemblyVersion":"1.0.8.13","RepoUrl":"http://brassnet.ddns.net:33983/KnackAtNite/HSUI","ApplicableVersion":"any","Tags":["UI","HUD","Unit Frames","Nameplates","Party Frames","Hotbars"],"CategoryTags":["UI"],"DalamudApiLevel":14,"IconUrl":"http://brassnet.ddns.net:33983/KnackAtNite/HSUI/raw/branch/main/Media/Images/icon.png","ImageUrls":[],"DownloadLinkInstall":"http://brassnet.ddns.net:33983/KnackAtNite/HSUI/releases/download/v1.0.8.13/latest.zip","IsHide":false,"IsTestingExclusive":false,"DownloadLinkTesting":"http://brassnet.ddns.net:33983/KnackAtNite/HSUI/releases/download/v1.0.8.13/latest.zip","DownloadLinkUpdate":"http://brassnet.ddns.net:33983/KnackAtNite/HSUI/releases/download/v1.0.8.13/latest.zip","LastUpdate":"1760486400"}]