diff --git a/HSUI.csproj b/HSUI.csproj index 34ef2b1..c252f38 100644 --- a/HSUI.csproj +++ b/HSUI.csproj @@ -9,9 +9,9 @@ HSUI - 1.0.6.0 - 1.0.6.0 - 1.0.6.0 + 1.0.7.0 + 1.0.7.0 + 1.0.7.0 diff --git a/HSUI.json b/HSUI.json index 08deabf..ee20467 100644 --- a/HSUI.json +++ b/HSUI.json @@ -2,7 +2,7 @@ "Author": "Knack117", "Name": "HSUI", "InternalName": "HSUI", - "AssemblyVersion": "1.0.6.0", + "AssemblyVersion": "1.0.7.0", "Description": "HSUI provides a highly configurable HUD replacement for FFXIV, recreated from DelvUI using KamiToolKit, FFXIVClientStructs, and Dalamud. Features unit frames, castbars, job gauges, nameplates, party frames, status effects, enemy list, configurable hotbars with drag-and-drop, and profiles.", "ApplicableVersion": "any", "RepoUrl": "https://github.com/Knack117/HSUI", diff --git a/Helpers/ActionBarsManager.cs b/Helpers/ActionBarsManager.cs index a817f97..c36bf47 100644 --- a/Helpers/ActionBarsManager.cs +++ b/Helpers/ActionBarsManager.cs @@ -50,8 +50,12 @@ namespace HSUI.Helpers public RaptureHotbarModule.HotbarSlotType SlotType { get; } /// Keybind hint from game (user's keybind settings). Empty if unavailable. public string KeybindHint { get; } + /// Current charges for charge-based actions; 0 when not applicable. + public int CurrentCharges { get; } + /// Max charges for charge-based actions; >1 only for actions with charges. + public int MaxCharges { get; } - public SlotInfo(uint iconId, bool isEmpty, bool usable, int cooldownPct, int cooldownSecs, uint actionId = 0, RaptureHotbarModule.HotbarSlotType slotType = 0, string keybindHint = "") + public SlotInfo(uint iconId, bool isEmpty, bool usable, int cooldownPct, int cooldownSecs, uint actionId = 0, RaptureHotbarModule.HotbarSlotType slotType = 0, string keybindHint = "", int currentCharges = 0, int maxCharges = 0) { IconId = iconId; IsEmpty = isEmpty; @@ -61,6 +65,8 @@ namespace HSUI.Helpers ActionId = actionId; SlotType = slotType; KeybindHint = keybindHint ?? ""; + CurrentCharges = currentCharges; + MaxCharges = maxCharges; } } @@ -106,13 +112,13 @@ namespace HSUI.Helpers if (slot == null) { - list.Add(new SlotInfo(0, true, false, 0, 0, 0, 0, keybind)); + list.Add(new SlotInfo(0, true, false, 0, 0, 0, 0, keybind, 0, 0)); continue; } if (slot->IsEmpty) { - list.Add(new SlotInfo(0, true, false, 0, 0, 0, 0, keybind)); + list.Add(new SlotInfo(0, true, false, 0, 0, 0, 0, keybind, 0, 0)); continue; } @@ -122,7 +128,8 @@ namespace HSUI.Helpers var slotType = slot->ApparentSlotType; (int pct, int secsLeft) = GetSlotCooldown(slot); - list.Add(new SlotInfo(iconId, false, usable, pct, secsLeft, actionId, slotType, keybind)); + (int currentCharges, int maxCharges) = GetSlotCharges(slotType, actionId); + list.Add(new SlotInfo(iconId, false, usable, pct, secsLeft, actionId, slotType, keybind, currentCharges, maxCharges)); } return list; @@ -132,6 +139,27 @@ namespace HSUI.Helpers /// Gets cooldown for a hotbar slot. For Action/GeneralAction/PetAction, uses ActionManager recast API /// (more accurate for adjusted IDs, recast groups). Falls back to slot's GetSlotActionCooldownPercentage for Items/Macros. /// + /// + /// Gets current and max charges for a slot. Only applies to Action type; returns (0,0) otherwise. + /// + private static unsafe (int CurrentCharges, int MaxCharges) GetSlotCharges(RaptureHotbarModule.HotbarSlotType slotType, uint actionId) + { + if (slotType != RaptureHotbarModule.HotbarSlotType.Action || actionId == 0) + return (0, 0); + + var actionManager = ActionManager.Instance(); + if (actionManager == null) + return (0, 0); + + uint effectiveId = actionManager->GetAdjustedActionId(actionId); + ushort maxCh = ActionManager.GetMaxCharges(effectiveId, 0); + if (maxCh <= 1) + return (0, 0); + + uint currentCh = actionManager->GetCurrentCharges(effectiveId); + return ((int)currentCh, (int)maxCh); + } + private static unsafe (int CooldownPercent, int SecondsLeft) GetSlotCooldown(RaptureHotbarModule.HotbarSlot* slot) { if (slot == null) return (0, 0); diff --git a/Helpers/InputsHelper.cs b/Helpers/InputsHelper.cs index bb679a3..91274c6 100644 --- a/Helpers/InputsHelper.cs +++ b/Helpers/InputsHelper.cs @@ -142,8 +142,22 @@ namespace HSUI.Helpers return; } - ConfigurationManager.Instance.ResetEvent -= OnConfigReset; - Plugin.Framework.Update -= OnFrameworkUpdate; + // Restore WndProc first so left-click works again immediately after unload. + // After a game/Dalamud patch, other singletons may be disposed before us; + // if we unsub or touch config first and that throws, we would never restore and LButton stays broken. + RestoreWndProc(); + + try + { + ConfigurationManager.Instance.ResetEvent -= OnConfigReset; + } + catch { /* Instance may already be disposed */ } + + try + { + Plugin.Framework.Update -= OnFrameworkUpdate; + } + catch { /* Framework may already be disposed */ } Plugin.Logger.Info("\t\tDisposing _requestActionHook: " + (_requestActionHook?.Address.ToString("X") ?? "null")); _requestActionHook?.Disable(); @@ -151,9 +165,6 @@ namespace HSUI.Helpers _executeSlotByIdHook?.Disable(); _executeSlotByIdHook?.Dispose(); - // give imgui the control of inputs again - RestoreWndProc(); - Instance = null!; } #endregion @@ -556,15 +567,21 @@ namespace HSUI.Helpers private void RestoreWndProc() { - if (_wndHandle != IntPtr.Zero && _imguiWndProcPtr != IntPtr.Zero) + if (_wndHandle == IntPtr.Zero || _imguiWndProcPtr == IntPtr.Zero) + return; + + try { Plugin.Logger.Info("\t\tRestoring WndProc"); - Plugin.Logger.Info("\t\t\tOld _wndHandle = " + _wndHandle.ToString("X")); - Plugin.Logger.Info("\t\t\tOld _imguiWndProcPtr = " + _imguiWndProcPtr.ToString("X")); - SetWindowLongPtr(_wndHandle, GWL_WNDPROC, _imguiWndProcPtr); - Plugin.Logger.Info("\t\t\tDone!"); - + Plugin.Logger.Info("\t\t\tWndProc restored."); + } + catch (Exception ex) + { + Plugin.Logger.Warning($"\t\tRestoreWndProc failed: {ex.Message}"); + } + finally + { _wndHandle = IntPtr.Zero; _imguiWndProcPtr = IntPtr.Zero; } diff --git a/Interface/GeneralElements/ActionBarsHud.cs b/Interface/GeneralElements/ActionBarsHud.cs index 5398709..784effc 100644 --- a/Interface/GeneralElements/ActionBarsHud.cs +++ b/Interface/GeneralElements/ActionBarsHud.cs @@ -216,6 +216,14 @@ namespace HSUI.Interface.GeneralElements Vector2 labelPos = new Vector2(pos.X + size.X - labelSize.X - 2, pos.Y + size.Y - labelSize.Y - 2); DrawHelper.DrawOutlinedText(label, labelPos, 0xFFFFFFFF, 0xFF000000, drawList, 1); } + + if (Config.ShowChargeCount && !slot.IsEmpty && slot.MaxCharges > 1) + { + string chargeText = slot.CurrentCharges.ToString(); + Vector2 chargeSize = ImGui.CalcTextSize(chargeText); + Vector2 chargePos = new Vector2(pos.X + 2, pos.Y + 2); + DrawHelper.DrawOutlinedText(chargeText, chargePos, 0xFFFFFFFF, 0xFF000000, drawList, 1); + } } } } diff --git a/Interface/GeneralElements/HotbarsConfig.cs b/Interface/GeneralElements/HotbarsConfig.cs index 56bc21e..a52fe8c 100644 --- a/Interface/GeneralElements/HotbarsConfig.cs +++ b/Interface/GeneralElements/HotbarsConfig.cs @@ -63,15 +63,19 @@ namespace HSUI.Interface.GeneralElements [Order(28)] public bool ShowSlotNumbers = true; - [Checkbox("Show Combo Highlight")] + [Checkbox("Show Charge Count")] [Order(29)] + public bool ShowChargeCount = true; + + [Checkbox("Show Combo Highlight")] + [Order(30)] public bool ShowComboHighlight = true; [Checkbox("Show Keypress Flash")] - [Order(30)] + [Order(31)] public bool ShowKeypressFlash = true; - [NestedConfig("Combo Highlight", 31)] + [NestedConfig("Combo Highlight", 32)] public ComboHighlightConfig ComboHighlightConfig = new(); [Checkbox("Debug Drag & Drop")] diff --git a/changelog.md b/changelog.md index 7df4213..9f2af4e 100644 --- a/changelog.md +++ b/changelog.md @@ -1,3 +1,7 @@ +# 1.0.7.0 +- **Hotbars**: Charge count on slots — abilities with charges (e.g. 2-stack) show the current charge number in the top-left of the slot; keybind stays in the bottom-right. Toggle in Hotbars → Show Charge Count. +- **Fix**: Left-click no longer stays broken after disabling HSUI. WndProc is restored first on plugin unload so the game window gets normal input back even when disposal order changes (e.g. after a patch). + # 1.0.6.0 - **Tooltips**: Icons in tooltips — action bars, status effects, and party cooldowns now show the item's icon next to the tooltip text when available. - **World Object Tooltip**: Quest/NPC icons — hovering over NPCs or objects displays their quest or state icon (e.g., exclamation marks, turn-in checks) in the tooltip. Toggle in Misc → World Tooltip → Show Icon. diff --git a/pluginmaster.json b/pluginmaster.json index f50aad7..55c0326 100644 --- a/pluginmaster.json +++ b/pluginmaster.json @@ -4,9 +4,9 @@ "Name": "HSUI", "Punchline": "A modern HUD replacement built for customization.", "Description": "HSUI provides a highly configurable HUD replacement for FFXIV, recreated from DelvUI using KamiToolKit, FFXIVClientStructs, and Dalamud. Features unit frames, castbars, job gauges, nameplates, party frames, status effects, enemy list, configurable hotbars with drag-and-drop, and profiles.", - "Changelog": "Tooltips: Icons in tooltips for action bars, status effects, party cooldowns. World Object Tooltip: quest/NPC icons shown when hovering over NPCs/objects (toggle in Misc → World Tooltip).", + "Changelog": "Hotbars: Charge count on slots (top-left). Fix: Left-click works again after disabling plugin (WndProc restore on unload).", "InternalName": "HSUI", - "AssemblyVersion": "1.0.6.0", + "AssemblyVersion": "1.0.7.0", "RepoUrl": "https://github.com/Knack117/HSUI", "ApplicableVersion": "any", "Tags": ["UI", "HUD", "Unit Frames", "Nameplates", "Party Frames", "Hotbars"], @@ -14,11 +14,11 @@ "DalamudApiLevel": 14, "IconUrl": "https://raw.githubusercontent.com/Knack117/HSUI/main/Media/Images/icon.png", "ImageUrls": [], - "DownloadLinkInstall": "https://github.com/Knack117/HSUI/releases/download/v1.0.6.0/latest.zip", + "DownloadLinkInstall": "https://github.com/Knack117/HSUI/releases/download/v1.0.7.0/latest.zip", "IsHide": false, "IsTestingExclusive": false, - "DownloadLinkTesting": "https://github.com/Knack117/HSUI/releases/download/v1.0.6.0/latest.zip", - "DownloadLinkUpdate": "https://github.com/Knack117/HSUI/releases/download/v1.0.6.0/latest.zip", - "LastUpdate": "1738454400" + "DownloadLinkTesting": "https://github.com/Knack117/HSUI/releases/download/v1.0.7.0/latest.zip", + "DownloadLinkUpdate": "https://github.com/Knack117/HSUI/releases/download/v1.0.7.0/latest.zip", + "LastUpdate": "1738540800" } ]