da17074a63de831d3dae8201da58bebcec467658
3 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 Docker Build
|
b8826370c6 |
Paragon: cross-class stance exclusivity + cancel, hunter ammo soft-fail, Feral Cat scaling, Pestilence DP spread
Server-side batch following v0.7.18, all gated to Paragon (or applied server-wide where the design discussion called for it): * Cross-class stance / form / presence / aspect exclusivity (server-wide). New `IsFracturedExclusiveStanceSpell()` (`Unit.cpp`/`Unit.h`) returns true for the union of warrior stances + druid forms (combat AND utility: Travel, Aquatic, Flight, Swift Flight) + Ghost Wolf + base Stealth + Shadowform + Metamorphosis + DK Presences + Hunter Aspects (combat AND utility: Cheetah, Pack). `Aura::CanStackWith` (`SpellAuras.cpp`) refuses to stack two spells from this set, which routes through `_RemoveNoStackAurasDueToAura` to drop the older aura -- the same mechanism Battle Elixirs / Curses use. Plugs the stock-AC gap where DK Presences and Hunter Aspects (regular auras, just rendered in the stance bar) coexisted with engine-shapeshifts. * Stances / Presences / Aspects cancellable like Druid forms. `SpellInfoCorrections.cpp` now zeroes `CategoryEntry` on warrior stances, DK presences, and every rank of every hunter aspect (moves them out of SpellCategory 47 "Combat States", which gates the client's right-click / `/cancelaura` path), AND clears `AttributesEx6` bit `0x1000` on warrior stances + DK presences (a second client-UI gate surfaced via DBC diff -- aspects don't have it set). Mirrored client- side by `_patch_spell_dbc_presences_cancelable.py`. Aspects / presences do NOT swap action bars (those are owned by `SPELL_AURA_MOD_SHAPESHIFT`, not by Category / AttrEx6) -- only warrior stances and druid forms keep the bar swap, matching the design requirement that presences/aspects not change the player's action bar. * Hunter ammo soft-fail (server-wide). Replaced both `SPELL_FAILED_NO_AMMO` returns in `Spell::CheckCast` with `break;` so ranged + thrown abilities cast through with zero ammo; `_ApplyAmmoBonuses` continues to gate the actual arrow/bullet DPS bonus on a non-empty stack, so equipping ammo still pays off. New programmatic `ApplySpellFix`-style block in `SpellInfoCorrections.cpp` iterates every Hunter-family spell whose `EquippedItemClass == ITEM_CLASS_WEAPON` and `EquippedItemSubClassMask` includes Bow/Gun/Crossbow and sets `EquippedItemClass = -1` (skipping a small DENYLIST of Quiver / Ammo Pouch passive haste auras + Aynasha's Bow + Legendary Bow Haste -- those are item-equip-driven and must keep gating on the ranged weapon being equipped). Server log: ">> Fractured: dropped EquippedItemClass on 196 hunter shot abilities". Mirrored client-side by the new `_patch_spell_dbc_hunter_ammo.py` so the 3.3.5a client preflight stops blocking the cast packet with "Ammo needs to be in the paper doll ammo slot before it can be fired." `Spell::TakeAmmo` no longer clears `PLAYER_AMMO_ID` to 0 when the bag empties (defense in depth so a half- deployed pair degrades to soft-fail rather than hard-reject). Adds `#include "ItemTemplate.h"` for `ITEM_SUBCLASS_WEAPON_*`. * Feral Cat scaling (server-wide, cat-only). `StatSystem.cpp` `UpdateAttackPowerAndDamage` FORM_CAT branch doubles the AGI coefficient (1.0 -> 2.0). `SpellAuraEffects.cpp` Master Shapeshifter FORM_CAT branch doubles the talent's bp before triggering 48420 (R1: 2% -> 4% crit, R2: 4% -> 8%). FORM_BEAR / FORM_DIREBEAR / FORM_MOONKIN / FORM_TREE branches all left untouched so bear stays "already fine" per the resident Feral expert. Client tooltip drift on Cat Form (768) + Master Shapeshifter (48411 / 48412) + Pestilence (50842) handled by `_patch_spell_dbc_feral_tooltips.py`. * Pestilence spreads / refreshes Devouring Plague for Paragon casters. `spell_dk.cpp` `spell_dk_pestilence::HandleScriptEffect` now also spreads (and Glyph-of-Disease refreshes) Priest Devouring Plague when `IsParagonWildcardCaller(caster)`. Uses `GetAuraOfRankedSpell(2944)` so the spread copy carries the caster's actual rank. Stock DKs cannot cast Devouring Plague at all, so this branch is a no-op for them. * Dancing Rune Weapon: Paragon copies melee, not casts. `spell_dk.cpp` `spell_dk_dancing_rune_weapon::CheckProc` for Paragon callers requires `eventInfo.GetDamageInfo()` and `spellInfo->DmgClass == SPELL_DAMAGE_CLASS_MELEE`, so the ghostly weapon now copies cross-class melee strikes (Hamstring, Sinister Strike, Heart Strike, Frost Strike, ...) and auto-attacks instead of re-casting the DK's nukes. Stock DK gating below is untouched. * Maelstrom Weapon: drop Arcane Blast from the allowlist. `SpellInfo.cpp` and `spell_shaman.cpp` allowlists now match Fireball and Frostbolt only -- Arcane Blast stacked with its own self-buff was too potent. * `BALANCE-TODO.md` added under `contrib/fractured-dev-extras/` to capture the resident Feral expert's recommendation, the levers we considered, and the cat-only Master-Shapeshifter / AGI-doubling resolution we shipped, plus the next-lever knobs if field reports still flag cat as weak. DBC patcher pipeline (lives outside the repo in `fractured-tooling/`) documented run order: runes -> reagents -> stances -> presences_cancelable -> hunter_ammo -> feral_tooltips -> _make_paragon_dbc_patch. No SQL migrations. Co-authored-by: Cursor <cursoragent@cursor.com> |
||
|
Docker Build
|
e649402163 |
Paragon: cross-class talents + Warrior stance bypass + Mirror Image spellbook draw
Server-side cross-class wildcard pass for several talents that were
previously locked to a single SpellFamilyName, plus a server+client
Warrior stance bypass and a Paragon-aware Mirror Image rebuild that
mimics the owner's spellbook instead of stock Frostbolt/Fire Blast.
Talent expansions (Paragon owners only; stock classes unchanged):
- Cold Snap (11958): resets cooldown of any Frost-school spell.
- Nature's Swiftness (17116, 16188) + Predator's Swiftness (69369):
instant-cast on any Nature-school spell.
- Vampiric Embrace (15286): leech-heals from any single-target
Shadow-school spell.
- Fingers of Frost (44543/44545) + Frostbite (11071/12496/12497):
proc from any Frost-school chill effect (DK Howling Blast / Icy
Touch / Chains of Ice, Hunter Frost Trap, Shaman Frost Shock,
cross-class chill auras via SPELL_AURA_MOD_DECREASE_SPEED).
- Maelstrom Weapon (53817): now also affects Mage Fireball (133),
Frostbolt (116), and Arcane Blast (30451) at every rank, both
for cast-time/cost spellmod and for stack consumption.
Warrior stance bypass:
- SpellInfo::CheckShapeshift returns SPELL_CAST_OK whenever a
Paragon caster hits any Stances!=0 spell (no SpellFamilyName
gate). Stock classes still see the regular form rules.
- Client side: patch-enUS-4.MPQ now zeroes Stances on every
SPELLFAMILY_WARRIOR Spell.dbc row (105 spells) so the engine's
pre-cast "Must be in Battle/Defensive/Berserker Stance" check
no longer eats CMSG_CAST_SPELL packets for Paragons. Server
bypass enforces the actual decision; stock Warriors still
error mid-cast if they actually click while out of stance.
- patch-enUS-5.MPQ Lua tooltip post-processor recolors and
appends "(Paragon: bypassed)" to "Requires *Stance*" lines on
Warrior abilities, plus Paragon notes on Maelstrom Weapon and
Mirror Image tooltips. Action-bar UseAction wrapper routes
stance-gated Warrior spell clicks through CastSpellByName so
the stance-zero DBC + server bypass actually run.
Mirror Image:
- npc_pet_mage_mirror_image rebuilds its spell list from the
Paragon owner's spellbook on InitializeAI AND JustEngagedWith
(the second pass + events.Reset clears any stale events the
CasterAI base scheduler may have queued from stock 59637 /
59638 entries before the rebuild ran).
- Curated filter keeps single-target damaging spells (instant,
cast-time, or channeled) with a base cooldown <=10s, with the
"damaging" definition expanded to include
SPELL_EFFECT_TRIGGER_MISSILE and
SPELL_AURA_PERIODIC_TRIGGER_SPELL so Arcane Missiles
qualifies. Rejects passives, AoE, melee/ranged weapon strikes,
item/reagent/stance/equip-gated, and lower spell ranks.
- UpdateAI picks a random spell from the curated list per cast
and reschedules the next pick by the actually-cast spell's
cast/channel duration + 750ms breather, so a 5s Arcane
Missiles channel waits its full duration before re-rolling
rather than visually looping across four images.
Helpers:
- Unit::IsParagonWildcardCaller / Unit::ParagonFamilyMatches
used by Spell.cpp, SpellInfo.cpp, Player.cpp,
SpellAuraEffects.cpp, and the spell scripts.
- SpellInfo::CheckShapeshift signature gains an optional caster
pointer; all call sites updated.
SQL migrations under modules/mod-paragon/data/sql/db-world/updates/:
- 2026_05_11_01.sql Vampiric Embrace spell_proc relax + script
gate (CheckProc enforces stock for non-Paragon).
- 2026_05_11_02.sql Maelstrom Weapon spell_proc relax (initial,
superseded by _04 below for stack-consumption fix).
- 2026_05_11_03.sql Fingers of Frost / Frostbite spell_proc relax
and spell_script_names binding.
- 2026_05_11_04.sql Maelstrom Weapon spell_proc fixup: restore
SpellPhaseMask=1 (CAST) and AttributesMask=8
(REQ_SPELLMOD); previous _02 set 8/0 which
silently dropped every proc event.
Diagnostics from this debugging session demoted from LOG_INFO to
LOG_DEBUG (silent at default info level) so production logs stay
quiet but the probes remain available for reproducing future
regressions: pet_mage.cpp MirrorImage probe/kept/rebuild/init/
engage/cast lines and SpellInfo.cpp CheckShapeshift bypass line.
CLIENT-PATCHES.md updated to document the new Warrior stance DBC
patcher (_patch_spell_dbc_stances.py), the spell-tooltip post-
processor and stance UseAction wrapper in patch-enUS-5.MPQ, and
the Mirror Image / Maelstrom Weapon Paragon notes.
Co-authored-by: Cursor <cursoragent@cursor.com>
|
||
|
Docker Build
|
72dd540b67 |
Local snapshot for Docker build (includes mod-ale)
Co-authored-by: Cursor <cursoragent@cursor.com> |