Commit Graph
25 Commits
Author SHA1 Message Date
SatyandClaude Opus 5.5 eabc5d8997 Port the logic fixes from the msvc80 branch
Behaviour fixes found while byte-matching against 12340, without the
VS2005 code-shape rewrites:
- 272502f5 logic bugs (MapObjDef 0x80 flag, D3D texop, PostReenable, ...)
- 3002c17f case-sensitive KNOWNDANCES/DECLINEDWORD keys, DynamicObject
  GetTransportGUID, CShadowCache::Initialize
- OpenGl IStateSyncEnables fill/line, DsSet integer value tests
- FriendList tail padding, HandleSpellEventSound severity, selection
  index -1, negative spell id in HasPetSpell
- operator delete null checks, FMOD MemoryFile seek clamp, SErr
  HeapAlloc flags
- WOWCLIENT_CRASH_LOG option

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-15 15:18:17 +02:00
SatyandClaude Opus 5.5 dfae6719b7 Naming pass: 65 functions, 103 statics, 63 fields named from Mac symbols and behaviour
Evidence and confidence per rename in re/notes/310_naming_pass.md.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-04 09:27:29 +02:00
SatyandClaude Opus 5.5 27de58d41e Dissolve _Triage into the source tree
- move triage code to the folders of its binary neighbours (AreaList,
  movement packet types, CClientObjCreate, CWOWClientStatus, SHA1,
  Clamp, EmergencyMem, MippedImg, WowMouse, ...)
- merge HMAC template, OnGxRestartClearWorld and TIMESTAMPSTRUCT into
  their natural headers
- delete superseded duplicates and unk-only placeholders
- tools: drop Triage library, fix Streaming stub signatures, remove
  stubs now provided by BlizzardCore, MapViewer s_liquidTypeId

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 18:09:53 +02:00
SatyandClaude Opus 5.5 bfe8e635d9 Document kept WoWFix335 patches, restore original tradeskill tool flags
- one-line notes on the four community fixes present in the IDB input
  (gamma, melee swing, turn attack anim, pre-cast anim)
- GetTradeSkillTools: FindTotemCategory flags 0 as in the signed exe;
  the IDB's push -0x15 is the misplaced naked-character-issue patch

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 17:48:42 +02:00
SatyandClaude Opus 5.5 b76f1b443a Port packs w3-w5: objects/vehicles, LCD stack, ComSat voice chat, map dtors, misc missing functions
- Object/vehicle/spell-visual/world/MapObj functions from pack w3
- Logitech LCD stack (CLCDBase..CLCDConnection, CLCDText/Bitmap/Page, CEzLcd, CEzLcdPage, CLCDUtils) and CGLCD
- ComSat client: voice start/stop, mute, sound group fade, tick, event dispatch; s_comsatCallbacks is a growable array
- ShipPath pause/offset, Transport state progress, vehicle bone anim/passenger removal, NetClient redirect
- Map class destructors (CMapArea/Chunk/DoodadDef/Entity/ObjDefGroup), CMapChunk +0xB4 is a TSLink
- Character rename/customize, ClientServices login/survey wrappers, glue Lua scripts, DayNight light overrides
- Template instance and deleting-dtor OFFSETs

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 03:16:42 +02:00
SatyandClaude Opus 5.5 46b5adf64f Port FriendList, Player_C, Unit_C and GameObject_C modules
- FriendList: remaining methods and 28 Lua scripts, FriendListModuleLoaded
- Player_C: remaining functions incl. click-to-move (ClickToMove, CTMFace,
  CTMClickTerrain, CTMAttackUnit, CTMInteractGO), dance, virtual items,
  sound and skill-rank overrides
- Unit_C: tracking (HandleTracking and helpers, SetTrackingTarget/Direction),
  selection circles, spell visual overrides, mirror image, flag-2 changes,
  scale update, missile trajectory (ComputeMissileTrajectory,
  SendFinalMissileTrajectoryUpdate, StartMissileTrajectoryTargeting) and
  CMissileCollision (Init, unit ranking, hit spheres)
- GameObject_C: IsLocked, UseObject, TypeBase CanUseNow/CheckRange/Use/
  CanChangeCursor, Ritual and MeetingStone types, virtual overrides,
  property helpers named from the binary's property table
- Dependencies: ProjectTex::Render2d, weapon trail chain (SWING,
  WTOBJECT::SetDrawTrail), GxSwizzleColor, CAaBox::Expand/Center,
  CVehicle_C::PlayBoneAnimOrFallback, RuneInfo/PetitionInfo/ClassTrainer/
  ComSat helpers, CalendarEventTables ctor
- DBCache: InvalidateIntKey, RetryItem, SetTemporary, ~DBCACHEHASH
- Template instances, deleting dtors and TSHashTable/WowClientDB instances
  recorded in their OFFSET lists

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 12:07:58 +02:00
SatyandClaude Opus 5.5 12f5b14fb5 Port ChatFrame module
72 ChatFrame functions: remaining chat scripts (channels, voice, chat
logging, complaints, saved instances, chat window/colour reset, emotes,
join from script), complaint record lookup, voice roster/session updates,
user list add/remove and title earned handlers, honor/feed pet/tradeskill/
open lock combat log messages, pending user list display.

Callees ported: ComSatClient_LeaveAllSessions and its member notify,
PlayDance, CGDanceStudio::HasDance (dance table keyed by name),
GetMaxPlayersForMap, CGPlayer_C::SendTextEmote, CGUnit_C::Unk724410.

0x4CFB80 (m_paused++) renamed CGChat::Pause; CGChat::LeaveWorld is now
0x4FB190. Pause/Resume/IsPaused and m_paused moved from
SoundInterface2Foley.cpp to ChatFrame.cpp.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 08:35:26 +02:00
SatyandClaude Opus 5.5 88b375105b Port run-87 hit stand-ins and fix world map zone lookup
- WorldMap: GetMapAreaFromPos indexed the zone grid with x/y swapped
- FriendList: SMSG_FRIEND_STATUS handling chain with name callbacks
- ChatFrame: channel roster display, name query callback
- Calendar: day event lists, holidays, filters, event occurrence
- Grunt LogonStoredSession, CGUnit_C::UpdateUnitNameColor

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 05:22:05 +02:00
SatyandClaude Opus 5.5 246f7ceb60 Port run-86 hit stand-ins: calendar, LFG, voice, party stats, quest POI icons
Ports the 19 stand-ins hit in run 86 with their direct dependencies:
calendar month/event-index scripts and helpers, LFG comment/leave,
voice and mute status, party member stats packet with stat change
build/dispatch and arena opponent slots, auto-complete flag removal,
knowledge base setup failure event, and quest POI icon placement.

Fixes: quest POI icon coordinates are int32 (binary uses fild), POI
overlap radius truncates the map span to int, calendar day event count
is unsigned, party pet name is a char field.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 04:41:22 +02:00
SatyandClaude Opus 5.5 6027112a59 Port stand-ins after run 85: UI script modules, AuctionHouse, Commentator
Ports the stand-ins hit since run 85 and the follow-up script batches:
RaidInfo, PartyFrame, BarberShop, ArenaTeamInfo, SkillInfo, InputControl,
petitions/guild registrar, ItemText, Tutorial, ContainerFrame, QuestLog,
ActionBar, ClassTrainer, UIMacros, GuildBank, AuctionHouse and Commentator.

Fixes found on the way: AuctionHouse sell items are a fixed inline array
(IsItemForSell read garbage), GetSellItem returns the container GUID,
Commentator instance key is read/written as u32/u16/u8 and skirmish
commands send a u32 flag, GetArenaMember returns uint64 in edx:eax.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 04:14:58 +02:00
SatyandClaude Opus 5.5 6a3666e4b6 Port run-83 hit stand-ins and fix phantom terrain walls blocking movement
- Fix CMap::GetChunkFacets: impassable test uses the chunk MapObjFlag
  (MAPOBJ_FLAG_IMPASSABLE at +0xC) like 12340, not MCNK header flag 0x40
  (vertex colours). Most chunks got 32000-high wall facets, so the player
  could jump but not walk.
- Ship paths: GetPosition, path time, accel/decel distance, roll/pitch.
- Transports: Transport::UpdateMovement, CollideWithTransport, owner matrix.
- Map objects: IsAllLoaded, footprints, TriData query chain (QueryTris,
  GetTrisTerrain/Chunk, GetTriSubchunk, QueryTrisMapObjDefs),
  QueryIntersectingModels.
- Water ripples, projected-texture shadow drawing (shadow.cpp).
- World states, LFG best random dungeon, quest POI, ComSat session lookup,
  blood record, virtual items, guild roster query.
- Logout path: tradeskill close, LCD, DBCache_ClearPending, chat/macro/
  saved-variable/account-data saving, tracked quests/achievements/
  tutorials, UnloadAddOns, SaveAddOnEnableState, ~CGWorldFrame,
  SmartScreenRectShutdown.
- Fixes: TriData batch heights stored as float* (was truncating uint32 on
  x64), TimeInRange is a ShipPath member, ComSat lookup takes the session
  type, roll/pitch names swapped in MapObjTransport::UpdateMovement,
  removed windows.h from Object/Passenger.h.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 15:33:24 +02:00
SatyandClaude Opus 5.5 f24e731415 Port hit stand-ins: unit swim/flight/vehicle, footprints, shadow query, liquid sounds, weather, world states, game object types, friend list packet
Old list #26-#77 and new list #1-#25: unit movement/vehicle passengers,
missile trajectory, trade skills, corpse/spirit healer UI, map flight
bounds, footprints, low detail render, shadow query gather/render,
CMapArea liquid sounds, weather type/pos deltas, world state init/set,
transport/chair/animated game objects, contact list packet, macros,
tracked achievements, tutorials, dungeon difficulty.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 10:10:31 +02:00
SatyandClaude Opus 5.5 9ddddebc34 Port minimap, item moves, cursor, character info, names, nameplates, combat text
- Fix RsSet render-target upload check (indoor rendering corruption)
- Minimap tracking/hover, world map refresh
- Bag/bar item moves, swaps, equip, item sounds, spell on cursor
- Character info stats, titles, model preview
- Unit/player names (PLAYERNAMEDESC render, name strings, raid icons)
- Nameplates: CGNamePlateFrame, CGSimpleHealthBar, unit glue, SmartScreenRect overlap solver
- Floating combat text: WORLDTEXTSTRING, render batch, PlayerName text slots
- Fix unescaped raid-icon texture path in PlayerNameInitialize

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 07:00:36 +02:00
SatyandClaude Opus 5.5 175f55b399 Port spells, loot, effects, missiles, level-up and non-gameplay UI stand-ins
Gameplay:
- Spell system pieces, spell effects lifecycle (CEffect), special effects,
  procedural/loot effects, impact visuals
- Unit anim events: AnimEventCallback, HandleAnimEvent, HandleCombatAnimEvent,
  parry anims, vehicle bone grab/throw events
- CGUnit_C::CreateMissile (target, point, point-array overloads)
- Loot: CGLootInfo/LootWindow/LootDisplay, loot rolls, loot packets and scripts
- Bags/items: FindItem, container/inventory mirror handlers, UseContainerItem
  (sell/bank/mail/trade/auction/guild bank), UseItem, item lock/unlock
- Threat, power regen, XP gain, quest item updates, skill changes
- Packet_Group_9 (level up, item push, exploration, taxi, bind, roll, ...)
- ChatBubbleShow/Remove
- x64 fix: map entity callback param is uintptr_t (pointer was truncated)

Non-gameplay (parallel batch): chat channels/settings, chat bubble frame,
game/server time, minimap POIs and init, mail, class trainer, skills,
achievements, currencies, calendar, world states, world map arrow/ping,
commentator, merchant buyback, battleground/arena info, EnterWorld for
~15 UI modules

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 03:06:16 +02:00
SatyandClaude Opus 5.5 6f9f1d9835 QuestLog: port objectives, quest text tokens, turn-in, XP, faction rewards, POI data
- QuestParserParseToken ($N $C $R $G $T $B $W $E $D $K $A), countdown text
- GetQuestLeaderBoardByID/ForObject, QuestLogLeaderBoardParams real layout,
  Lua GetQuestLogLeaderBoard, quest log query callbacks
- OnQuestGiverOfferReward, CalculateExperience, quest XP aura multiplier
- ProcessQuestLogRewardFactions / ProcessQuestRewardFactions
- HandlePOIQueryResponse, POI slot recycling, IsOnQuest, LoadTrackedQuests,
  AddQuestPointDisplay, display race/class name helpers

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 11:48:04 +02:00
SatyandClaude Opus 5.5 e41a19fe93 Gossip/Quest/Merchant: port NPC reply handlers
- Packet_SMSG_GOSSIP_MESSAGE, CGGossipInfo::ClearOptions/SetGossipText
  (NPC text cache, weighted text pick, emotes, translation)
- CGPlayer_C::OnQuestGiverQuestDetails, CGQuestInfo::SetState,
  SetLogDescription, AddReward, ClearState, ClearQuestItems
- CGPlayer_C::OnListInventory, RequestAllItemPurchaseData,
  CGMerchantInfo::SetMerchant and its item-stats callback
- QuestParserParseText (token handler still a stand-in),
  CGUnit_C::PlayEmotes

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 10:51:33 +02:00
SatyandClaude Opus 5.5 e664d4c121 WorldFrame/Player: port mouseover hit test, cursor tracking and NPC right-click
- CGWorldFrame hit test (HitTestPoint, FindClosestModel, selection legality)
  and cursor tree (OnLayerTrackObject, CursorTrack*), Cursor mode helpers
- Spell_C targeting predicates used by the hit test and cursor
- CGPlayer_C::HandleOnRightClick and the TalkTo*/ShopFromMerchant requests
- CGGameUI Set/Clear/CloseInteraction and the per-frame close functions
  (gossip, quest, merchant, bank, guild bank, registrar, stable, petition,
  battlemaster, trainer), mail ClearSendMail, talk emotes
- Zero-initialize 23 WOWGUID locals that were read uninitialized

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 10:34:48 +02:00
SatyandClaude Opus 5.5 1154792edb Tooltip: port item tooltips, item/name caches and hyperlinks
- CGTooltip::SetItem with section helpers, TooltipItemCallback,
  Script_SetBagItem, Script_SetInventoryItem, Script_SetHyperlink
- DBCache AddItems/DenyItem/Invalidate; NameCache AddItem, reverse
  name index (non-owning key), NameCache::Copy
- ItemLinkInfo::GetItemIdFromLink, CGMerchantInfo::GetRepairCost,
  CGUnit_C::GetPlayerDiscount, CGEquipmentManager::GetSetList/GetSetByID
- item/player/enchant helpers used by the item tooltip
- fix SetSpell callers passing the last rank arguments in the wrong order

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 09:43:18 +02:00
SatyandClaude Opus 5.5 b5ee377ba5 Tooltip: port spell tooltip, spell description parser and formula engine
CGTooltip::SetSpell (split into inlined section helpers), Lua SetSpell/SetSpellByID,
QuestTextParser spell text parser, MathState formula engine with MATHOP enum,
spell math (min/max points, duration, cast time, range) and talent tooltip text.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 08:00:10 +02:00
SatyandClaude Opus 5.5 8643d3761e Spellbook: port spell book Lua scripts and spell/rune helpers
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 07:10:25 +02:00
SatyandClaude Opus 5.5 3b76648777 Client bring-up: Lua stand-in ports, add-on loading, world map, combat log, locale fix
- Port hit-order Lua stand-ins (unit tokens, tooltips, combat log filters and
  current entry, bags/containers, quest POI, minimap, titles, world states,
  trade, group roles, runes, mirror timers, saved-variable registration, Quit)
- LoadAddOn: real add-on loading (Blizzard_CombatLog etc. now load)
- CombatLogEntry::PushEvent: COMBAT_LOG_EVENT arguments
- World map chain: SetMapToCurrentZone, SetMap, GetWorldPosition, landmarks,
  overlays, highlight, zones, dungeon levels, player position
- OpenArchives: locale index was off by one (enUS read the koKR DBC slot,
  leaving zone/map names empty)
- Zone/area sound chain, invisible units (spline mode read size), raid/bag
  crash fixes, stand-in console, waystone icon for all executables
- Coding-rule cleanups: statics/includes at the top, event enums, Lua
  _Scripts layout

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 06:31:10 +02:00
SatyandClaude Opus 5.5 18c46cb87e Client bring-up: in-world camera, input, movement, unit rendering
Ports verified against 12340 that take the x64 client from character
login to a playable world:

- Camera: SetView/ResetView, motion, free-look facing, tracking, bobs,
  liquid bump, world collision; camera Lua scripts
- Input: world frame key/mouse layers, default action, mouselook,
  turn/pitch player, TurnOrAction/CameraOrSelectOrMove scripts
- Movement: legal facing range, turn/pitch/raw facing events, transport
  status, move spline copy, unit update info, smooth facing, anim end
- Units: component and extended display init, model fade/scale,
  entity sort table, RenderEntitys, split-body culling
- Interiors: WMO group bounds, BSP segment link query, face linking,
  interior lighting
- Collision: CMap::QueryFacets closure with frustum queries and NDCClip
- UI: game UI mouse filters, client control state, faction standing
  packet, many *_Scripts.cpp Lua tables; name generator dictionary fix

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-29 23:04:53 +02:00
SatyandClaude Opus 5.5 3b857f3eb0 Object port: object classes, object manager, input control, WOWGUID type
- CGObject_C base, CEffect, CObjectEffect/CObjectEffectManager effect states
- Unit, Player, Item/Container/Bag, Corpse, DynamicObject, GameObject and
  all GameObject type classes (vtables matched slot by slot), Movement,
  MovementShared, Missile, Vehicle/Passenger/Camera, combat log, caches
- Client object manager (0x4D3100-0x4D7880) incl. SMSG_UPDATE_OBJECT,
  SMSG_COMPRESSED_UPDATE_OBJECT, SMSG_DESTROY_OBJECT; type ctors/PostInit
- CGGameUI::CanPerformAction and the ready part of CGInputControl
- Layouts named from descriptor fields and code; CM2Model 0x134 matrix,
  CClientObjCreate tail, CGUnit_C/CGPlayer_C sizes 0x1008/0x1958
- WOWGUID struct replaces the IDB's WGUID low/high pair and guid uint64_t;
  SmartGUID derives from it; member functions returning a guid keep
  uint64_t (MSVC returns class types from members via hidden pointer);
  structs with 4-aligned guids in 12340 use pack(4)

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-29 12:27:05 +02:00
SatyandClaude Opus 5.5 095603ff2b Client bring-up: login, realm list, world auth, character select
- Grunt login ported end to end (SRP6 challenge/proof, version checksum,
  realm list) and tested against a live server: authenticates, connects to
  the world server (auth session with proof-of-work, header crypt), receives
  the character list and shows character select
- Glue: realm list UI, character select (list, models, scripts), character
  create screen + name generator, delete/rename/decline, Enter World up to
  the loading screen; loading screen drawing and progress
- AccountData (times, update, upload/download), BannedAddOns, addon scan and
  addon info, client cache version, tutorial flags
- Shutdown path at login state: world/map/liquid/weather teardown, NetClient,
  ComSat, streaming stop; Logitech LCD no-device path in Ui/UILCD/Windows
- PCRE 5.0 vendored (core stock; chartables and the posix layer from 12340),
  ValidateName
- Fixes: TSGrowableArray::CalcChunkSize clamps to >= 8 (crash on char list),
  CWorldScene liquid renderer allocation, CMapFootprintTexture element ctor,
  pointer render states on x64, CFrustum/CWFrustum layout, M2 draw callback
  arguments, 37 class/struct forward-declaration mismatches
- IDB name sync (1217 names), verify aliases, harness large-element
  instantiation

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-28 02:39:56 +02:00
Saty 5137298335 Initial commit 2026-09-23 18:24:00 +02:00