- 360 Script_* re-approved: only change since approval is return 0
after luaL_error (semdiff vs binary)
- realm id field renames and TotemInfo m_guid (+0x8) checks re-approved
- CGlueMgr::OnKickReasonMsg passes via InitTokenSeed alias
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- luaB_getfenv: look up __environment metafield like 12340
- DSPSfxReverb::setParameterInternal: set mUpdate for REFLECTIONSLEVEL and REVERBLEVEL
- CGGameUI::DestroyTotem, Script_SetTotem: test the totem GUID, not unk_0004
- Missing return 0 after luaL_error in script functions
- OFFSET tags of template instances carry their instance type: [0xXXXXXX<Type>]
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Batch 1: weather templates, client console commands, loading screen paths,
glue script events, AddOns/AccountData/Battlenet getters, simple camera and
camera vehicle offsets, Warden module path, BLL loader, FFX effects, Grunt
and GruntLogin matrix/file handlers, CGlueMgr char customize/faction change/
kick reason.
semdiff: 251 Lua script functions called luaL_error without the return 0 that
12340 has after every call site (each confirmed per call site in the binary).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Ports the stand-ins hit since run 85 and the follow-up script batches:
RaidInfo, PartyFrame, BarberShop, ArenaTeamInfo, SkillInfo, InputControl,
petitions/guild registrar, ItemText, Tutorial, ContainerFrame, QuestLog,
ActionBar, ClassTrainer, UIMacros, GuildBank, AuctionHouse and Commentator.
Fixes found on the way: AuctionHouse sell items are a fixed inline array
(IsItemForSell read garbage), GetSellItem returns the container GUID,
Commentator instance key is read/written as u32/u16/u8 and skirmish
commands send a u32 flag, GetArenaMember returns uint64 in edx:eax.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- Port hit-order Lua stand-ins (unit tokens, tooltips, combat log filters and
current entry, bags/containers, quest POI, minimap, titles, world states,
trade, group roles, runes, mirror timers, saved-variable registration, Quit)
- LoadAddOn: real add-on loading (Blizzard_CombatLog etc. now load)
- CombatLogEntry::PushEvent: COMBAT_LOG_EVENT arguments
- World map chain: SetMapToCurrentZone, SetMap, GetWorldPosition, landmarks,
overlays, highlight, zones, dungeon levels, player position
- OpenArchives: locale index was off by one (enUS read the koKR DBC slot,
leaving zone/map names empty)
- Zone/area sound chain, invisible units (spline mode read size), raid/bag
crash fixes, stand-in console, waystone icon for all executables
- Coding-rule cleanups: statics/includes at the top, event enums, Lua
_Scripts layout
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Ports verified against 12340 that take the x64 client from character
login to a playable world:
- Camera: SetView/ResetView, motion, free-look facing, tracking, bobs,
liquid bump, world collision; camera Lua scripts
- Input: world frame key/mouse layers, default action, mouselook,
turn/pitch player, TurnOrAction/CameraOrSelectOrMove scripts
- Movement: legal facing range, turn/pitch/raw facing events, transport
status, move spline copy, unit update info, smooth facing, anim end
- Units: component and extended display init, model fade/scale,
entity sort table, RenderEntitys, split-body culling
- Interiors: WMO group bounds, BSP segment link query, face linking,
interior lighting
- Collision: CMap::QueryFacets closure with frustum queries and NDCClip
- UI: game UI mouse filters, client control state, faction standing
packet, many *_Scripts.cpp Lua tables; name generator dictionary fix
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>