The item type line (Axe, Sword, Dagger, ...) was hidden because the test
read m_flags (+0x10); 12340 reads m_displayFlags (+0x14) at 0x006277F0.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- Buffer.cpp: PNC2T2 Color0/Color1 are D3DCOLOR (type 0), not FLOAT3;
unified-path WMOs (MOHD flag 0x2, e.g. Icecrown Citadel) were drawn
blue/green/black (12340 init at 0x9CD010)
- CShadowQuery::AllocBuffers: size the group/matrix pointer arrays with
sizeof; 0x2000 bytes only fits 0x800 entries with 4-byte pointers
- ShaderEffect: upload sun constants with explicit w (the values 12340
reads from the neighbouring statics), independent of x64 layout
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Win64 only, behave as 12340 does when its checks find nothing or the x86 payload is rejected (docs/0x0086C3C0.md).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- SPIRIT IP-MR voice codec (Engine/Source/ComSat/SPIRIT): all ~130
functions decompiled from 12340 (Intel C++ code, ported as plain C;
rsqrtss sites use _mm_rsqrt_ss). docs/0x0089F580.md.
- ComSatSoundCODEC state/table buffers sized from sizeof (x64 state is
larger than the Win32 13504 bytes).
- Blizzard::Using::Use and the per-module using statics.
- ComSatClient_Init, ComSatThread::Init, ComSatClientCallback.
- SteelSeries WowMouse / HidManagerImpl (Win32 + Win64), docs/0x008C3E40.md.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- move triage code to the folders of its binary neighbours (AreaList,
movement packet types, CClientObjCreate, CWOWClientStatus, SHA1,
Clamp, EmergencyMem, MippedImg, WowMouse, ...)
- merge HMAC template, OnGxRestartClearWorld and TIMESTAMPSTRUCT into
their natural headers
- delete superseded duplicates and unk-only placeholders
- tools: drop Triage library, fix Streaming stub signatures, remove
stubs now provided by BlizzardCore, MapViewer s_liquidTypeId
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- one-line notes on the four community fixes present in the IDB input
(gamma, melee swing, turn attack anim, pre-cast anim)
- GetTradeSkillTools: FindTotemCategory flags 0 as in the signed exe;
the IDB's push -0x15 is the misplaced naked-character-issue patch
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- 360 Script_* re-approved: only change since approval is return 0
after luaL_error (semdiff vs binary)
- realm id field renames and TotemInfo m_guid (+0x8) checks re-approved
- CGlueMgr::OnKickReasonMsg passes via InitTokenSeed alias
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- luaB_getfenv: look up __environment metafield like 12340
- DSPSfxReverb::setParameterInternal: set mUpdate for REFLECTIONSLEVEL and REVERBLEVEL
- CGGameUI::DestroyTotem, Script_SetTotem: test the totem GUID, not unk_0004
- Missing return 0 after luaL_error in script functions
- OFFSET tags of template instances carry their instance type: [0xXXXXXX<Type>]
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Batch 1: weather templates, client console commands, loading screen paths,
glue script events, AddOns/AccountData/Battlenet getters, simple camera and
camera vehicle offsets, Warden module path, BLL loader, FFX effects, Grunt
and GruntLogin matrix/file handlers, CGlueMgr char customize/faction change/
kick reason.
semdiff: 251 Lua script functions called luaL_error without the return 0 that
12340 has after every call site (each confirmed per call site in the binary).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Counts the binary converts as unsigned (fild + jge + fadd 2^32) or signed
(sar, plain fild) now use the matching types; KB count scripts return
luaL_error's result like the binary.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Remaining CGTradeSkillInfo methods (SetTradeSkill, SetLink, list link,
filters, sorting, Profession_FilterSpell), the static Script_* functions,
and CaseAccentInsensitiveParse. s_itemModTokens is now shared from Tooltip.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
LFG search results: LFGListPlayer/LFGListParty/LFGLIST layouts from the
binary, LFGHandler::ReadGroupInfo/ReadPlayerInfo, party add/remove, list
copy/clear/remove/reindex, SMSG_LFG_SEARCH_RESULTS, sort comparators.
CGLookingForGroup: leave, proposal response/member/encounter, boot vote,
role check member, search join, clear dungeon, queue status index,
ClearPartyInfo, ResortLFGLists; all remaining LFG scripts;
CGGameUI::GetInstanceDifficulty.
QuestLog: GetQuestWorldMapAreaID, GetQuestLeaderBoardForItem, quest watch
sorting and POI distance, UpdateQuestPOIFromUserServer and the UpdatePOI
console command. QuestWatch +8 is the sort distance (m_distance).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
72 ChatFrame functions: remaining chat scripts (channels, voice, chat
logging, complaints, saved instances, chat window/colour reset, emotes,
join from script), complaint record lookup, voice roster/session updates,
user list add/remove and title earned handlers, honor/feed pet/tradeskill/
open lock combat log messages, pending user list display.
Callees ported: ComSatClient_LeaveAllSessions and its member notify,
PlayDance, CGDanceStudio::HasDance (dance table keyed by name),
GetMaxPlayersForMap, CGPlayer_C::SendTextEmote, CGUnit_C::Unk724410.
0x4CFB80 (m_paused++) renamed CGChat::Pause; CGChat::LeaveWorld is now
0x4FB190. Pause/Resume/IsPaused and m_paused moved from
SoundInterface2Foley.cpp to ChatFrame.cpp.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
When ON (DISABLE_SIGNATURE_CHECKS=1), the client skips the signaturefile
MPQ MD5 checks, FrameXML_CheckSignature reports .toc files as valid with
the digest of the files on disk, and GlueXML, FrameXML and AddOn loading
skip their post-load digest comparison. OFF keeps the original checks.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Ports the 19 stand-ins hit in run 86 with their direct dependencies:
calendar month/event-index scripts and helpers, LFG comment/leave,
voice and mute status, party member stats packet with stat change
build/dispatch and arena opponent slots, auto-complete flag removal,
knowledge base setup failure event, and quest POI icon placement.
Fixes: quest POI icon coordinates are int32 (binary uses fild), POI
overlap radius truncates the map span to int, calendar day event count
is unsigned, party pet name is a char field.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Ports the stand-ins hit since run 85 and the follow-up script batches:
RaidInfo, PartyFrame, BarberShop, ArenaTeamInfo, SkillInfo, InputControl,
petitions/guild registrar, ItemText, Tutorial, ContainerFrame, QuestLog,
ActionBar, ClassTrainer, UIMacros, GuildBank, AuctionHouse and Commentator.
Fixes found on the way: AuctionHouse sell items are a fixed inline array
(IsItemForSell read garbage), GetSellItem returns the container GUID,
Commentator instance key is read/written as u32/u16/u8 and skirmish
commands send a u32 flag, GetArenaMember returns uint64 in edx:eax.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Old list #26-#77 and new list #1-#25: unit movement/vehicle passengers,
missile trajectory, trade skills, corpse/spirit healer UI, map flight
bounds, footprints, low detail render, shadow query gather/render,
CMapArea liquid sounds, weather type/pos deltas, world state init/set,
transport/chair/animated game objects, contact list packet, macros,
tracked achievements, tutorials, dungeon difficulty.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- CGWorldFrame hit test (HitTestPoint, FindClosestModel, selection legality)
and cursor tree (OnLayerTrackObject, CursorTrack*), Cursor mode helpers
- Spell_C targeting predicates used by the hit test and cursor
- CGPlayer_C::HandleOnRightClick and the TalkTo*/ShopFromMerchant requests
- CGGameUI Set/Clear/CloseInteraction and the per-frame close functions
(gossip, quest, merchant, bank, guild bank, registrar, stable, petition,
battlemaster, trainer), mail ClearSendMail, talk emotes
- Zero-initialize 23 WOWGUID locals that were read uninitialized
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- CGTooltip::SetItem with section helpers, TooltipItemCallback,
Script_SetBagItem, Script_SetInventoryItem, Script_SetHyperlink
- DBCache AddItems/DenyItem/Invalidate; NameCache AddItem, reverse
name index (non-owning key), NameCache::Copy
- ItemLinkInfo::GetItemIdFromLink, CGMerchantInfo::GetRepairCost,
CGUnit_C::GetPlayerDiscount, CGEquipmentManager::GetSetList/GetSetByID
- item/player/enchant helpers used by the item tooltip
- fix SetSpell callers passing the last rank arguments in the wrong order
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
CGTooltip::SetSpell (split into inlined section helpers), Lua SetSpell/SetSpellByID,
QuestTextParser spell text parser, MathState formula engine with MATHOP enum,
spell math (min/max points, duration, cast time, range) and talent tooltip text.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- Port hit-order Lua stand-ins (unit tokens, tooltips, combat log filters and
current entry, bags/containers, quest POI, minimap, titles, world states,
trade, group roles, runes, mirror timers, saved-variable registration, Quit)
- LoadAddOn: real add-on loading (Blizzard_CombatLog etc. now load)
- CombatLogEntry::PushEvent: COMBAT_LOG_EVENT arguments
- World map chain: SetMapToCurrentZone, SetMap, GetWorldPosition, landmarks,
overlays, highlight, zones, dungeon levels, player position
- OpenArchives: locale index was off by one (enUS read the koKR DBC slot,
leaving zone/map names empty)
- Zone/area sound chain, invisible units (spline mode read size), raid/bag
crash fixes, stand-in console, waystone icon for all executables
- Coding-rule cleanups: statics/includes at the top, event enums, Lua
_Scripts layout
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Ports verified against 12340 that take the x64 client from character
login to a playable world:
- Camera: SetView/ResetView, motion, free-look facing, tracking, bobs,
liquid bump, world collision; camera Lua scripts
- Input: world frame key/mouse layers, default action, mouselook,
turn/pitch player, TurnOrAction/CameraOrSelectOrMove scripts
- Movement: legal facing range, turn/pitch/raw facing events, transport
status, move spline copy, unit update info, smooth facing, anim end
- Units: component and extended display init, model fade/scale,
entity sort table, RenderEntitys, split-body culling
- Interiors: WMO group bounds, BSP segment link query, face linking,
interior lighting
- Collision: CMap::QueryFacets closure with frustum queries and NDCClip
- UI: game UI mouse filters, client control state, faction standing
packet, many *_Scripts.cpp Lua tables; name generator dictionary fix
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- CGObject_C base, CEffect, CObjectEffect/CObjectEffectManager effect states
- Unit, Player, Item/Container/Bag, Corpse, DynamicObject, GameObject and
all GameObject type classes (vtables matched slot by slot), Movement,
MovementShared, Missile, Vehicle/Passenger/Camera, combat log, caches
- Client object manager (0x4D3100-0x4D7880) incl. SMSG_UPDATE_OBJECT,
SMSG_COMPRESSED_UPDATE_OBJECT, SMSG_DESTROY_OBJECT; type ctors/PostInit
- CGGameUI::CanPerformAction and the ready part of CGInputControl
- Layouts named from descriptor fields and code; CM2Model 0x134 matrix,
CClientObjCreate tail, CGUnit_C/CGPlayer_C sizes 0x1008/0x1958
- WOWGUID struct replaces the IDB's WGUID low/high pair and guid uint64_t;
SmartGUID derives from it; member functions returning a guid keep
uint64_t (MSVC returns class types from members via hidden pointer);
structs with 4-aligned guids in 12340 use pack(4)
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>