47 Commits
Author SHA1 Message Date
SatyandClaude Opus 5.5 eabc5d8997 Port the logic fixes from the msvc80 branch
Behaviour fixes found while byte-matching against 12340, without the
VS2005 code-shape rewrites:
- 272502f5 logic bugs (MapObjDef 0x80 flag, D3D texop, PostReenable, ...)
- 3002c17f case-sensitive KNOWNDANCES/DECLINEDWORD keys, DynamicObject
  GetTransportGUID, CShadowCache::Initialize
- OpenGl IStateSyncEnables fill/line, DsSet integer value tests
- FriendList tail padding, HandleSpellEventSound severity, selection
  index -1, negative spell id in HasPetSpell
- operator delete null checks, FMOD MemoryFile seek clamp, SErr
  HeapAlloc flags
- WOWCLIENT_CRASH_LOG option

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-15 15:18:17 +02:00
SatyandClaude Opus 5.5 82879a879d Port the last non-anti-cheat functions: ServerLink, PetAction, emitter params
- Grunt::ServerLink: all CMD_GRUNT_* handlers, send helpers, features/strings, command table 0xB24D70,
  s_localeIds 0xAD3004, Pending::Remove (dead server-side link, docs/0x008CE200.md); ServerLink.h stub removed
- PetAction type for CGPetInfo::m_actions / pet spell actions / cursor pet action, SetAutocast 0x5D32F0
- CParticleEmitter2 fields 0x98-0x11F moved into CParticleEmitter2::Params (ctor 0x979250)
- fixed16(float), C3Vector::FlushDenormals, CGxuLightQueue + static 0xC7C074, CAaSphere(), CMapLowDetail(),
  C2Vector()/C4Plane() out of line, SpellHistory dtor, CGDynamicObject_C GetScale/GetRawFacing
- DB record operator= (PetNameCache, CGPetition, DanceCache): fixes the shallow-copy double free in AddItem
- ClientSetTimer(delay, handler, param) with its five callers, IOMd5Unit::Create without container,
  CDataStore::GetByte / Get(int32_t&), WDataStore::GetHeaderSpace, TSHashTable::Head, TSList::IsEmpty
- CameraTurnPlayer calls CVehicleCamera_C::IsTransitioningFacing 0x5FAA10 (was IsHierarchyChasingFacing)
- OFFSET additions: TSHashTable::Unlink, TInstanceId dtor, DBCACHEHASH dtor (+ ItemNameCache_C dtor),
  CDataStoreCache ctor, BitUnpacker/RunningAverageCalculator deleting dtors, CGTooltip::GetObjectType

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-04 08:10:06 +02:00
SatyandClaude Opus 5.5 c790ecb4a0 Port Streaming/Storage/Transport/HTTP, Mopaq write path and missing-function batches
- Streaming: StreamingManager, Manifests, Storage (.part files, write queue),
  Transport (HTTP split download, throttle), Tracker/StartupReport, streaming
  filestack verbs (s_streamstack, StreamingOpen), RepairCache static
- URL: HttpRequest, InternetCallback, ReadResponseData, DownloadURL
- Mopaq write path: SFileCreateArchive/CreateFile/WriteFile, IOMpqWriteUnit,
  WriteArchiveChanges, RebuildHashTable, listfile acquire/release;
  SComp::Compress with RLE/zlib/bzip2/pkware compressors; MPQEncrypt::Encrypt
- LaunchChildProcessWithArguments, Debug::DefaultCallback/Breakpoint
- Earlier batches: ComSat, Battlenet Tumor, Glue/Ui/WowServices fixes,
  luaL_error returns in Script_ files

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 16:51:23 +02:00
SatyandClaude Opus 5.5 2fc01591aa Fix bugs found by asmwalk/semdiff, add luaL_error returns, typed template tags
- luaB_getfenv: look up __environment metafield like 12340
- DSPSfxReverb::setParameterInternal: set mUpdate for REFLECTIONSLEVEL and REVERBLEVEL
- CGGameUI::DestroyTotem, Script_SetTotem: test the totem GUID, not unk_0004
- Missing return 0 after luaL_error in script functions
- OFFSET tags of template instances carry their instance type: [0xXXXXXX<Type>]

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 10:11:32 +02:00
SatyandClaude Opus 5.5 312ab9ac65 Port batch 1 missing functions and add missing luaL_error returns found by semdiff
Batch 1: weather templates, client console commands, loading screen paths,
glue script events, AddOns/AccountData/Battlenet getters, simple camera and
camera vehicle offsets, Warden module path, BLL loader, FFX effects, Grunt
and GruntLogin matrix/file handlers, CGlueMgr char customize/faction change/
kick reason.

semdiff: 251 Lua script functions called luaL_error without the return 0 that
12340 has after every call site (each confirmed per call site in the binary).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 05:48:17 +02:00
SatyandClaude Opus 5.5 b76f1b443a Port packs w3-w5: objects/vehicles, LCD stack, ComSat voice chat, map dtors, misc missing functions
- Object/vehicle/spell-visual/world/MapObj functions from pack w3
- Logitech LCD stack (CLCDBase..CLCDConnection, CLCDText/Bitmap/Page, CEzLcd, CEzLcdPage, CLCDUtils) and CGLCD
- ComSat client: voice start/stop, mute, sound group fade, tick, event dispatch; s_comsatCallbacks is a growable array
- ShipPath pause/offset, Transport state progress, vehicle bone anim/passenger removal, NetClient redirect
- Map class destructors (CMapArea/Chunk/DoodadDef/Entity/ObjDefGroup), CMapChunk +0xB4 is a TSLink
- Character rename/customize, ClientServices login/survey wrappers, glue Lua scripts, DayNight light overrides
- Template instance and deleting-dtor OFFSETs

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 03:16:42 +02:00
SatyandClaude Opus 5.5 7c83a8297a Port Ui missing functions: KB, AccountMsg, Minigame, Dance, EquipmentManager, InstanceEncounter, macro conditions, Trade, Rune, misc LeaveWorld handlers
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 18:37:56 +02:00
SatyandClaude Opus 5.5 393769ff36 Port single-missing-function modules
LeaveWorld handlers, game object type checks, corpse/dynamic object
virtuals, loot/voice/macro helpers, declined words, ProcessAgreement,
ObjectCreateStaticEx, FFX death/fog-seed/nether-blur passes, software
snow renderer, streaming decal, QuestCache copy, trajectory encoder and
deleting destructor tags. Fixes the missing CMapStaticEntity destructor
model release.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 14:39:43 +02:00
SatyandClaude Opus 5.5 46b5adf64f Port FriendList, Player_C, Unit_C and GameObject_C modules
- FriendList: remaining methods and 28 Lua scripts, FriendListModuleLoaded
- Player_C: remaining functions incl. click-to-move (ClickToMove, CTMFace,
  CTMClickTerrain, CTMAttackUnit, CTMInteractGO), dance, virtual items,
  sound and skill-rank overrides
- Unit_C: tracking (HandleTracking and helpers, SetTrackingTarget/Direction),
  selection circles, spell visual overrides, mirror image, flag-2 changes,
  scale update, missile trajectory (ComputeMissileTrajectory,
  SendFinalMissileTrajectoryUpdate, StartMissileTrajectoryTargeting) and
  CMissileCollision (Init, unit ranking, hit spheres)
- GameObject_C: IsLocked, UseObject, TypeBase CanUseNow/CheckRange/Use/
  CanChangeCursor, Ritual and MeetingStone types, virtual overrides,
  property helpers named from the binary's property table
- Dependencies: ProjectTex::Render2d, weapon trail chain (SWING,
  WTOBJECT::SetDrawTrail), GxSwizzleColor, CAaBox::Expand/Center,
  CVehicle_C::PlayBoneAnimOrFallback, RuneInfo/PetitionInfo/ClassTrainer/
  ComSat helpers, CalendarEventTables ctor
- DBCache: InvalidateIntKey, RetryItem, SetTemporary, ~DBCACHEHASH
- Template instances, deleting dtors and TSHashTable/WowClientDB instances
  recorded in their OFFSET lists

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 12:07:58 +02:00
SatyandClaude Opus 5.5 bbf3de4926 Record skipped template instances and ChatChannel ctor
Template instance addresses added to stpl.h (TSList::UnlinkNode,
~TSHashTable deleting destructors, TSGrowableArray::SetCount,
~TSFixedArray) and WowClientDB::GetRecordByIndex. ChatChannel default
constructor 0x502960 ported (user-provided: sets +0x9C/+0xA0 to 1).
M2Shared.cpp: VERIFY re-stamp only.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 09:11:39 +02:00
SatyandClaude Opus 5.5 6027112a59 Port stand-ins after run 85: UI script modules, AuctionHouse, Commentator
Ports the stand-ins hit since run 85 and the follow-up script batches:
RaidInfo, PartyFrame, BarberShop, ArenaTeamInfo, SkillInfo, InputControl,
petitions/guild registrar, ItemText, Tutorial, ContainerFrame, QuestLog,
ActionBar, ClassTrainer, UIMacros, GuildBank, AuctionHouse and Commentator.

Fixes found on the way: AuctionHouse sell items are a fixed inline array
(IsItemForSell read garbage), GetSellItem returns the container GUID,
Commentator instance key is read/written as u32/u16/u8 and skirmish
commands send a u32 flag, GetArenaMember returns uint64 in edx:eax.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 04:14:58 +02:00
SatyandClaude Opus 5.5 6a3666e4b6 Port run-83 hit stand-ins and fix phantom terrain walls blocking movement
- Fix CMap::GetChunkFacets: impassable test uses the chunk MapObjFlag
  (MAPOBJ_FLAG_IMPASSABLE at +0xC) like 12340, not MCNK header flag 0x40
  (vertex colours). Most chunks got 32000-high wall facets, so the player
  could jump but not walk.
- Ship paths: GetPosition, path time, accel/decel distance, roll/pitch.
- Transports: Transport::UpdateMovement, CollideWithTransport, owner matrix.
- Map objects: IsAllLoaded, footprints, TriData query chain (QueryTris,
  GetTrisTerrain/Chunk, GetTriSubchunk, QueryTrisMapObjDefs),
  QueryIntersectingModels.
- Water ripples, projected-texture shadow drawing (shadow.cpp).
- World states, LFG best random dungeon, quest POI, ComSat session lookup,
  blood record, virtual items, guild roster query.
- Logout path: tradeskill close, LCD, DBCache_ClearPending, chat/macro/
  saved-variable/account-data saving, tracked quests/achievements/
  tutorials, UnloadAddOns, SaveAddOnEnableState, ~CGWorldFrame,
  SmartScreenRectShutdown.
- Fixes: TriData batch heights stored as float* (was truncating uint32 on
  x64), TimeInRange is a ShipPath member, ComSat lookup takes the session
  type, roll/pitch names swapped in MapObjTransport::UpdateMovement,
  removed windows.h from Object/Passenger.h.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 15:33:24 +02:00
SatyandClaude Opus 5.5 9ddddebc34 Port minimap, item moves, cursor, character info, names, nameplates, combat text
- Fix RsSet render-target upload check (indoor rendering corruption)
- Minimap tracking/hover, world map refresh
- Bag/bar item moves, swaps, equip, item sounds, spell on cursor
- Character info stats, titles, model preview
- Unit/player names (PLAYERNAMEDESC render, name strings, raid icons)
- Nameplates: CGNamePlateFrame, CGSimpleHealthBar, unit glue, SmartScreenRect overlap solver
- Floating combat text: WORLDTEXTSTRING, render batch, PlayerName text slots
- Fix unescaped raid-icon texture path in PlayerNameInitialize

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 07:00:36 +02:00
SatyandClaude Opus 5.5 175f55b399 Port spells, loot, effects, missiles, level-up and non-gameplay UI stand-ins
Gameplay:
- Spell system pieces, spell effects lifecycle (CEffect), special effects,
  procedural/loot effects, impact visuals
- Unit anim events: AnimEventCallback, HandleAnimEvent, HandleCombatAnimEvent,
  parry anims, vehicle bone grab/throw events
- CGUnit_C::CreateMissile (target, point, point-array overloads)
- Loot: CGLootInfo/LootWindow/LootDisplay, loot rolls, loot packets and scripts
- Bags/items: FindItem, container/inventory mirror handlers, UseContainerItem
  (sell/bank/mail/trade/auction/guild bank), UseItem, item lock/unlock
- Threat, power regen, XP gain, quest item updates, skill changes
- Packet_Group_9 (level up, item push, exploration, taxi, bind, roll, ...)
- ChatBubbleShow/Remove
- x64 fix: map entity callback param is uintptr_t (pointer was truncated)

Non-gameplay (parallel batch): chat channels/settings, chat bubble frame,
game/server time, minimap POIs and init, mail, class trainer, skills,
achievements, currencies, calendar, world states, world map arrow/ping,
commentator, merchant buyback, battleground/arena info, EnterWorld for
~15 UI modules

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 03:06:16 +02:00
SatyandClaude Opus 5.5 3b76648777 Client bring-up: Lua stand-in ports, add-on loading, world map, combat log, locale fix
- Port hit-order Lua stand-ins (unit tokens, tooltips, combat log filters and
  current entry, bags/containers, quest POI, minimap, titles, world states,
  trade, group roles, runes, mirror timers, saved-variable registration, Quit)
- LoadAddOn: real add-on loading (Blizzard_CombatLog etc. now load)
- CombatLogEntry::PushEvent: COMBAT_LOG_EVENT arguments
- World map chain: SetMapToCurrentZone, SetMap, GetWorldPosition, landmarks,
  overlays, highlight, zones, dungeon levels, player position
- OpenArchives: locale index was off by one (enUS read the koKR DBC slot,
  leaving zone/map names empty)
- Zone/area sound chain, invisible units (spline mode read size), raid/bag
  crash fixes, stand-in console, waystone icon for all executables
- Coding-rule cleanups: statics/includes at the top, event enums, Lua
  _Scripts layout

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 06:31:10 +02:00
SatyandClaude Opus 5.5 18c46cb87e Client bring-up: in-world camera, input, movement, unit rendering
Ports verified against 12340 that take the x64 client from character
login to a playable world:

- Camera: SetView/ResetView, motion, free-look facing, tracking, bobs,
  liquid bump, world collision; camera Lua scripts
- Input: world frame key/mouse layers, default action, mouselook,
  turn/pitch player, TurnOrAction/CameraOrSelectOrMove scripts
- Movement: legal facing range, turn/pitch/raw facing events, transport
  status, move spline copy, unit update info, smooth facing, anim end
- Units: component and extended display init, model fade/scale,
  entity sort table, RenderEntitys, split-body culling
- Interiors: WMO group bounds, BSP segment link query, face linking,
  interior lighting
- Collision: CMap::QueryFacets closure with frustum queries and NDCClip
- UI: game UI mouse filters, client control state, faction standing
  packet, many *_Scripts.cpp Lua tables; name generator dictionary fix

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-29 23:04:53 +02:00
SatyandClaude Opus 5.5 3b857f3eb0 Object port: object classes, object manager, input control, WOWGUID type
- CGObject_C base, CEffect, CObjectEffect/CObjectEffectManager effect states
- Unit, Player, Item/Container/Bag, Corpse, DynamicObject, GameObject and
  all GameObject type classes (vtables matched slot by slot), Movement,
  MovementShared, Missile, Vehicle/Passenger/Camera, combat log, caches
- Client object manager (0x4D3100-0x4D7880) incl. SMSG_UPDATE_OBJECT,
  SMSG_COMPRESSED_UPDATE_OBJECT, SMSG_DESTROY_OBJECT; type ctors/PostInit
- CGGameUI::CanPerformAction and the ready part of CGInputControl
- Layouts named from descriptor fields and code; CM2Model 0x134 matrix,
  CClientObjCreate tail, CGUnit_C/CGPlayer_C sizes 0x1008/0x1958
- WOWGUID struct replaces the IDB's WGUID low/high pair and guid uint64_t;
  SmartGUID derives from it; member functions returning a guid keep
  uint64_t (MSVC returns class types from members via hidden pointer);
  structs with 4-aligned guids in 12340 use pack(4)

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-29 12:27:05 +02:00
SatyandClaude Opus 5.5 4a571e727c World port: WMO water, fog, area updates, purge chain, detail doodads
- Barriers, shadow/portal queries, underwater selection, hit testing
- Interior water: PolyClipper, ClipGroupGeometry, liquid index fix
- Area updates, barrier updates, purge/free chain for areas, chunks,
  doodad and map object defs, detail doodad update list
- Water ripples, terrain pixel shader path, liquid shader toggles
- Detail doodads: creation per chunk, pools, batching, vertex/index
  fill, shader and fixed-function render state, RenderDetailDoodads
  (trailing occluder/debug draws still to port), CMapChunk::SelectLights
- DayNight moved to WoW/Source/WorldClient
- MapViewer: fog, WMO water, detail doodads; diagnostics removed

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-29 07:43:15 +02:00
SatyandClaude Opus 5.5 f6d07ea346 World port: liquids, map load chain, terrain rendering in MapViewer
Liquid system ported from 12340 (LiquidSystem module, chunk/WMO liquid, wave
manager, geometry factories); CMap load chain (Load, LoadWdt, low-detail WDL,
lights, CreateMapObjDef, PurgeMaps); CMapChunk create/batch/vertex/index code;
CMapRenderChunk; frustum stack and scene cull helpers. MapViewer renders
terrain through a viewer-only shortcut (ViewerWorld.cpp). Engine fix: int
render-state setters write the full pointer-sized slot (x64 texture crash).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-28 08:07:38 +02:00
SatyandClaude Opus 5.5 095603ff2b Client bring-up: login, realm list, world auth, character select
- Grunt login ported end to end (SRP6 challenge/proof, version checksum,
  realm list) and tested against a live server: authenticates, connects to
  the world server (auth session with proof-of-work, header crypt), receives
  the character list and shows character select
- Glue: realm list UI, character select (list, models, scripts), character
  create screen + name generator, delete/rename/decline, Enter World up to
  the loading screen; loading screen drawing and progress
- AccountData (times, update, upload/download), BannedAddOns, addon scan and
  addon info, client cache version, tutorial flags
- Shutdown path at login state: world/map/liquid/weather teardown, NetClient,
  ComSat, streaming stop; Logitech LCD no-device path in Ui/UILCD/Windows
- PCRE 5.0 vendored (core stock; chartables and the posix layer from 12340),
  ValidateName
- Fixes: TSGrowableArray::CalcChunkSize clamps to >= 8 (crash on char list),
  CWorldScene liquid renderer allocation, CMapFootprintTexture element ctor,
  pointer render states on x64, CFrustum/CWFrustum layout, M2 draw callback
  arguments, 37 class/struct forward-declaration mismatches
- IDB name sync (1217 names), verify aliases, harness large-element
  instantiation

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-28 02:39:56 +02:00
SatyandClaude Opus 5.5 2e418f9e08 Client bring-up: glue screen, EULA/TOS, shutdown chain, LCD, x64 fixes
- Stand-in client reaches the glue screens (intro movie, EULA/TOS accept,
  login screen) at 16:9; stand-ins are report-only on x64
- Ports on the startup/idle path: GlueScriptEvents/CharacterSelection/
  CharacterCreation/RealmList/AccountMsg/VideoOptions _Scripts, CGlueMgr
  (Initialize/Resume/Idle/Accept*/Shutdown), ClientServices, NetClient/
  WowConnection, DBCache + instances, WorldParam/World/Map/Liquid/Weather/
  shadow, InputControl, Scrn, ConsoleClient, SysMessage, LoadingScreen,
  SystemRegisterFunctions, CGameTime, Screen::GetAspectRatio
- Shutdown chain: BeginCloseGame, DestroyEngineCallback, DBCache save/
  destroy, SpellVisuals/Effect/World/Glue teardown
- Logitech LCD no-device path in Ui/UILCD/Windows (Windows-only dir);
  lgLcd is a stub library in ThirdParty/lgLcd
- CVar and console commands split into <Module>_CVar.cpp / _Console.cpp
- DivxDecoder.dll (Win32, original) and XvidDecoder.dll (x64, port with
  vendored xvidcore) both copied to the build folder
- Warden: Win32 faithful port, Win64 stub
- x64 fixes: lua_newstate gcusage/gctime init, pointer render states reset
  with nullptr, g_rndSeed defined
- 37 class/struct forward-declaration mismatches fixed (false stand-ins)

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 21:47:34 +02:00
SatyandClaude Opus 5.5 472530e785 Client bring-up: WinMain to event loop, Engine/FFX port
Tool client (Tools/WowClient) with generated stand-ins now runs
InitializeGlobal completely: config, locale, MPQs, signature file,
hardware detect, D3D device, Storm log. Stops at InitializeEngineCallback.

- entry start 0x401000 (StormRtlInitialize before CRT), /ENTRY:start
- ConsoleDevice + ConsoleDetect module, GxDefaultApi
- SFile signature path (ClearAllFileFlags, SetFileSignature, HashMap insert)
- WowLogHeader + helpers, SMemIsValidPointer, ClntObjMgrIsValid
- ConsoleWrite line list, CGObject_C vtable declarations
- crash handler prints symbolized x64 stack
- Engine/FFX port (FFX agent), Pass headers moved out of _Triage

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 17:23:27 +02:00
SatyandClaude Opus 5.5 34770ee7ab Frame: port Engine/Frame (waves 1-4), 1667 of 1669 functions
Core (CSimpleFrame + Lua, CSimpleTop/CFrameStrata/CSimpleRender/
CRenderBatch, CSimpleRegion/CBackdropGenerator/CScriptRegion), animation,
text (FontString/Font/Fontable), texture and model, buttons, EditBox,
MessageFrame/MessageScrollFrame, MovieFrame/ColorSelect/StatusBar,
Slider/ScrollFrame/HTML/HyperlinkedFrame, all Lua method tables and
RegisterScriptMethods. Layouts, vtables and sizes rebuilt from the
12340 ctors, vtables and allocator initializers; CScriptObject vtable
slots 5/6 fixed; CSimpleFontedFrame is a real secondary base. Lua error
paths return after luaL_error as in 12340 (209 sites; 5 fall through).
Binary quirks kept and documented in docs/.

Supporting additions: Event key/char/ime/focus/size event headers,
Scrn/Scrn.h (ScrnLayerCreate), DivxDecoder import declarations,
C2Vector/CRect helpers, CM2Light dtor, OsInputEnableSecureMode, stpl.h
instance addresses, FrameXML LoadXML_AnimGroup/Create_SimpleMovieFrame.
Engine->WoW includes where 12340 calls directly: CSimpleModelFFX,
StringToMouseButton, GetDeclinedWord, EmblemTextureUpdate.

Also drops stale VERIFY stamps found invalid by the harness recheck.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 15:32:18 +02:00
SatyandClaude Opus 5.5 7c1b3b9858 WoW/Common: WowTime, TextureCache, Lightning, AaBsp, ComponentCore
272 definitions, 111 pass and 161 approved with per-function reasons,
0 fail. CCharacterComponent and ComponentUtils started from the
thunderbrew port and were checked against 12340: adds the threading and
compression paths (CComponentRequest, CComponentMipBits, SSE and scalar
DXT1 compressors), static cdecl helpers, bool SetRandom*, signed prefs
modulo, fixed main/off-hand sheath links. CLightning/CLightningManager
moved here from Services (Common\Lightning.cpp); SetCount fixes the
never-filled joint arrays, alpha rounds via fint_. ItemDisplayInfoRec
ctor carries the folded GetRow OFFSET; 0x4F1650 joins the stpl.h list.
Stand-in declarations in World.h, ComponentData.h and Player_C.h.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 05:02:09 +02:00
SatyandClaude Opus 5.5 425ae44fe3 Storm: MD5, SCrc, Storm IOFileUnit and template instances
MD5Init/Transform/Update/Final (0x779340-0x779AE0), SCrcBuffer/SCrcCompute
(0x779BA0, table 0xADE9A8), the Storm::IOFileUnit family (0x779C30-0x77A530,
Win32/Win64) and TSExportTableSyncReuse's deleting destructor, plus new
template instances in the stpl.h OFFSET lists (from the Storm, Tempest,
Os, SoundInterface and Frame work).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 03:04:03 +02:00
SatyandClaude Opus 5.5 cb9f7f4ac7 Base/Event: cover HandleCompare and the remaining destructors
HandleCompare (0x47BF20): the ICF-folded 4-byte handle difference that the
M2 scene sorts, CSimpleTexture and CDetailDoodadInst call. ~TRefCnt now
names its scalar deleting destructor (0x480E40), ~CDataRecycler adds
0x95CE00, and TSHashObject gets its destructor (0x47C560, the HASHKEY_STR
instance). Event is 88/88, Base 122/123 (the s_callbackRegAllocator atexit
thunk stays compiler-generated).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 01:13:36 +02:00
SatyandClaude Opus 5.5 7c7f474658 FrameXML: port XMLTree, FrameXML and LoadXML TUs
XMLTree.cpp (0x8145B0-0x814E40, XMLTree_GetRoot at 0x8BE770), FrameXML.cpp
(0x812530-0x8145A3) and LoadXML.cpp (0x814E40-0x816767, name guessed: no
__FILE__ string). LoadXML_AnimGroup and Create_SimpleMovieFrame stay
declared until their Frame classes exist.

XMLNode allocates from the CDataAllocator at 0xD3F718; CScriptRegion derives
from CScriptObject and CLayoutFrame (second vtable at +0x20); the attribute
array element is CXMLAttribute. Expat.h declares the expat API by hand until
expat is vendored.

Shared additions: Frame enums (FRAME_STRATA, ORIENTATION, SimpleAnim*,
ANCHORPOINT renamed FRAMEPOINT), Frame class vtable slots/constructors/
allocators and four shell classes, EGxBlend, MD5_CTX, one stpl.h instance.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 00:49:59 +02:00
SatyandClaude Opus 5.5 855c7175b1 ObjectAlloc: port ObjectAlloc.cpp and HeapUsage.cpp
ObjectAlloc.cpp (0x4D2AA0-0x4D36C0) and HeapUsage.cpp (0x4D2780-0x4D2AA0).
CObjectHeap moves from _Triage to IObjectAlloc.h, where 12340's inline
destructor puts it (IObjectAlloc.h line 30 in the SMemFree calls).

stpl.h: TSFixedArray gets its copy constructor (clear, then Set), which the
CObjectHeapList copy at 0x4D3410 proves; ReallocAndClearData is out of line
at 0x4D2E90; new template instances added to the OFFSET lists.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 00:28:21 +02:00
SatyandClaude Opus 5.5 860511ea4d Gxu: port the font and light TUs
GxuFontMain.cpp (0x6BCD60-0x6BF370), GxuFontUtil.cpp, GxuFontFont.cpp,
GxuFontFace.cpp, GxuFontString.cpp, GxuFontMiscClasses.cpp,
GxuFontTextureCache.cpp and IGxuFontGlyph.cpp, named after the 12340 and
Mac 13682 source file strings; CGxFont moves from Gx to Gxu.
GxuLight.cpp (0x6BB510-0x6BCD60): the light grid behind the GxuLight*
function-pointer table at 0xAD9834.

Gxu links FreeType 2.0.1. Shared additions: GxBufDestroy, GxFormatColor,
CGxVertexPC/PCT, CMath fint_n/fuint_pi/CeilToInt64, C3Vector::SquaredMag,
HASHKEY_DWORD and the template instances in stpl.h.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 00:15:42 +02:00
SatyandClaude Opus 5.5 4f79f0867f FrameScript: port the FrameScript TU (0x816790-0x81B714)
- FrameScript.cpp/.h: Lua state, execute/compile/load, variables, text,
  sprintf/print/pack, events and CPU usage
- FrameScript_Object.cpp/.h: FrameScript_Object and its methods
- FrameScript_Scripts.cpp: the _G extras (strtrim, securecall, date, ...),
  static, table s_extraFuncs at the end
- Types.h: FRAMESCRIPT_GENDER, PLURAL_RULE (best-guess value names)
- CScriptObject moved from _Triage to Frame; stale FrameScript triage
  headers removed
- Win32: _USE_32BIT_TIME_T like the original build
- MD5Update declared in Storm MD5.h (0x779A30, not ported)

All 87 definitions verified against 12340 (58 pass, 29 reviewed suspects).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-26 21:48:32 +02:00
SatyandClaude Opus 5.5 d339a940b4 ConsoleBase: port ConsoleVar.cpp and ConsoleCommand.cpp (52 definitions verified)
- CVar (struct per 12340 RTTI; value callback is __cdecl), its console commands,
  CVarArrayWrapper/CVarIntListWrapper; command table, help, parse, complete.
- Engine-side console interface in IConsole.h (ConsoleWrite/Printf/CommandExecute...),
  implemented by WoW's ConsoleClient later (tracked in open_items); COLOR_T/CATEGORY in
  ConsoleBase/Types.h.
- stpl.h: TSList::Prev, TSHashTable::Next/DeleteNode, HASHKEY_CONSTSTRI.
- 27 suspects reviewed against 12340 listings; fixes: read-only message prints the
  cvar name, int-list decode reads bytes unsigned.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-26 19:20:38 +02:00
SatyandClaude Opus 5.5 2ad217cc0b Storm: SErrDisplayAppFatal* are not [[noreturn]]
12340 falls through after every call; the attribute made modern MSVC move the fatal paths
to cold blocks. Harness before/after: WowClientDB_Common::Load 0.53 -> 0.99 pass, 4 more
shapes up, none worse.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-26 17:18:10 +02:00
SatyandClaude Opus 5.5 509a43e7cb SoundEngine: port 12340 SoundEngine.cpp (SE2), 146 definitions verified
SESoundInternal + file/memory/chat subclasses, SESound handle, wave cache,
channel groups, drivers, capture, Init/InitCapture/ShutDown. SoundCache.h
declared only. Adds CRndSeed::SetSeed, IsNaN, SFile::SetReadFatal,
FMOD_ErrorString OFFSET; SoundEngine becomes a static library. Note re/305.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-26 10:23:03 +02:00
SatyandClaude Opus 5.5 00b85f5ae2 stpl.h: TSList::NewNode stamp manual after template instance pairing fix
Re-read against its own CMipBitsCache instance (0x4B6E40); shape-only
difference.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-26 09:16:41 +02:00
SatyandClaude Opus 5.5 e866c1c2ad Texture T2: AsyncFile module, async texture handlers, GxTex cache update
- AsyncFile reader: queues, thread, alloc/free/cancel, priority queueing,
  poll/wait/wait-all, destroy; CAsyncQueue/CAsyncThread types and statics
- Texture: AsyncTexture success/failure/handler/status, TextureUpdate,
  TextureCacheUpdate, ResolveMipLevel
- SFile::IsStreamingMode, Streaming::IsStreamingMode, SFile::GetActualFileName,
  SysMsgAdd (both), empty SFile::SetFilePriority (folds into 0x47ADD0)
- CAsyncObject field types from users (SFileImpl*, uint8_t priority)
- GxTest --textures-async: runs the real async path

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-25 20:46:48 +02:00
SatyandClaude Opus 5.5 5a2919f977 Texture T1: CTexture, create path, GxTex cache, atlas, BLP upload
Ports 37 Texture.cpp functions from TextureCreate to the filled D3D
texture (cache, solid textures, PumpBlpTextureAsync, TextureAllocGxTex/
FreeGxTex reuse buckets, atlas, TextureGetGxTex, TextureInitialize),
GxuUpdateSingleColorTexture, GxTexReusable(CGxTex*), CGxTexFlags==,
CBLPFile ctor/dtor. Fixes CStatus Add overload order (vtable slots).
GxTest --textures reads back D3D levels; all match 12340 (note 298).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-25 19:59:26 +02:00
SatyandClaude Opus 5.5 68f8dc745a Os O4b: OsVersionHash and OsURLDownload
Port the relocation-neutral PE image hash behind IOsVersionChecksum and
the async WinINet downloader. Os links wininet; storm.h gains the
scalar new/delete(size, file, line).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-25 16:21:33 +02:00
SatyandClaude Opus 5.5 21cef061ce Event pass 2: Storm RW lock, instance id table, scheduler
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-25 04:52:29 +02:00
SatyandClaude Opus 5.5 5f21409837 Event pass 1: message queue, timers, priority queue
Rebuild Event headers from the binary (EvtContext layout, EVENTID,
EVENT_DATA_*, cdecl handlers), IEvtQueue*, IEvtTimer*,
CSBasePriorityQueue, TExtraInstanceRecycler, TSList::Combine.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-25 04:00:37 +02:00
SatyandClaude Opus 5.5 4898dcc94a Gx pass 7: pools, shader hash table, CGxDevice ctor/dtor
Port BufCreate, PoolCreate/PoolDestroy, DeviceCreatePools,
DeviceCreateStreamBufs, IShaderLoad, ShaderCreate, ShaderDestroy,
CGxShader::Load/dtor, CGxPool dtor, CGxDevice ctor/dtor and
OsGetProcessorFeatures. CGxBuf gets its own header/source.
CGxPool/CGxBuf/CGxAppRenderState/CGxPushedRenderState become structs
(RTTI .?AU). HASHKEY_STRI derives from HASHKEY_STR. m_shaderList is
TSHashTable<CGxShader, HASHKEY_STRI>[6]; list offsets via offsetof.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-25 00:14:22 +02:00
SatyandClaude Opus 5.5 f047b71145 Gx pass 3: Gx* wrappers, small CGxDevice members, portable Storm error constants
- Gx wrappers: GxXform*, GxBuf*, GxDraw, GxDrawLockedElements, GxSceneClear, GxTexDestroy/Copy/Reusable,
  GxQueryCreate/Destroy, max FPS, GxGetBlitFormat, GxHasContext, GxIsWindowVisible, GxMasterEnable
- CGxDevice: DeviceApi, CapsHasContext, CapsIsWindowVisible, MasterEnable, DeviceClearScreenShot, XformPush
- CGxTexParms, EGxXform, BlitFormat
- STORM_ERROR_SUCCESS/NOT_ENOUGH_MEMORY/INVALID_PARAMETER replace Win32 ERROR_* in general files;
  windows.h removed from them

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-24 22:45:13 +02:00
SatyandClaude Opus 5.5 299af1e188 Add the Win32 platform files missing from 8035c4b
.gitignore ignored every Win32/ folder (Visual Studio build output
pattern), so files created in the new source Win32/ folders were left
out of the platform-folder commit while the code they took was removed
from the generic files. Source Win32/ folders are now un-ignored.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-24 16:52:37 +02:00
SatyandClaude Opus 5.5 953240f57c BlizzardCore Log, SComp review, Win32/Win64 platform folders
System/Log (16 functions) and Thread::WaitForever. Storm SComp review:
ImaAdpcmCompress size compares are signed as in 12340. AllocSTL_raw and
CCritSect members marked INLINED; SSyncObject ctor out of the header.

Platform layout: Windows API code lives in <dir>/Win32/ (whole file in
#if WOWDECOMP_ARCH_32) with full copies in <dir>/Win64/ (ARCH_64);
no _M_X64 blocks inside files. Former W32/ and *_Win32.cpp files moved,
their headers are generic now. Win32 API calls moved out of generic
File/Log/Thread/Unicode/SCmd files; Storm SErr/SLog/SReg/SMsg moved
whole. CODING_RULES section 7, PORTING_64BIT "Platform folders".

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-24 16:16:55 +02:00
SatyandClaude Opus 5.5 59473357fa BlizzardCore: System/File pass 3; statics at top of file
PassThrough, stream_read, the (unused) throttle layer, and
RemoveDirectoryAndContents with its callback and state. Streaming::
IsStreamedFile declared only. Statics moved to the top of File.cpp,
SErr.cpp and SComp.cpp (SComp compress helpers declared in SComp.h).
CODING_RULES: statics at the top, file-local static helpers below them.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-24 15:19:19 +02:00
SatyandClaude Opus 5.5 9ae1f95463 Storm: client operator new, delete, delete[] at their 12340 addresses
Add operator new and give operator delete/delete[] the binary's null
check. All three verified against the binary.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-24 05:26:27 +02:00
SatyandClaude Opus 5.5 147177c448 Base: CBitArray; Storm: operator delete[]
Port CBitArray (Mac 4.0.1 names and field names from asserts) and add the
client operator delete[] that 12340 inlines everywhere.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-24 04:23:35 +02:00
SatyandClaude Opus 5.5 cccfd26213 Move Storm to Engine/Source/Storm; SFile.cpp to BlizzardCore
Storm moves under Engine/Source with its inner layout unchanged. All
includes use Engine/Source/Storm/..., Storm's include guards follow the
new path, and the top-level CMakeLists adds Engine/Source/Storm.
SFile.cpp (SFile::CreateOverlapped/DestroyOverlapped) moves to
Engine/Source/BlizzardCore.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-24 03:33:51 +02:00