- luaB_getfenv: look up __environment metafield like 12340
- DSPSfxReverb::setParameterInternal: set mUpdate for REFLECTIONSLEVEL and REVERBLEVEL
- CGGameUI::DestroyTotem, Script_SetTotem: test the totem GUID, not unk_0004
- Missing return 0 after luaL_error in script functions
- OFFSET tags of template instances carry their instance type: [0xXXXXXX<Type>]
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Batch 1: weather templates, client console commands, loading screen paths,
glue script events, AddOns/AccountData/Battlenet getters, simple camera and
camera vehicle offsets, Warden module path, BLL loader, FFX effects, Grunt
and GruntLogin matrix/file handlers, CGlueMgr char customize/faction change/
kick reason.
semdiff: 251 Lua script functions called luaL_error without the return 0 that
12340 has after every call site (each confirmed per call site in the binary).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Ports the stand-ins hit since run 85 and the follow-up script batches:
RaidInfo, PartyFrame, BarberShop, ArenaTeamInfo, SkillInfo, InputControl,
petitions/guild registrar, ItemText, Tutorial, ContainerFrame, QuestLog,
ActionBar, ClassTrainer, UIMacros, GuildBank, AuctionHouse and Commentator.
Fixes found on the way: AuctionHouse sell items are a fixed inline array
(IsItemForSell read garbage), GetSellItem returns the container GUID,
Commentator instance key is read/written as u32/u16/u8 and skirmish
commands send a u32 flag, GetArenaMember returns uint64 in edx:eax.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- Port hit-order Lua stand-ins (unit tokens, tooltips, combat log filters and
current entry, bags/containers, quest POI, minimap, titles, world states,
trade, group roles, runes, mirror timers, saved-variable registration, Quit)
- LoadAddOn: real add-on loading (Blizzard_CombatLog etc. now load)
- CombatLogEntry::PushEvent: COMBAT_LOG_EVENT arguments
- World map chain: SetMapToCurrentZone, SetMap, GetWorldPosition, landmarks,
overlays, highlight, zones, dungeon levels, player position
- OpenArchives: locale index was off by one (enUS read the koKR DBC slot,
leaving zone/map names empty)
- Zone/area sound chain, invisible units (spline mode read size), raid/bag
crash fixes, stand-in console, waystone icon for all executables
- Coding-rule cleanups: statics/includes at the top, event enums, Lua
_Scripts layout
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Ports verified against 12340 that take the x64 client from character
login to a playable world:
- Camera: SetView/ResetView, motion, free-look facing, tracking, bobs,
liquid bump, world collision; camera Lua scripts
- Input: world frame key/mouse layers, default action, mouselook,
turn/pitch player, TurnOrAction/CameraOrSelectOrMove scripts
- Movement: legal facing range, turn/pitch/raw facing events, transport
status, move spline copy, unit update info, smooth facing, anim end
- Units: component and extended display init, model fade/scale,
entity sort table, RenderEntitys, split-body culling
- Interiors: WMO group bounds, BSP segment link query, face linking,
interior lighting
- Collision: CMap::QueryFacets closure with frustum queries and NDCClip
- UI: game UI mouse filters, client control state, faction standing
packet, many *_Scripts.cpp Lua tables; name generator dictionary fix
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- CGObject_C base, CEffect, CObjectEffect/CObjectEffectManager effect states
- Unit, Player, Item/Container/Bag, Corpse, DynamicObject, GameObject and
all GameObject type classes (vtables matched slot by slot), Movement,
MovementShared, Missile, Vehicle/Passenger/Camera, combat log, caches
- Client object manager (0x4D3100-0x4D7880) incl. SMSG_UPDATE_OBJECT,
SMSG_COMPRESSED_UPDATE_OBJECT, SMSG_DESTROY_OBJECT; type ctors/PostInit
- CGGameUI::CanPerformAction and the ready part of CGInputControl
- Layouts named from descriptor fields and code; CM2Model 0x134 matrix,
CClientObjCreate tail, CGUnit_C/CGPlayer_C sizes 0x1008/0x1958
- WOWGUID struct replaces the IDB's WGUID low/high pair and guid uint64_t;
SmartGUID derives from it; member functions returning a guid keep
uint64_t (MSVC returns class types from members via hidden pointer);
structs with 4-aligned guids in 12340 use pack(4)
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- Grunt login ported end to end (SRP6 challenge/proof, version checksum,
realm list) and tested against a live server: authenticates, connects to
the world server (auth session with proof-of-work, header crypt), receives
the character list and shows character select
- Glue: realm list UI, character select (list, models, scripts), character
create screen + name generator, delete/rename/decline, Enter World up to
the loading screen; loading screen drawing and progress
- AccountData (times, update, upload/download), BannedAddOns, addon scan and
addon info, client cache version, tutorial flags
- Shutdown path at login state: world/map/liquid/weather teardown, NetClient,
ComSat, streaming stop; Logitech LCD no-device path in Ui/UILCD/Windows
- PCRE 5.0 vendored (core stock; chartables and the posix layer from 12340),
ValidateName
- Fixes: TSGrowableArray::CalcChunkSize clamps to >= 8 (crash on char list),
CWorldScene liquid renderer allocation, CMapFootprintTexture element ctor,
pointer render states on x64, CFrustum/CWFrustum layout, M2 draw callback
arguments, 37 class/struct forward-declaration mismatches
- IDB name sync (1217 names), verify aliases, harness large-element
instantiation
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Core (CSimpleFrame + Lua, CSimpleTop/CFrameStrata/CSimpleRender/
CRenderBatch, CSimpleRegion/CBackdropGenerator/CScriptRegion), animation,
text (FontString/Font/Fontable), texture and model, buttons, EditBox,
MessageFrame/MessageScrollFrame, MovieFrame/ColorSelect/StatusBar,
Slider/ScrollFrame/HTML/HyperlinkedFrame, all Lua method tables and
RegisterScriptMethods. Layouts, vtables and sizes rebuilt from the
12340 ctors, vtables and allocator initializers; CScriptObject vtable
slots 5/6 fixed; CSimpleFontedFrame is a real secondary base. Lua error
paths return after luaL_error as in 12340 (209 sites; 5 fall through).
Binary quirks kept and documented in docs/.
Supporting additions: Event key/char/ime/focus/size event headers,
Scrn/Scrn.h (ScrnLayerCreate), DivxDecoder import declarations,
C2Vector/CRect helpers, CM2Light dtor, OsInputEnableSecureMode, stpl.h
instance addresses, FrameXML LoadXML_AnimGroup/Create_SimpleMovieFrame.
Engine->WoW includes where 12340 calls directly: CSimpleModelFFX,
StringToMouseButton, GetDeclinedWord, EmblemTextureUpdate.
Also drops stale VERIFY stamps found invalid by the harness recheck.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
272 definitions, 111 pass and 161 approved with per-function reasons,
0 fail. CCharacterComponent and ComponentUtils started from the
thunderbrew port and were checked against 12340: adds the threading and
compression paths (CComponentRequest, CComponentMipBits, SSE and scalar
DXT1 compressors), static cdecl helpers, bool SetRandom*, signed prefs
modulo, fixed main/off-hand sheath links. CLightning/CLightningManager
moved here from Services (Common\Lightning.cpp); SetCount fixes the
never-filled joint arrays, alpha rounds via fint_. ItemDisplayInfoRec
ctor carries the folded GetRow OFFSET; 0x4F1650 joins the stpl.h list.
Stand-in declarations in World.h, ComponentData.h and Player_C.h.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
MD5Init/Transform/Update/Final (0x779340-0x779AE0), SCrcBuffer/SCrcCompute
(0x779BA0, table 0xADE9A8), the Storm::IOFileUnit family (0x779C30-0x77A530,
Win32/Win64) and TSExportTableSyncReuse's deleting destructor, plus new
template instances in the stpl.h OFFSET lists (from the Storm, Tempest,
Os, SoundInterface and Frame work).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
HandleCompare (0x47BF20): the ICF-folded 4-byte handle difference that the
M2 scene sorts, CSimpleTexture and CDetailDoodadInst call. ~TRefCnt now
names its scalar deleting destructor (0x480E40), ~CDataRecycler adds
0x95CE00, and TSHashObject gets its destructor (0x47C560, the HASHKEY_STR
instance). Event is 88/88, Base 122/123 (the s_callbackRegAllocator atexit
thunk stays compiler-generated).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
XMLTree.cpp (0x8145B0-0x814E40, XMLTree_GetRoot at 0x8BE770), FrameXML.cpp
(0x812530-0x8145A3) and LoadXML.cpp (0x814E40-0x816767, name guessed: no
__FILE__ string). LoadXML_AnimGroup and Create_SimpleMovieFrame stay
declared until their Frame classes exist.
XMLNode allocates from the CDataAllocator at 0xD3F718; CScriptRegion derives
from CScriptObject and CLayoutFrame (second vtable at +0x20); the attribute
array element is CXMLAttribute. Expat.h declares the expat API by hand until
expat is vendored.
Shared additions: Frame enums (FRAME_STRATA, ORIENTATION, SimpleAnim*,
ANCHORPOINT renamed FRAMEPOINT), Frame class vtable slots/constructors/
allocators and four shell classes, EGxBlend, MD5_CTX, one stpl.h instance.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
ObjectAlloc.cpp (0x4D2AA0-0x4D36C0) and HeapUsage.cpp (0x4D2780-0x4D2AA0).
CObjectHeap moves from _Triage to IObjectAlloc.h, where 12340's inline
destructor puts it (IObjectAlloc.h line 30 in the SMemFree calls).
stpl.h: TSFixedArray gets its copy constructor (clear, then Set), which the
CObjectHeapList copy at 0x4D3410 proves; ReallocAndClearData is out of line
at 0x4D2E90; new template instances added to the OFFSET lists.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
GxuFontMain.cpp (0x6BCD60-0x6BF370), GxuFontUtil.cpp, GxuFontFont.cpp,
GxuFontFace.cpp, GxuFontString.cpp, GxuFontMiscClasses.cpp,
GxuFontTextureCache.cpp and IGxuFontGlyph.cpp, named after the 12340 and
Mac 13682 source file strings; CGxFont moves from Gx to Gxu.
GxuLight.cpp (0x6BB510-0x6BCD60): the light grid behind the GxuLight*
function-pointer table at 0xAD9834.
Gxu links FreeType 2.0.1. Shared additions: GxBufDestroy, GxFormatColor,
CGxVertexPC/PCT, CMath fint_n/fuint_pi/CeilToInt64, C3Vector::SquaredMag,
HASHKEY_DWORD and the template instances in stpl.h.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- FrameScript.cpp/.h: Lua state, execute/compile/load, variables, text,
sprintf/print/pack, events and CPU usage
- FrameScript_Object.cpp/.h: FrameScript_Object and its methods
- FrameScript_Scripts.cpp: the _G extras (strtrim, securecall, date, ...),
static, table s_extraFuncs at the end
- Types.h: FRAMESCRIPT_GENDER, PLURAL_RULE (best-guess value names)
- CScriptObject moved from _Triage to Frame; stale FrameScript triage
headers removed
- Win32: _USE_32BIT_TIME_T like the original build
- MD5Update declared in Storm MD5.h (0x779A30, not ported)
All 87 definitions verified against 12340 (58 pass, 29 reviewed suspects).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- CVar (struct per 12340 RTTI; value callback is __cdecl), its console commands,
CVarArrayWrapper/CVarIntListWrapper; command table, help, parse, complete.
- Engine-side console interface in IConsole.h (ConsoleWrite/Printf/CommandExecute...),
implemented by WoW's ConsoleClient later (tracked in open_items); COLOR_T/CATEGORY in
ConsoleBase/Types.h.
- stpl.h: TSList::Prev, TSHashTable::Next/DeleteNode, HASHKEY_CONSTSTRI.
- 27 suspects reviewed against 12340 listings; fixes: read-only message prints the
cvar name, int-list decode reads bytes unsigned.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
12340 falls through after every call; the attribute made modern MSVC move the fatal paths
to cold blocks. Harness before/after: WowClientDB_Common::Load 0.53 -> 0.99 pass, 4 more
shapes up, none worse.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Port the relocation-neutral PE image hash behind IOsVersionChecksum and
the async WinINet downloader. Os links wininet; storm.h gains the
scalar new/delete(size, file, line).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Port BufCreate, PoolCreate/PoolDestroy, DeviceCreatePools,
DeviceCreateStreamBufs, IShaderLoad, ShaderCreate, ShaderDestroy,
CGxShader::Load/dtor, CGxPool dtor, CGxDevice ctor/dtor and
OsGetProcessorFeatures. CGxBuf gets its own header/source.
CGxPool/CGxBuf/CGxAppRenderState/CGxPushedRenderState become structs
(RTTI .?AU). HASHKEY_STRI derives from HASHKEY_STR. m_shaderList is
TSHashTable<CGxShader, HASHKEY_STRI>[6]; list offsets via offsetof.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
.gitignore ignored every Win32/ folder (Visual Studio build output
pattern), so files created in the new source Win32/ folders were left
out of the platform-folder commit while the code they took was removed
from the generic files. Source Win32/ folders are now un-ignored.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
System/Log (16 functions) and Thread::WaitForever. Storm SComp review:
ImaAdpcmCompress size compares are signed as in 12340. AllocSTL_raw and
CCritSect members marked INLINED; SSyncObject ctor out of the header.
Platform layout: Windows API code lives in <dir>/Win32/ (whole file in
#if WOWDECOMP_ARCH_32) with full copies in <dir>/Win64/ (ARCH_64);
no _M_X64 blocks inside files. Former W32/ and *_Win32.cpp files moved,
their headers are generic now. Win32 API calls moved out of generic
File/Log/Thread/Unicode/SCmd files; Storm SErr/SLog/SReg/SMsg moved
whole. CODING_RULES section 7, PORTING_64BIT "Platform folders".
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
PassThrough, stream_read, the (unused) throttle layer, and
RemoveDirectoryAndContents with its callback and state. Streaming::
IsStreamedFile declared only. Statics moved to the top of File.cpp,
SErr.cpp and SComp.cpp (SComp compress helpers declared in SComp.h).
CODING_RULES: statics at the top, file-local static helpers below them.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Add operator new and give operator delete/delete[] the binary's null
check. All three verified against the binary.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Port CBitArray (Mac 4.0.1 names and field names from asserts) and add the
client operator delete[] that 12340 inlines everywhere.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Storm moves under Engine/Source with its inner layout unchanged. All
includes use Engine/Source/Storm/..., Storm's include guards follow the
new path, and the top-level CMakeLists adds Engine/Source/Storm.
SFile.cpp (SFile::CreateOverlapped/DestroyOverlapped) moves to
Engine/Source/BlizzardCore.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>