26 Commits
Author SHA1 Message Date
SatyandClaude Opus 5.5 dfae6719b7 Naming pass: 65 functions, 103 statics, 63 fields named from Mac symbols and behaviour
Evidence and confidence per rename in re/notes/310_naming_pass.md.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-04 09:27:29 +02:00
SatyandClaude Opus 5.5 82879a879d Port the last non-anti-cheat functions: ServerLink, PetAction, emitter params
- Grunt::ServerLink: all CMD_GRUNT_* handlers, send helpers, features/strings, command table 0xB24D70,
  s_localeIds 0xAD3004, Pending::Remove (dead server-side link, docs/0x008CE200.md); ServerLink.h stub removed
- PetAction type for CGPetInfo::m_actions / pet spell actions / cursor pet action, SetAutocast 0x5D32F0
- CParticleEmitter2 fields 0x98-0x11F moved into CParticleEmitter2::Params (ctor 0x979250)
- fixed16(float), C3Vector::FlushDenormals, CGxuLightQueue + static 0xC7C074, CAaSphere(), CMapLowDetail(),
  C2Vector()/C4Plane() out of line, SpellHistory dtor, CGDynamicObject_C GetScale/GetRawFacing
- DB record operator= (PetNameCache, CGPetition, DanceCache): fixes the shallow-copy double free in AddItem
- ClientSetTimer(delay, handler, param) with its five callers, IOMd5Unit::Create without container,
  CDataStore::GetByte / Get(int32_t&), WDataStore::GetHeaderSpace, TSHashTable::Head, TSList::IsEmpty
- CameraTurnPlayer calls CVehicleCamera_C::IsTransitioningFacing 0x5FAA10 (was IsHierarchyChasingFacing)
- OFFSET additions: TSHashTable::Unlink, TInstanceId dtor, DBCACHEHASH dtor (+ ItemNameCache_C dtor),
  CDataStoreCache ctor, BitUnpacker/RunningAverageCalculator deleting dtors, CGTooltip::GetObjectType

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-04 08:10:06 +02:00
SatyandClaude Opus 5.5 27de58d41e Dissolve _Triage into the source tree
- move triage code to the folders of its binary neighbours (AreaList,
  movement packet types, CClientObjCreate, CWOWClientStatus, SHA1,
  Clamp, EmergencyMem, MippedImg, WowMouse, ...)
- merge HMAC template, OnGxRestartClearWorld and TIMESTAMPSTRUCT into
  their natural headers
- delete superseded duplicates and unk-only placeholders
- tools: drop Triage library, fix Streaming stub signatures, remove
  stubs now provided by BlizzardCore, MapViewer s_liquidTypeId

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 18:09:53 +02:00
SatyandClaude Opus 5.5 d9e4c5f644 Fix signed/unsigned count types and KB luaL_error returns found by the harness
Counts the binary converts as unsigned (fild + jge + fadd 2^32) or signed
(sar, plain fild) now use the matching types; KB count scripts return
luaL_error's result like the binary.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 16:40:46 +02:00
SatyandClaude Opus 5.5 393769ff36 Port single-missing-function modules
LeaveWorld handlers, game object type checks, corpse/dynamic object
virtuals, loot/voice/macro helpers, declined words, ProcessAgreement,
ObjectCreateStaticEx, FFX death/fog-seed/nether-blur passes, software
snow renderer, streaming decal, QuestCache copy, trajectory encoder and
deleting destructor tags. Fixes the missing CMapStaticEntity destructor
model release.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 14:39:43 +02:00
SatyandClaude Opus 5.5 46b5adf64f Port FriendList, Player_C, Unit_C and GameObject_C modules
- FriendList: remaining methods and 28 Lua scripts, FriendListModuleLoaded
- Player_C: remaining functions incl. click-to-move (ClickToMove, CTMFace,
  CTMClickTerrain, CTMAttackUnit, CTMInteractGO), dance, virtual items,
  sound and skill-rank overrides
- Unit_C: tracking (HandleTracking and helpers, SetTrackingTarget/Direction),
  selection circles, spell visual overrides, mirror image, flag-2 changes,
  scale update, missile trajectory (ComputeMissileTrajectory,
  SendFinalMissileTrajectoryUpdate, StartMissileTrajectoryTargeting) and
  CMissileCollision (Init, unit ranking, hit spheres)
- GameObject_C: IsLocked, UseObject, TypeBase CanUseNow/CheckRange/Use/
  CanChangeCursor, Ritual and MeetingStone types, virtual overrides,
  property helpers named from the binary's property table
- Dependencies: ProjectTex::Render2d, weapon trail chain (SWING,
  WTOBJECT::SetDrawTrail), GxSwizzleColor, CAaBox::Expand/Center,
  CVehicle_C::PlayBoneAnimOrFallback, RuneInfo/PetitionInfo/ClassTrainer/
  ComSat helpers, CalendarEventTables ctor
- DBCache: InvalidateIntKey, RetryItem, SetTemporary, ~DBCACHEHASH
- Template instances, deleting dtors and TSHashTable/WowClientDB instances
  recorded in their OFFSET lists

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 12:07:58 +02:00
SatyandClaude Opus 5.5 4a571e727c World port: WMO water, fog, area updates, purge chain, detail doodads
- Barriers, shadow/portal queries, underwater selection, hit testing
- Interior water: PolyClipper, ClipGroupGeometry, liquid index fix
- Area updates, barrier updates, purge/free chain for areas, chunks,
  doodad and map object defs, detail doodad update list
- Water ripples, terrain pixel shader path, liquid shader toggles
- Detail doodads: creation per chunk, pools, batching, vertex/index
  fill, shader and fixed-function render state, RenderDetailDoodads
  (trailing occluder/debug draws still to port), CMapChunk::SelectLights
- DayNight moved to WoW/Source/WorldClient
- MapViewer: fog, WMO water, detail doodads; diagnostics removed

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-29 07:43:15 +02:00
SatyandClaude Opus 5.5 2e418f9e08 Client bring-up: glue screen, EULA/TOS, shutdown chain, LCD, x64 fixes
- Stand-in client reaches the glue screens (intro movie, EULA/TOS accept,
  login screen) at 16:9; stand-ins are report-only on x64
- Ports on the startup/idle path: GlueScriptEvents/CharacterSelection/
  CharacterCreation/RealmList/AccountMsg/VideoOptions _Scripts, CGlueMgr
  (Initialize/Resume/Idle/Accept*/Shutdown), ClientServices, NetClient/
  WowConnection, DBCache + instances, WorldParam/World/Map/Liquid/Weather/
  shadow, InputControl, Scrn, ConsoleClient, SysMessage, LoadingScreen,
  SystemRegisterFunctions, CGameTime, Screen::GetAspectRatio
- Shutdown chain: BeginCloseGame, DestroyEngineCallback, DBCache save/
  destroy, SpellVisuals/Effect/World/Glue teardown
- Logitech LCD no-device path in Ui/UILCD/Windows (Windows-only dir);
  lgLcd is a stub library in ThirdParty/lgLcd
- CVar and console commands split into <Module>_CVar.cpp / _Console.cpp
- DivxDecoder.dll (Win32, original) and XvidDecoder.dll (x64, port with
  vendored xvidcore) both copied to the build folder
- Warden: Win32 faithful port, Win64 stub
- x64 fixes: lua_newstate gcusage/gctime init, pointer render states reset
  with nullptr, g_rndSeed defined
- 37 class/struct forward-declaration mismatches fixed (false stand-ins)

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 21:47:34 +02:00
SatyandClaude Opus 5.5 6ee0c14d69 Verify remaining functions; SI2::ChaosModeUpdate; SE2::StopAllSounds arg
ChaosModeUpdate (0x4C74F0) reordered to the binary's switch case layout
and case 15 written as 8 statements; verified. SE2::StopAllSounds takes
the unused int every 12340 caller pushes. Approval stamps for the
functions unblocked by the IDB splits (Button/Checkbox IsA, Checkbox
dtor, CSimpleFrame::NotifyDelayedLoad, CGxDeviceD3d9Ex ctor,
CM2Cache dtor) and for the re-reviewed IsSequenceLoaded,
OsGuiMessageBox, TexturePickAlternateFilename, three FMOD ctors and
luaG_concaterror.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 15:51:40 +02:00
SatyandClaude Opus 5.5 34770ee7ab Frame: port Engine/Frame (waves 1-4), 1667 of 1669 functions
Core (CSimpleFrame + Lua, CSimpleTop/CFrameStrata/CSimpleRender/
CRenderBatch, CSimpleRegion/CBackdropGenerator/CScriptRegion), animation,
text (FontString/Font/Fontable), texture and model, buttons, EditBox,
MessageFrame/MessageScrollFrame, MovieFrame/ColorSelect/StatusBar,
Slider/ScrollFrame/HTML/HyperlinkedFrame, all Lua method tables and
RegisterScriptMethods. Layouts, vtables and sizes rebuilt from the
12340 ctors, vtables and allocator initializers; CScriptObject vtable
slots 5/6 fixed; CSimpleFontedFrame is a real secondary base. Lua error
paths return after luaL_error as in 12340 (209 sites; 5 fall through).
Binary quirks kept and documented in docs/.

Supporting additions: Event key/char/ime/focus/size event headers,
Scrn/Scrn.h (ScrnLayerCreate), DivxDecoder import declarations,
C2Vector/CRect helpers, CM2Light dtor, OsInputEnableSecureMode, stpl.h
instance addresses, FrameXML LoadXML_AnimGroup/Create_SimpleMovieFrame.
Engine->WoW includes where 12340 calls directly: CSimpleModelFFX,
StringToMouseButton, GetDeclinedWord, EmblemTextureUpdate.

Also drops stale VERIFY stamps found invalid by the harness recheck.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 15:32:18 +02:00
SatyandClaude Opus 5.5 e2038cdec5 Services: port Profile, TextBlock, Camera, particles and ribbons
Profile, TextBlock, Camera (+CameraInt.h), ParticleSystem2 (emitters,
track sampling, sort queue), RibbonEmitter, GfxSingletonManager managers
and the v1 CParticleEmitter destructor. All pass or approved with
explained diffs; 0 fails. Callee-cleanup helpers declared __stdcall,
float->int paths use CMath::fint_ (binary uses fistp). CLightning fields
named only; it is WoW/Common code. _Triage CAngle removed, Camera.h
repointed to CameraInt.h. CM2SceneRender Render calls cast for the new
signature. Services links freetype for the Gxu font headers.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 03:08:52 +02:00
SatyandClaude Opus 5.5 4921b0d194 Tools: add M2Viewer, a spinning-M2 render test
Tools/M2Viewer opens a window, creates the D3D9 Gx device, loads an M2 from
bin/Win/Data through M2Cache/CM2Scene and spins it; Win32 and x64. Unported
engine functions it links but never reaches map to aborting stand-ins.

Engine pieces it needed: CGxDeviceD3d::XformSetProjection, CGxDevice::
XformSetViewport, GxXformSetViewport, CParticleEmitter2::Init and the
ParticleSystemManager projection statics. M2Scene.h now declares
s_localLighting/s_blendModes (they could not link), and the duplicate
particle emitter classes left in _Triage are removed.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 00:57:44 +02:00
SatyandClaude Opus 5.5 2203210f2b Model2: port the Model2 TUs
M2Model.cpp, M2Shared.cpp, M2Scene.cpp, CM2SceneRender.cpp, M2Light.cpp,
M2Cache.cpp and the new M2Data.cpp/.h (0x81C000-0x834900). Only the
std::sort internals for CModelBatch stay unported.

AnimationData lookups in ResolveSequenceFallback/SequenceFallbackById use
g_animationDataDB directly: 12340 inlines its record loads into M2Model.cpp.

Shared additions: CParticleEmitter2 vtable order and the plane/sphere/spline
emitters, CRibbonMat, Services/Camera.h, Base/SIMD, Base/ObjectAlloc.h (the
engine-side ObjectAlloc interface), CFacet, CAaRect, CiRange, the C44Matrix
16-float constructor and CMath fequal/fnotequal/FloatToInt64.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 00:28:21 +02:00
SatyandClaude Opus 5.5 5f720dfc64 fmodex completion pass; CMake integration; vsnprintf fixes
- OFFSETs/reconstruction from 12340: System::getDriverName,
  setRecordDriver, getRecordDriverName; Sound/SoundI/Codec::readyForRelease
  (new, non-virtual); SoundI::getNumTags; OutputWASAPI::getDriverName;
  OutputWavWriter::getHandleCallback (folded with WASAPI's
  recordGetPositionCallback); LocalCriticalSection::enter; ASIO stopCallback.
- fmodex in the wowdecomp CMake build (Win32 + x64, NASM on Win32,
  WIN32_LEAN_AND_MEAN/NOMINMAX removed for SoundEngine, LoadOAL.cpp);
  x64 portability casts; libFLAC fseeko/ftello -> fseek/ftell on MSVC.
- CGxDevice::Log(va_list), SysMsgPrintf, SysMsgVPrintf: _vsnprintf as in
  12340 (were C99 vsnprintf; hidden by a harness overload-pairing bug).
- VERIFY stamps.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-26 09:08:31 +02:00
SatyandClaude Opus 5.5 82ab861221 ModelBlob: World\Model.blob bounding boxes
- CModelBlob (Load, HashBlobEntry, Query, destructor), SEntry, CHashEntry,
  HASHKEY_MODELBLOBFILE, s_modelBlob/s_modelBlobHT
- ModelBlobLoad, ModelBlobQuery, ModelBlobDestroy
- Drop windows.h from ModelBlob.h
- GxTest --modelblob

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-25 21:59:34 +02:00
SatyandClaude Opus 5.5 f493121844 Texture T4: finish Texture.cpp, SysMsg printf
- Settings/accessors: filter mode, anisotropy, cache size, atlas, file
  helpers, ready/loaded/opaque checks, dimensions, ref count
- LoadBlpMips, TextureLoadImage, TextureDestroy, TextureGxCacheClear/Flush,
  TextureNotifyGxRestart, TextureCreate overloads, cache lookup/insert
- SysMsgVPrintf, SysMsgPrintf x2, CAsyncObject::IsPending
- CBLPFile ctor has an out-of-line copy (0x4B58D0)
- GxTest: TextureLoadImage check

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-25 21:49:55 +02:00
SatyandClaude Opus 5.5 fbde2def4e Texture T3: CTgaFile, TGA textures, MipBits cache, texture blobs
- Images/tga: packed TGAHeader/TGAFooter, all 23 CTgaFile methods
- TGA path: LoadTgaMips, LoadPredrawnMips, TextureGenerateMips,
  TextureCalcMipCount, UpdateTgaTexture, CreateTgaTexture, FullShrink
- MipBits cache: CMipBitsCache, TextureAllocMippedImg, TextureFreeMippedImg x2
- CTextureBlob module, UpdateBlobTexture, TextureCreateBlob, Load/UnloadBlob
- SFile::FileExistsEx, Os file constants, C4Pixel moved to BLPFile/Types.h
- GxTest --tga/--blob, BlpTest list

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-25 21:34:16 +02:00
SatyandClaude Opus 5.5 e866c1c2ad Texture T2: AsyncFile module, async texture handlers, GxTex cache update
- AsyncFile reader: queues, thread, alloc/free/cancel, priority queueing,
  poll/wait/wait-all, destroy; CAsyncQueue/CAsyncThread types and statics
- Texture: AsyncTexture success/failure/handler/status, TextureUpdate,
  TextureCacheUpdate, ResolveMipLevel
- SFile::IsStreamingMode, Streaming::IsStreamingMode, SFile::GetActualFileName,
  SysMsgAdd (both), empty SFile::SetFilePriority (folds into 0x47ADD0)
- CAsyncObject field types from users (SFileImpl*, uint8_t priority)
- GxTest --textures-async: runs the real async path

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-25 20:46:48 +02:00
SatyandClaude Opus 5.5 5a2919f977 Texture T1: CTexture, create path, GxTex cache, atlas, BLP upload
Ports 37 Texture.cpp functions from TextureCreate to the filled D3D
texture (cache, solid textures, PumpBlpTextureAsync, TextureAllocGxTex/
FreeGxTex reuse buckets, atlas, TextureGetGxTex, TextureInitialize),
GxuUpdateSingleColorTexture, GxTexReusable(CGxTex*), CGxTexFlags==,
CBLPFile ctor/dtor. Fixes CStatus Add overload order (vtable slots).
GxTest --textures reads back D3D levels; all match 12340 (note 298).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-25 19:59:26 +02:00
SatyandClaude Opus 5.5 6aaed8939a Tempest pass 2: CMath, CRandom, NTempest geometry, CFrustum
- CMath: sqrt_, log2_, exp2_ (+ tables), solvequad_, normalizeangle0to2pi_, normalizeAngleNegPiToPi_; inline fint_ / ftol_round_0_255_
- CImVector::operator= rounds via fint_ (was truncating); Set via ftol_round_0_255_
- CRandom::uint32_ (guessed name) + table; CRndSeed moved to CRandom.h
- NTempest: ray/box, ray/plane, ray/tri (u16/u32), point-in-polygon, 2d box/sphere, segment and polygon distances
- CFrustum (0xE4) with culls, transforms, planes from corners; CWFrustum derives from it
- C3Vector::EAxis; Major/MinorAxis return it

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-24 21:43:28 +02:00
SatyandClaude Opus 5.5 a09c429bd3 Tempest pass 1: readable field names, class-named files, math classes
- Field names from the 12340 type library (x/y/z/w, a0..d3, minY/minX/maxY/maxX, b/t, c/r, n/d, origin/dir)
- Files renamed to match their class; CRay -> C3Ray; C3Segment, CRect, CiRect, C2iVector, C3iVector split out
- MouseEventData, CharacterInfo, M2Bounds moved out of Tempest headers
- 107 functions: C2/C3/C4Vector, C33/C34/C44Matrix, C4Quaternion, C4Plane, CAaBox, CAaSphere, C3Ray, CRect, CiRect, CImVector, NTempest
- 0x4C1C40 is cdecl (q, out): ported as static C44Matrix::FromQuaternion (guessed)

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-24 20:46:51 +02:00
SatyandClaude Opus 5.5 cccfd26213 Move Storm to Engine/Source/Storm; SFile.cpp to BlizzardCore
Storm moves under Engine/Source with its inner layout unchanged. All
includes use Engine/Source/Storm/..., Storm's include guards follow the
new path, and the top-level CMakeLists adds Engine/Source/Storm.
SFile.cpp (SFile::CreateOverlapped/DestroyOverlapped) moves to
Engine/Source/BlizzardCore.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-24 03:33:51 +02:00
SatyandClaude Opus 5.5 37591d61e2 Implement Engine/Source/Base Handle
HandleClose, HandleCreate, HandleDuplicate; HandleDereference inline;
empty HandleInitialize/HandleDestroy (folded). CHandleObject in
Base/Handle.h with its real layout (vtable, m_refcount at +4), which moves
TEXTBLOCK::m_string and FONTHASHOBJ's fields by 4. HOBJECT in Base/Types.h.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-24 03:14:22 +02:00
SatyandClaude Opus 5.5 a19a5df43e Implement Engine/Source/Base Status
CStatus with its 12340 layout (vtable, entry list, highest severity):
GetGlobalStatusObj, Add (both), IsEmpty, GetErrorStr, GetErrorStrLen,
GetErrorStrAlloc, Prepend, ~CStatus; STATUSENTRY destructor and Clear
inline in Status.h. CTexture drops the gap that was the rest of CStatus.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-24 02:56:37 +02:00
SatyandClaude Opus 5.5 ae952861ad Implement Storm classes
Storm template library (TSLink, TSList, TSExplicitList, arrays, TSHashTable,
hash keys) and W32 sync classes (SCritSect, SSyncObject, SEvent, SMutex,
SSemaphore, SThread::SetPriority), written from the binary. Adds storm.h
with the Storm API the templates call. Generated headers updated for the
new homes and the array element types recovered from the binary.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-23 18:54:56 +02:00
Saty 5137298335 Initial commit 2026-09-23 18:24:00 +02:00