- 360 Script_* re-approved: only change since approval is return 0
after luaL_error (semdiff vs binary)
- realm id field renames and TotemInfo m_guid (+0x8) checks re-approved
- CGlueMgr::OnKickReasonMsg passes via InitTokenSeed alias
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- luaB_getfenv: look up __environment metafield like 12340
- DSPSfxReverb::setParameterInternal: set mUpdate for REFLECTIONSLEVEL and REVERBLEVEL
- CGGameUI::DestroyTotem, Script_SetTotem: test the totem GUID, not unk_0004
- Missing return 0 after luaL_error in script functions
- OFFSET tags of template instances carry their instance type: [0xXXXXXX<Type>]
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Batch 1: weather templates, client console commands, loading screen paths,
glue script events, AddOns/AccountData/Battlenet getters, simple camera and
camera vehicle offsets, Warden module path, BLL loader, FFX effects, Grunt
and GruntLogin matrix/file handlers, CGlueMgr char customize/faction change/
kick reason.
semdiff: 251 Lua script functions called luaL_error without the return 0 that
12340 has after every call site (each confirmed per call site in the binary).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Core (CSimpleFrame + Lua, CSimpleTop/CFrameStrata/CSimpleRender/
CRenderBatch, CSimpleRegion/CBackdropGenerator/CScriptRegion), animation,
text (FontString/Font/Fontable), texture and model, buttons, EditBox,
MessageFrame/MessageScrollFrame, MovieFrame/ColorSelect/StatusBar,
Slider/ScrollFrame/HTML/HyperlinkedFrame, all Lua method tables and
RegisterScriptMethods. Layouts, vtables and sizes rebuilt from the
12340 ctors, vtables and allocator initializers; CScriptObject vtable
slots 5/6 fixed; CSimpleFontedFrame is a real secondary base. Lua error
paths return after luaL_error as in 12340 (209 sites; 5 fall through).
Binary quirks kept and documented in docs/.
Supporting additions: Event key/char/ime/focus/size event headers,
Scrn/Scrn.h (ScrnLayerCreate), DivxDecoder import declarations,
C2Vector/CRect helpers, CM2Light dtor, OsInputEnableSecureMode, stpl.h
instance addresses, FrameXML LoadXML_AnimGroup/Create_SimpleMovieFrame.
Engine->WoW includes where 12340 calls directly: CSimpleModelFFX,
StringToMouseButton, GetDeclinedWord, EmblemTextureUpdate.
Also drops stale VERIFY stamps found invalid by the harness recheck.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- FrameScript.cpp/.h: Lua state, execute/compile/load, variables, text,
sprintf/print/pack, events and CPU usage
- FrameScript_Object.cpp/.h: FrameScript_Object and its methods
- FrameScript_Scripts.cpp: the _G extras (strtrim, securecall, date, ...),
static, table s_extraFuncs at the end
- Types.h: FRAMESCRIPT_GENDER, PLURAL_RULE (best-guess value names)
- CScriptObject moved from _Triage to Frame; stale FrameScript triage
headers removed
- Win32: _USE_32BIT_TIME_T like the original build
- MD5Update declared in Storm MD5.h (0x779A30, not ported)
All 87 definitions verified against 12340 (58 pass, 29 reviewed suspects).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Both sit between OsGetPhysicalMemory and IOsParseProcessorFrequency; their statics
(0xD415B8/BC) fill the gap in System.cpp's statics.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
12340 falls through after every call; the attribute made modern MSVC move the fatal paths
to cold blocks. Harness before/after: WowClientDB_Common::Load 0.53 -> 0.99 pass, 4 more
shapes up, none worse.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
All 509 functions of 12340's Lua block (0x84D390-0x863580) carry an
OFFSET and are verified (static evidence; see re/notes/303_lua.md).
- Compiled as C++ with extern "C" API, setjmp/longjmp errors.
- Taint on GC objects and TValues, taint globals, taint event callback,
closure taint in the VM, gctag for new objects.
- Profiler: Profile per closure, luaD_precall_profile,
luaV_execute_profile; GC size/time accounting per tag.
- luaconf: COMPAT_VARARG/MOD/GFIND off, 4-byte max alignment,
MAX_SIZET 0x1000000; removed randomseed/print/dofile/loadfile/load,
no binary chunks.
- UTF-8 string.lower/upper, Blizzard string.format, BOM skip,
raw lua_setglobal, table.removemulti/wipe, externalabort.
- New: lbitlib.c, lmemPool.cpp/.h, FrameScript_InvalidPtrCheck
(Win32/Win64), lua CMake target.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>