- luaB_getfenv: look up __environment metafield like 12340
- DSPSfxReverb::setParameterInternal: set mUpdate for REFLECTIONSLEVEL and REVERBLEVEL
- CGGameUI::DestroyTotem, Script_SetTotem: test the totem GUID, not unk_0004
- Missing return 0 after luaL_error in script functions
- OFFSET tags of template instances carry their instance type: [0xXXXXXX<Type>]
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- Port hit-order Lua stand-ins (unit tokens, tooltips, combat log filters and
current entry, bags/containers, quest POI, minimap, titles, world states,
trade, group roles, runes, mirror timers, saved-variable registration, Quit)
- LoadAddOn: real add-on loading (Blizzard_CombatLog etc. now load)
- CombatLogEntry::PushEvent: COMBAT_LOG_EVENT arguments
- World map chain: SetMapToCurrentZone, SetMap, GetWorldPosition, landmarks,
overlays, highlight, zones, dungeon levels, player position
- OpenArchives: locale index was off by one (enUS read the koKR DBC slot,
leaving zone/map names empty)
- Zone/area sound chain, invisible units (spline mode read size), raid/bag
crash fixes, stand-in console, waystone icon for all executables
- Coding-rule cleanups: statics/includes at the top, event enums, Lua
_Scripts layout
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- Grunt login ported end to end (SRP6 challenge/proof, version checksum,
realm list) and tested against a live server: authenticates, connects to
the world server (auth session with proof-of-work, header crypt), receives
the character list and shows character select
- Glue: realm list UI, character select (list, models, scripts), character
create screen + name generator, delete/rename/decline, Enter World up to
the loading screen; loading screen drawing and progress
- AccountData (times, update, upload/download), BannedAddOns, addon scan and
addon info, client cache version, tutorial flags
- Shutdown path at login state: world/map/liquid/weather teardown, NetClient,
ComSat, streaming stop; Logitech LCD no-device path in Ui/UILCD/Windows
- PCRE 5.0 vendored (core stock; chartables and the posix layer from 12340),
ValidateName
- Fixes: TSGrowableArray::CalcChunkSize clamps to >= 8 (crash on char list),
CWorldScene liquid renderer allocation, CMapFootprintTexture element ctor,
pointer render states on x64, CFrustum/CWFrustum layout, M2 draw callback
arguments, 37 class/struct forward-declaration mismatches
- IDB name sync (1217 names), verify aliases, harness large-element
instantiation
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
ChaosModeUpdate (0x4C74F0) reordered to the binary's switch case layout
and case 15 written as 8 statements; verified. SE2::StopAllSounds takes
the unused int every 12340 caller pushes. Approval stamps for the
functions unblocked by the IDB splits (Button/Checkbox IsA, Checkbox
dtor, CSimpleFrame::NotifyDelayedLoad, CGxDeviceD3d9Ex ctor,
CM2Cache dtor) and for the re-reviewed IsSequenceLoaded,
OsGuiMessageBox, TexturePickAlternateFilename, three FMOD ctors and
luaG_concaterror.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Core (CSimpleFrame + Lua, CSimpleTop/CFrameStrata/CSimpleRender/
CRenderBatch, CSimpleRegion/CBackdropGenerator/CScriptRegion), animation,
text (FontString/Font/Fontable), texture and model, buttons, EditBox,
MessageFrame/MessageScrollFrame, MovieFrame/ColorSelect/StatusBar,
Slider/ScrollFrame/HTML/HyperlinkedFrame, all Lua method tables and
RegisterScriptMethods. Layouts, vtables and sizes rebuilt from the
12340 ctors, vtables and allocator initializers; CScriptObject vtable
slots 5/6 fixed; CSimpleFontedFrame is a real secondary base. Lua error
paths return after luaL_error as in 12340 (209 sites; 5 fall through).
Binary quirks kept and documented in docs/.
Supporting additions: Event key/char/ime/focus/size event headers,
Scrn/Scrn.h (ScrnLayerCreate), DivxDecoder import declarations,
C2Vector/CRect helpers, CM2Light dtor, OsInputEnableSecureMode, stpl.h
instance addresses, FrameXML LoadXML_AnimGroup/Create_SimpleMovieFrame.
Engine->WoW includes where 12340 calls directly: CSimpleModelFFX,
StringToMouseButton, GetDeclinedWord, EmblemTextureUpdate.
Also drops stale VERIFY stamps found invalid by the harness recheck.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
SimpleFrameScript_Scripts.cpp (7 Lua functions, register/unregister),
CreateScriptMetaTable/DestroyScriptMetaTable, IsA, GetObjectTypeName and
GetScriptMetaTable for 25 classes with their statics. CScriptRegion dtor,
LoadXML, anim hooks and its 25 script methods; UnflattenFrame, DragBy,
GetRectFramePoints (0x512410, name ours); CRenderBatch and the strata
node; small CSimpleFrame/CSimpleTop/FontString/Texture/Font leaves.
Anim-family, CSimpleTitleRegion and CSimpleMovieFrame headers rebuilt
from the binary. Frame includes CSimpleModelFFX.h because 0x81B870 calls
CSimpleModelFFX::CreateScriptMetaTable directly. Button/Checkbox IsA
unchecked until the IDB splits 0x9621E0-0x962300.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
XMLTree.cpp (0x8145B0-0x814E40, XMLTree_GetRoot at 0x8BE770), FrameXML.cpp
(0x812530-0x8145A3) and LoadXML.cpp (0x814E40-0x816767, name guessed: no
__FILE__ string). LoadXML_AnimGroup and Create_SimpleMovieFrame stay
declared until their Frame classes exist.
XMLNode allocates from the CDataAllocator at 0xD3F718; CScriptRegion derives
from CScriptObject and CLayoutFrame (second vtable at +0x20); the attribute
array element is CXMLAttribute. Expat.h declares the expat API by hand until
expat is vendored.
Shared additions: Frame enums (FRAME_STRATA, ORIENTATION, SimpleAnim*,
ANCHORPOINT renamed FRAMEPOINT), Frame class vtable slots/constructors/
allocators and four shell classes, EGxBlend, MD5_CTX, one stpl.h instance.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
M2Model.cpp, M2Shared.cpp, M2Scene.cpp, CM2SceneRender.cpp, M2Light.cpp,
M2Cache.cpp and the new M2Data.cpp/.h (0x81C000-0x834900). Only the
std::sort internals for CModelBatch stay unported.
AnimationData lookups in ResolveSequenceFallback/SequenceFallbackById use
g_animationDataDB directly: 12340 inlines its record loads into M2Model.cpp.
Shared additions: CParticleEmitter2 vtable order and the plane/sphere/spline
emitters, CRibbonMat, Services/Camera.h, Base/SIMD, Base/ObjectAlloc.h (the
engine-side ObjectAlloc interface), CFacet, CAaRect, CiRange, the C44Matrix
16-float constructor and CMath fequal/fnotequal/FloatToInt64.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
GxuFontMain.cpp (0x6BCD60-0x6BF370), GxuFontUtil.cpp, GxuFontFont.cpp,
GxuFontFace.cpp, GxuFontString.cpp, GxuFontMiscClasses.cpp,
GxuFontTextureCache.cpp and IGxuFontGlyph.cpp, named after the 12340 and
Mac 13682 source file strings; CGxFont moves from Gx to Gxu.
GxuLight.cpp (0x6BB510-0x6BCD60): the light grid behind the GxuLight*
function-pointer table at 0xAD9834.
Gxu links FreeType 2.0.1. Shared additions: GxBufDestroy, GxFormatColor,
CGxVertexPC/PCT, CMath fint_n/fuint_pi/CeilToInt64, C3Vector::SquaredMag,
HASHKEY_DWORD and the template instances in stpl.h.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- FrameScript.cpp/.h: Lua state, execute/compile/load, variables, text,
sprintf/print/pack, events and CPU usage
- FrameScript_Object.cpp/.h: FrameScript_Object and its methods
- FrameScript_Scripts.cpp: the _G extras (strtrim, securecall, date, ...),
static, table s_extraFuncs at the end
- Types.h: FRAMESCRIPT_GENDER, PLURAL_RULE (best-guess value names)
- CScriptObject moved from _Triage to Frame; stale FrameScript triage
headers removed
- Win32: _USE_32BIT_TIME_T like the original build
- MD5Update declared in Storm MD5.h (0x779A30, not ported)
All 87 definitions verified against 12340 (58 pass, 29 reviewed suspects).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- Field names from the 12340 type library (x/y/z/w, a0..d3, minY/minX/maxY/maxX, b/t, c/r, n/d, origin/dir)
- Files renamed to match their class; CRay -> C3Ray; C3Segment, CRect, CiRect, C2iVector, C3iVector split out
- MouseEventData, CharacterInfo, M2Bounds moved out of Tempest headers
- 107 functions: C2/C3/C4Vector, C33/C34/C44Matrix, C4Quaternion, C4Plane, CAaBox, CAaSphere, C3Ray, CRect, CiRect, CImVector, NTempest
- 0x4C1C40 is cdecl (q, out): ported as static C44Matrix::FromQuaternion (guessed)
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Storm moves under Engine/Source with its inner layout unchanged. All
includes use Engine/Source/Storm/..., Storm's include guards follow the
new path, and the top-level CMakeLists adds Engine/Source/Storm.
SFile.cpp (SFile::CreateOverlapped/DestroyOverlapped) moves to
Engine/Source/BlizzardCore.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
HandleClose, HandleCreate, HandleDuplicate; HandleDereference inline;
empty HandleInitialize/HandleDestroy (folded). CHandleObject in
Base/Handle.h with its real layout (vtable, m_refcount at +4), which moves
TEXTBLOCK::m_string and FONTHASHOBJ's fields by 4. HOBJECT in Base/Types.h.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>