- move triage code to the folders of its binary neighbours (AreaList,
movement packet types, CClientObjCreate, CWOWClientStatus, SHA1,
Clamp, EmergencyMem, MippedImg, WowMouse, ...)
- merge HMAC template, OnGxRestartClearWorld and TIMESTAMPSTRUCT into
their natural headers
- delete superseded duplicates and unk-only placeholders
- tools: drop Triage library, fix Streaming stub signatures, remove
stubs now provided by BlizzardCore, MapViewer s_liquidTypeId
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Batch 1: weather templates, client console commands, loading screen paths,
glue script events, AddOns/AccountData/Battlenet getters, simple camera and
camera vehicle offsets, Warden module path, BLL loader, FFX effects, Grunt
and GruntLogin matrix/file handlers, CGlueMgr char customize/faction change/
kick reason.
semdiff: 251 Lua script functions called luaL_error without the return 0 that
12340 has after every call site (each confirmed per call site in the binary).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Ports the stand-ins hit since run 85 and the follow-up script batches:
RaidInfo, PartyFrame, BarberShop, ArenaTeamInfo, SkillInfo, InputControl,
petitions/guild registrar, ItemText, Tutorial, ContainerFrame, QuestLog,
ActionBar, ClassTrainer, UIMacros, GuildBank, AuctionHouse and Commentator.
Fixes found on the way: AuctionHouse sell items are a fixed inline array
(IsItemForSell read garbage), GetSellItem returns the container GUID,
Commentator instance key is read/written as u32/u16/u8 and skirmish
commands send a u32 flag, GetArenaMember returns uint64 in edx:eax.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- CGObject_C base, CEffect, CObjectEffect/CObjectEffectManager effect states
- Unit, Player, Item/Container/Bag, Corpse, DynamicObject, GameObject and
all GameObject type classes (vtables matched slot by slot), Movement,
MovementShared, Missile, Vehicle/Passenger/Camera, combat log, caches
- Client object manager (0x4D3100-0x4D7880) incl. SMSG_UPDATE_OBJECT,
SMSG_COMPRESSED_UPDATE_OBJECT, SMSG_DESTROY_OBJECT; type ctors/PostInit
- CGGameUI::CanPerformAction and the ready part of CGInputControl
- Layouts named from descriptor fields and code; CM2Model 0x134 matrix,
CClientObjCreate tail, CGUnit_C/CGPlayer_C sizes 0x1008/0x1958
- WOWGUID struct replaces the IDB's WGUID low/high pair and guid uint64_t;
SmartGUID derives from it; member functions returning a guid keep
uint64_t (MSVC returns class types from members via hidden pointer);
structs with 4-aligned guids in 12340 use pack(4)
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- Grunt login ported end to end (SRP6 challenge/proof, version checksum,
realm list) and tested against a live server: authenticates, connects to
the world server (auth session with proof-of-work, header crypt), receives
the character list and shows character select
- Glue: realm list UI, character select (list, models, scripts), character
create screen + name generator, delete/rename/decline, Enter World up to
the loading screen; loading screen drawing and progress
- AccountData (times, update, upload/download), BannedAddOns, addon scan and
addon info, client cache version, tutorial flags
- Shutdown path at login state: world/map/liquid/weather teardown, NetClient,
ComSat, streaming stop; Logitech LCD no-device path in Ui/UILCD/Windows
- PCRE 5.0 vendored (core stock; chartables and the posix layer from 12340),
ValidateName
- Fixes: TSGrowableArray::CalcChunkSize clamps to >= 8 (crash on char list),
CWorldScene liquid renderer allocation, CMapFootprintTexture element ctor,
pointer render states on x64, CFrustum/CWFrustum layout, M2 draw callback
arguments, 37 class/struct forward-declaration mismatches
- IDB name sync (1217 names), verify aliases, harness large-element
instantiation
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
HandleCompare (0x47BF20): the ICF-folded 4-byte handle difference that the
M2 scene sorts, CSimpleTexture and CDetailDoodadInst call. ~TRefCnt now
names its scalar deleting destructor (0x480E40), ~CDataRecycler adds
0x95CE00, and TSHashObject gets its destructor (0x47C560, the HASHKEY_STR
instance). Event is 88/88, Base 122/123 (the s_callbackRegAllocator atexit
thunk stays compiler-generated).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
M2Model.cpp, M2Shared.cpp, M2Scene.cpp, CM2SceneRender.cpp, M2Light.cpp,
M2Cache.cpp and the new M2Data.cpp/.h (0x81C000-0x834900). Only the
std::sort internals for CModelBatch stay unported.
AnimationData lookups in ResolveSequenceFallback/SequenceFallbackById use
g_animationDataDB directly: 12340 inlines its record loads into M2Model.cpp.
Shared additions: CParticleEmitter2 vtable order and the plane/sphere/spline
emitters, CRibbonMat, Services/Camera.h, Base/SIMD, Base/ObjectAlloc.h (the
engine-side ObjectAlloc interface), CFacet, CAaRect, CiRange, the C44Matrix
16-float constructor and CMath fequal/fnotequal/FloatToInt64.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
All 509 functions of 12340's Lua block (0x84D390-0x863580) carry an
OFFSET and are verified (static evidence; see re/notes/303_lua.md).
- Compiled as C++ with extern "C" API, setjmp/longjmp errors.
- Taint on GC objects and TValues, taint globals, taint event callback,
closure taint in the VM, gctag for new objects.
- Profiler: Profile per closure, luaD_precall_profile,
luaV_execute_profile; GC size/time accounting per tag.
- luaconf: COMPAT_VARARG/MOD/GFIND off, 4-byte max alignment,
MAX_SIZET 0x1000000; removed randomseed/print/dofile/loadfile/load,
no binary chunks.
- UTF-8 string.lower/upper, Blizzard string.format, BOM skip,
raw lua_setglobal, table.removemulti/wipe, externalabort.
- New: lbitlib.c, lmemPool.cpp/.h, FrameScript_InvalidPtrCheck
(Win32/Win64), lua CMake target.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
System/Log (16 functions) and Thread::WaitForever. Storm SComp review:
ImaAdpcmCompress size compares are signed as in 12340. AllocSTL_raw and
CCritSect members marked INLINED; SSyncObject ctor out of the header.
Platform layout: Windows API code lives in <dir>/Win32/ (whole file in
#if WOWDECOMP_ARCH_32) with full copies in <dir>/Win64/ (ARCH_64);
no _M_X64 blocks inside files. Former W32/ and *_Win32.cpp files moved,
their headers are generic now. Win32 API calls moved out of generic
File/Log/Thread/Unicode/SCmd files; Storm SErr/SLog/SReg/SMsg moved
whole. CODING_RULES section 7, PORTING_64BIT "Platform folders".
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Port the remaining Base block A pieces: global/context init, the
command-line option table, UTF-8/16 conversion (sgetu8/sputu8), the
coordinate/aspect helpers and the context qsort. All functions verified
against the binary.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Port CDataStore (0.5.3 layout and names, 11-slot 12340 vtable) into
Engine/Source/Base, remove its declaration from UIUtil/AddOns.h, and
document the three folded vtable stubs. All functions verified against
the binary.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Port CDynamicString (Mac 4.0.1 names; Grow and field names are best
guesses) and allow best-guess names in CODING_RULES.md. All functions
verified against the binary.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Port CDataRecycler following the 12340 binary (Link takes two arguments).
Move every non-template function body out of the Base headers into their
.cpp files, give TRefCnt its own RefCount.cpp, and record the rule in
CODING_RULES.md.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Port the fixed-size block allocator (0.5.3 layout, Mac 3-argument Clear,
destructor as inlined Clear). All functions verified against the binary.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Port CBitArray (Mac 4.0.1 names and field names from asserts) and add the
client operator delete[] that 12340 inlines everywhere.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Port the 12340 string interning table (Mac 4.0.1 design) and TRefCnt in
RefCount.h. All functions verified against the binary.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Storm moves under Engine/Source with its inner layout unchanged. All
includes use Engine/Source/Storm/..., Storm's include guards follow the
new path, and the top-level CMakeLists adds Engine/Source/Storm.
SFile.cpp (SFile::CreateOverlapped/DestroyOverlapped) moves to
Engine/Source/BlizzardCore.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
HandleClose, HandleCreate, HandleDuplicate; HandleDereference inline;
empty HandleInitialize/HandleDestroy (folded). CHandleObject in
Base/Handle.h with its real layout (vtable, m_refcount at +4), which moves
TEXTBLOCK::m_string and FONTHASHOBJ's fields by 4. HOBJECT in Base/Types.h.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
CStatus with its 12340 layout (vtable, entry list, highest severity):
GetGlobalStatusObj, Add (both), IsEmpty, GetErrorStr, GetErrorStrLen,
GetErrorStrAlloc, Prepend, ~CStatus; STATUSENTRY destructor and Clear
inline in Status.h. CTexture drops the gap that was the rest of CStatus.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>