- Buffer.cpp: PNC2T2 Color0/Color1 are D3DCOLOR (type 0), not FLOAT3;
unified-path WMOs (MOHD flag 0x2, e.g. Icecrown Citadel) were drawn
blue/green/black (12340 init at 0x9CD010)
- CShadowQuery::AllocBuffers: size the group/matrix pointer arrays with
sizeof; 0x2000 bytes only fits 0x800 entries with 4-byte pointers
- ShaderEffect: upload sun constants with explicit w (the values 12340
reads from the neighbouring statics), independent of x64 layout
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- SPIRIT IP-MR voice codec (Engine/Source/ComSat/SPIRIT): all ~130
functions decompiled from 12340 (Intel C++ code, ported as plain C;
rsqrtss sites use _mm_rsqrt_ss). docs/0x0089F580.md.
- ComSatSoundCODEC state/table buffers sized from sizeof (x64 state is
larger than the Win32 13504 bytes).
- Blizzard::Using::Use and the per-module using statics.
- ComSatClient_Init, ComSatThread::Init, ComSatClientCallback.
- SteelSeries WowMouse / HidManagerImpl (Win32 + Win64), docs/0x008C3E40.md.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- libjpeg moved from ThirdParty/jpeg to Engine/Source/jpeg: stock 6b
compression side plus Blizzard's changes (int boolean, error_flag
instead of exit, source_pixels in jpeg_compress_struct, unscaled
jpeg_add_quant_table, hook-pointer memory backend), all 140 functions
OFFSET-tagged and verified
- jmemsrc.c: Blizzard's in-memory BGR(A) source (jinit_read_mem)
- ImageWriter: LDPC encoder, rect layout, block embedding, JPEG writer
and the four API functions, verified against 12340
- THIRD_PARTY.md: libjpeg marked done
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- FreeType: 12340's autohinter has no 2.0.1 glyph-transform code (ah_hinter_load_glyph 0x9A7E00,
ah_hinter_load 0x9A7840); swap to tag VER-2-0, drops the FT_Matrix_Invert reference
- libjpeg 6b from ijg.org (makefile.vc LIBOBJECTS, jconfig.vc as jconfig.h), stock jmemnobs.c left out
- Engine/Source/jpeg/jmemnobs.cpp: Blizzard's hook-based memory backend (0x4AAF60-0x4AAFD0), target jpegmem
- THIRD_PARTY.md: versions/evidence, SPIRIT IP-MR listed as not available
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- move triage code to the folders of its binary neighbours (AreaList,
movement packet types, CClientObjCreate, CWOWClientStatus, SHA1,
Clamp, EmergencyMem, MippedImg, WowMouse, ...)
- merge HMAC template, OnGxRestartClearWorld and TIMESTAMPSTRUCT into
their natural headers
- delete superseded duplicates and unk-only placeholders
- tools: drop Triage library, fix Streaming stub signatures, remove
stubs now provided by BlizzardCore, MapViewer s_liquidTypeId
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- 360 Script_* re-approved: only change since approval is return 0
after luaL_error (semdiff vs binary)
- realm id field renames and TotemInfo m_guid (+0x8) checks re-approved
- CGlueMgr::OnKickReasonMsg passes via InitTokenSeed alias
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- luaB_getfenv: look up __environment metafield like 12340
- DSPSfxReverb::setParameterInternal: set mUpdate for REFLECTIONSLEVEL and REVERBLEVEL
- CGGameUI::DestroyTotem, Script_SetTotem: test the totem GUID, not unk_0004
- Missing return 0 after luaL_error in script functions
- OFFSET tags of template instances carry their instance type: [0xXXXXXX<Type>]
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Batch 1: weather templates, client console commands, loading screen paths,
glue script events, AddOns/AccountData/Battlenet getters, simple camera and
camera vehicle offsets, Warden module path, BLL loader, FFX effects, Grunt
and GruntLogin matrix/file handlers, CGlueMgr char customize/faction change/
kick reason.
semdiff: 251 Lua script functions called luaL_error without the return 0 that
12340 has after every call site (each confirmed per call site in the binary).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Counts the binary converts as unsigned (fild + jge + fadd 2^32) or signed
(sar, plain fild) now use the matching types; KB count scripts return
luaL_error's result like the binary.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
M2Array stores a signed 32-bit self-relative offset. On x64 a separate
heap block can lie more than 2 GB from m_data, so relocated low-priority
.anim sequence data wrapped and crashed in ProcessEventCallbacks.
Add OsAllocNear/OsFreeNear (Win64): reserve a block within 1.5 GB of an
anchor. x64 now uses it for .anim buffers (load, cancel, destructor) and
for the skin vertex overflow, which again follows the Win32 structure
(m_flags |= 8, freed in ~CM2Shared). Texture combo arrays keep growing
m_data. All new code is under WOWDECOMP_ARCH_64.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- x64: texture combo, transform combo and converted vertex arrays are
appended to a grown m_data buffer instead of separate heap blocks, so
the self-relative 32-bit M2Array offsets always reach them; they are
freed with m_data (destructor frees only on Win32)
- FinishLoading clears header bits 0x20/0x40 from the file; the client
uses them to mark arrays it allocated, and later-expansion models set
them, which made the destructor free a pointer into the file buffer
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
When ON (DISABLE_SIGNATURE_CHECKS=1), the client skips the signaturefile
MPQ MD5 checks, FrameXML_CheckSignature reports .toc files as valid with
the digest of the files on disk, and GlueXML, FrameXML and AddOn loading
skip their post-load digest comparison. OFF keeps the original checks.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Ports the stand-ins hit since run 85 and the follow-up script batches:
RaidInfo, PartyFrame, BarberShop, ArenaTeamInfo, SkillInfo, InputControl,
petitions/guild registrar, ItemText, Tutorial, ContainerFrame, QuestLog,
ActionBar, ClassTrainer, UIMacros, GuildBank, AuctionHouse and Commentator.
Fixes found on the way: AuctionHouse sell items are a fixed inline array
(IsItemForSell read garbage), GetSellItem returns the container GUID,
Commentator instance key is read/written as u32/u16/u8 and skirmish
commands send a u32 flag, GetArenaMember returns uint64 in edx:eax.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Old list #26-#77 and new list #1-#25: unit movement/vehicle passengers,
missile trajectory, trade skills, corpse/spirit healer UI, map flight
bounds, footprints, low detail render, shadow query gather/render,
CMapArea liquid sounds, weather type/pos deltas, world state init/set,
transport/chair/animated game objects, contact list packet, macros,
tracked achievements, tutorials, dungeon difficulty.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
CGTooltip::SetSpell (split into inlined section helpers), Lua SetSpell/SetSpellByID,
QuestTextParser spell text parser, MathState formula engine with MATHOP enum,
spell math (min/max points, duration, cast time, range) and talent tooltip text.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- Port hit-order Lua stand-ins (unit tokens, tooltips, combat log filters and
current entry, bags/containers, quest POI, minimap, titles, world states,
trade, group roles, runes, mirror timers, saved-variable registration, Quit)
- LoadAddOn: real add-on loading (Blizzard_CombatLog etc. now load)
- CombatLogEntry::PushEvent: COMBAT_LOG_EVENT arguments
- World map chain: SetMapToCurrentZone, SetMap, GetWorldPosition, landmarks,
overlays, highlight, zones, dungeon levels, player position
- OpenArchives: locale index was off by one (enUS read the koKR DBC slot,
leaving zone/map names empty)
- Zone/area sound chain, invisible units (spline mode read size), raid/bag
crash fixes, stand-in console, waystone icon for all executables
- Coding-rule cleanups: statics/includes at the top, event enums, Lua
_Scripts layout
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Ports verified against 12340 that take the x64 client from character
login to a playable world:
- Camera: SetView/ResetView, motion, free-look facing, tracking, bobs,
liquid bump, world collision; camera Lua scripts
- Input: world frame key/mouse layers, default action, mouselook,
turn/pitch player, TurnOrAction/CameraOrSelectOrMove scripts
- Movement: legal facing range, turn/pitch/raw facing events, transport
status, move spline copy, unit update info, smooth facing, anim end
- Units: component and extended display init, model fade/scale,
entity sort table, RenderEntitys, split-body culling
- Interiors: WMO group bounds, BSP segment link query, face linking,
interior lighting
- Collision: CMap::QueryFacets closure with frustum queries and NDCClip
- UI: game UI mouse filters, client control state, faction standing
packet, many *_Scripts.cpp Lua tables; name generator dictionary fix
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- CGObject_C base, CEffect, CObjectEffect/CObjectEffectManager effect states
- Unit, Player, Item/Container/Bag, Corpse, DynamicObject, GameObject and
all GameObject type classes (vtables matched slot by slot), Movement,
MovementShared, Missile, Vehicle/Passenger/Camera, combat log, caches
- Client object manager (0x4D3100-0x4D7880) incl. SMSG_UPDATE_OBJECT,
SMSG_COMPRESSED_UPDATE_OBJECT, SMSG_DESTROY_OBJECT; type ctors/PostInit
- CGGameUI::CanPerformAction and the ready part of CGInputControl
- Layouts named from descriptor fields and code; CM2Model 0x134 matrix,
CClientObjCreate tail, CGUnit_C/CGPlayer_C sizes 0x1008/0x1958
- WOWGUID struct replaces the IDB's WGUID low/high pair and guid uint64_t;
SmartGUID derives from it; member functions returning a guid keep
uint64_t (MSVC returns class types from members via hidden pointer);
structs with 4-aligned guids in 12340 use pack(4)
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- CWFrustum (CFrustum + free-list link at 0xF4, RTTI .?AVCWFrustum@@) moves from
_Triage to Engine/Source/Tempest; the redundant forward declaration is gone
- _Triage/SHA1Broken.h and _Triage/XML.h had no users
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
- Grunt login ported end to end (SRP6 challenge/proof, version checksum,
realm list) and tested against a live server: authenticates, connects to
the world server (auth session with proof-of-work, header crypt), receives
the character list and shows character select
- Glue: realm list UI, character select (list, models, scripts), character
create screen + name generator, delete/rename/decline, Enter World up to
the loading screen; loading screen drawing and progress
- AccountData (times, update, upload/download), BannedAddOns, addon scan and
addon info, client cache version, tutorial flags
- Shutdown path at login state: world/map/liquid/weather teardown, NetClient,
ComSat, streaming stop; Logitech LCD no-device path in Ui/UILCD/Windows
- PCRE 5.0 vendored (core stock; chartables and the posix layer from 12340),
ValidateName
- Fixes: TSGrowableArray::CalcChunkSize clamps to >= 8 (crash on char list),
CWorldScene liquid renderer allocation, CMapFootprintTexture element ctor,
pointer render states on x64, CFrustum/CWFrustum layout, M2 draw callback
arguments, 37 class/struct forward-declaration mismatches
- IDB name sync (1217 names), verify aliases, harness large-element
instantiation
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
ChaosModeUpdate (0x4C74F0) reordered to the binary's switch case layout
and case 15 written as 8 statements; verified. SE2::StopAllSounds takes
the unused int every 12340 caller pushes. Approval stamps for the
functions unblocked by the IDB splits (Button/Checkbox IsA, Checkbox
dtor, CSimpleFrame::NotifyDelayedLoad, CGxDeviceD3d9Ex ctor,
CM2Cache dtor) and for the re-reviewed IsSequenceLoaded,
OsGuiMessageBox, TexturePickAlternateFilename, three FMOD ctors and
luaG_concaterror.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Core (CSimpleFrame + Lua, CSimpleTop/CFrameStrata/CSimpleRender/
CRenderBatch, CSimpleRegion/CBackdropGenerator/CScriptRegion), animation,
text (FontString/Font/Fontable), texture and model, buttons, EditBox,
MessageFrame/MessageScrollFrame, MovieFrame/ColorSelect/StatusBar,
Slider/ScrollFrame/HTML/HyperlinkedFrame, all Lua method tables and
RegisterScriptMethods. Layouts, vtables and sizes rebuilt from the
12340 ctors, vtables and allocator initializers; CScriptObject vtable
slots 5/6 fixed; CSimpleFontedFrame is a real secondary base. Lua error
paths return after luaL_error as in 12340 (209 sites; 5 fall through).
Binary quirks kept and documented in docs/.
Supporting additions: Event key/char/ime/focus/size event headers,
Scrn/Scrn.h (ScrnLayerCreate), DivxDecoder import declarations,
C2Vector/CRect helpers, CM2Light dtor, OsInputEnableSecureMode, stpl.h
instance addresses, FrameXML LoadXML_AnimGroup/Create_SimpleMovieFrame.
Engine->WoW includes where 12340 calls directly: CSimpleModelFFX,
StringToMouseButton, GetDeclinedWord, EmblemTextureUpdate.
Also drops stale VERIFY stamps found invalid by the harness recheck.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
272 definitions, 111 pass and 161 approved with per-function reasons,
0 fail. CCharacterComponent and ComponentUtils started from the
thunderbrew port and were checked against 12340: adds the threading and
compression paths (CComponentRequest, CComponentMipBits, SSE and scalar
DXT1 compressors), static cdecl helpers, bool SetRandom*, signed prefs
modulo, fixed main/off-hand sheath links. CLightning/CLightningManager
moved here from Services (Common\Lightning.cpp); SetCount fixes the
never-filled joint arrays, alpha rounds via fint_. ItemDisplayInfoRec
ctor carries the folded GetRow OFFSET; 0x4F1650 joins the stpl.h list.
Stand-in declarations in World.h, ComponentData.h and Player_C.h.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Ports SFile::FileExists (0x424E50), SFile::FileGetIsLocalAmount
(0x4217E0) and the Mopaq helpers SFileGetFileDetails (0x460F00) and
SFileGetIsLocalAmount (0x461040). The older 0x421FC0 FileExists is
renamed FileExistsInArchives. Blizzard::Streaming::GetIsLocalAmount
(0x44F370) is declared only; BlpTest, DbcTest and MpqTest get stand-ins
so they link.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
fmod_debug.cpp (compiled only with DEBUG) uses the thread-id display
flag; 4.09's fmod.h lacked it. Defined as 0x08000000, the unused bit in
FMOD_DEBUG_DISPLAY_ALL (0x0F000000). Not in 12340 (release lib).
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
SimpleFrameScript_Scripts.cpp (7 Lua functions, register/unregister),
CreateScriptMetaTable/DestroyScriptMetaTable, IsA, GetObjectTypeName and
GetScriptMetaTable for 25 classes with their statics. CScriptRegion dtor,
LoadXML, anim hooks and its 25 script methods; UnflattenFrame, DragBy,
GetRectFramePoints (0x512410, name ours); CRenderBatch and the strata
node; small CSimpleFrame/CSimpleTop/FontString/Texture/Font leaves.
Anim-family, CSimpleTitleRegion and CSimpleMovieFrame headers rebuilt
from the binary. Frame includes CSimpleModelFFX.h because 0x81B870 calls
CSimpleModelFFX::CreateScriptMetaTable directly. Button/Checkbox IsA
unchecked until the IDB splits 0x9621E0-0x962300.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
474 definitions, 0 fail; only the CGxDeviceD3d9Ex ctor is unchecked
(IDB has it as a chunk of NewD3d9Ex). Adds the Gxu draw-list module,
GxScenePresent, GxDevDestroy, OpenGl VBO broker and GlExt (moved under
CGxDeviceOpenGL). Binary-backed fixes: GxTexCopy tests m_renderTarget,
TexStretch compares widths first, fullscreen style 0x87000000, pixel
format reject mask 0x50, DeviceOverride case 0 field, filter constant,
D3d9Ex window class name, four thiscall members. Draw-list enums moved
from WoW Ui/Types.h to Gx/Types.h. OpenGl linked on WIN32.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Profile, TextBlock, Camera (+CameraInt.h), ParticleSystem2 (emitters,
track sampling, sort queue), RibbonEmitter, GfxSingletonManager managers
and the v1 CParticleEmitter destructor. All pass or approved with
explained diffs; 0 fails. Callee-cleanup helpers declared __stdcall,
float->int paths use CMath::fint_ (binary uses fistp). CLightning fields
named only; it is WoW/Common code. _Triage CAngle removed, Camera.h
repointed to CameraInt.h. CM2SceneRender Render calls cast for the new
signature. Services links freetype for the Gxu font headers.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
232 SI2 functions (0x4C5900-0x4D2780 plus the DSP, voice chat, zone sound,
advanced kit property and internal code), in files named after the 12340
__FILE__ strings (SoundInterface2*.cpp) and best-guess splits after the
Mac SI3 files. Replaces the _Triage shells. External WoW callees are
declared only (GameTime, DBClient, Unit_C, Item_C, ObjectMgrClient,
ChatFrame, GameUI, CGWorldStateInfo, ComSatClient, SFile name overloads)
and tracked as open items.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
The base vtable 0xAABB60 has an empty Release (0x5EEB70), not a pure one;
the destructor maps to its scalar deleting destructor 0x9C1820.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>