171 Commits
Author SHA1 Message Date
SatyandClaude Opus 5.5 eabc5d8997 Port the logic fixes from the msvc80 branch
Behaviour fixes found while byte-matching against 12340, without the
VS2005 code-shape rewrites:
- 272502f5 logic bugs (MapObjDef 0x80 flag, D3D texop, PostReenable, ...)
- 3002c17f case-sensitive KNOWNDANCES/DECLINEDWORD keys, DynamicObject
  GetTransportGUID, CShadowCache::Initialize
- OpenGl IStateSyncEnables fill/line, DsSet integer value tests
- FriendList tail padding, HandleSpellEventSound severity, selection
  index -1, negative spell id in HasPetSpell
- operator delete null checks, FMOD MemoryFile seek clamp, SErr
  HeapAlloc flags
- WOWCLIENT_CRASH_LOG option

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-15 15:18:17 +02:00
SatyandClaude Opus 5.5 62c5c4fa18 Fix ICC WMO colours and x64 shadow-query overflow
- Buffer.cpp: PNC2T2 Color0/Color1 are D3DCOLOR (type 0), not FLOAT3;
  unified-path WMOs (MOHD flag 0x2, e.g. Icecrown Citadel) were drawn
  blue/green/black (12340 init at 0x9CD010)
- CShadowQuery::AllocBuffers: size the group/matrix pointer arrays with
  sizeof; 0x2000 bytes only fits 0x800 entries with 4-byte pointers
- ShaderEffect: upload sun constants with explicit w (the values 12340
  reads from the neighbouring statics), independent of x64 layout

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-05 13:53:11 +02:00
SatyandClaude Opus 5.5 dfae6719b7 Naming pass: 65 functions, 103 statics, 63 fields named from Mac symbols and behaviour
Evidence and confidence per rename in re/notes/310_naming_pass.md.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-04 09:27:29 +02:00
SatyandClaude Opus 5.5 82879a879d Port the last non-anti-cheat functions: ServerLink, PetAction, emitter params
- Grunt::ServerLink: all CMD_GRUNT_* handlers, send helpers, features/strings, command table 0xB24D70,
  s_localeIds 0xAD3004, Pending::Remove (dead server-side link, docs/0x008CE200.md); ServerLink.h stub removed
- PetAction type for CGPetInfo::m_actions / pet spell actions / cursor pet action, SetAutocast 0x5D32F0
- CParticleEmitter2 fields 0x98-0x11F moved into CParticleEmitter2::Params (ctor 0x979250)
- fixed16(float), C3Vector::FlushDenormals, CGxuLightQueue + static 0xC7C074, CAaSphere(), CMapLowDetail(),
  C2Vector()/C4Plane() out of line, SpellHistory dtor, CGDynamicObject_C GetScale/GetRawFacing
- DB record operator= (PetNameCache, CGPetition, DanceCache): fixes the shallow-copy double free in AddItem
- ClientSetTimer(delay, handler, param) with its five callers, IOMd5Unit::Create without container,
  CDataStore::GetByte / Get(int32_t&), WDataStore::GetHeaderSpace, TSHashTable::Head, TSList::IsEmpty
- CameraTurnPlayer calls CVehicleCamera_C::IsTransitioningFacing 0x5FAA10 (was IsHierarchyChasingFacing)
- OFFSET additions: TSHashTable::Unlink, TInstanceId dtor, DBCACHEHASH dtor (+ ItemNameCache_C dtor),
  CDataStoreCache ctor, BitUnpacker/RunningAverageCalculator deleting dtors, CGTooltip::GetObjectType

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-04 08:10:06 +02:00
SatyandClaude Opus 5.5 07d00b0ce8 Port SPIRIT IP-MR codec, Using framework, ComSat client init, SteelSeries HID
- SPIRIT IP-MR voice codec (Engine/Source/ComSat/SPIRIT): all ~130
  functions decompiled from 12340 (Intel C++ code, ported as plain C;
  rsqrtss sites use _mm_rsqrt_ss). docs/0x0089F580.md.
- ComSatSoundCODEC state/table buffers sized from sizeof (x64 state is
  larger than the Win32 13504 bytes).
- Blizzard::Using::Use and the per-module using statics.
- ComSatClient_Init, ComSatThread::Init, ComSatClientCallback.
- SteelSeries WowMouse / HidManagerImpl (Win32 + Win64), docs/0x008C3E40.md.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-04 06:19:53 +02:00
SatyandClaude Opus 5.5 55d90d30ce Port ImageWriter; decompile Blizzard's libjpeg 6b
- libjpeg moved from ThirdParty/jpeg to Engine/Source/jpeg: stock 6b
  compression side plus Blizzard's changes (int boolean, error_flag
  instead of exit, source_pixels in jpeg_compress_struct, unscaled
  jpeg_add_quant_table, hook-pointer memory backend), all 140 functions
  OFFSET-tagged and verified
- jmemsrc.c: Blizzard's in-memory BGR(A) source (jinit_read_mem)
- ImageWriter: LDPC encoder, rect layout, block embedding, JPEG writer
  and the four API functions, verified against 12340
- THIRD_PARTY.md: libjpeg marked done

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 22:54:39 +02:00
SatyandClaude Opus 5.5 379ad35540 Third party: FreeType 2.0 (was 2.0.1), libjpeg 6b + Blizzard jmem backend
- FreeType: 12340's autohinter has no 2.0.1 glyph-transform code (ah_hinter_load_glyph 0x9A7E00,
  ah_hinter_load 0x9A7840); swap to tag VER-2-0, drops the FT_Matrix_Invert reference
- libjpeg 6b from ijg.org (makefile.vc LIBOBJECTS, jconfig.vc as jconfig.h), stock jmemnobs.c left out
- Engine/Source/jpeg/jmemnobs.cpp: Blizzard's hook-based memory backend (0x4AAF60-0x4AAFD0), target jpegmem
- THIRD_PARTY.md: versions/evidence, SPIRIT IP-MR listed as not available

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 19:40:06 +02:00
SatyandClaude Opus 5.5 5c9a9c4aac Tag deleting dtors of IOLockUnit, CWOWClientStatus, SEFileSound, PageTextCache
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 18:19:46 +02:00
SatyandClaude Opus 5.5 27de58d41e Dissolve _Triage into the source tree
- move triage code to the folders of its binary neighbours (AreaList,
  movement packet types, CClientObjCreate, CWOWClientStatus, SHA1,
  Clamp, EmergencyMem, MippedImg, WowMouse, ...)
- merge HMAC template, OnGxRestartClearWorld and TIMESTAMPSTRUCT into
  their natural headers
- delete superseded duplicates and unk-only placeholders
- tools: drop Triage library, fix Streaming stub signatures, remove
  stubs now provided by BlizzardCore, MapViewer s_liquidTypeId

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 18:09:53 +02:00
SatyandClaude Opus 5.5 ecf481aedd Restamp verify backlog after luaL_error returns and field renames
- 360 Script_* re-approved: only change since approval is return 0
  after luaL_error (semdiff vs binary)
- realm id field renames and TotemInfo m_guid (+0x8) checks re-approved
- CGlueMgr::OnKickReasonMsg passes via InitTokenSeed alias

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 17:27:37 +02:00
SatyandClaude Opus 5.5 211a43a44a Tag deleting dtors and ICF stubs, fix RepairCache key/record layout
- OFFSET tags for scalar deleting destructors of IOUnit, IOMpqUnit,
  IOMpqArchiveUnit, IOMpqDiskUnit, IOMpqReadUnit, IOAlignUnit, SFileImpl
- [dtor, ??_G] tags for IOMpqWriteUnit, ParameterItem, ServerItem,
  FileItem, TransportHttpCallback, TrackerHttpDataDownloadCallBack
- IOMpqArchiveReadUnit::Write 0x426880, LocalObject<SFileFatalInfo>::New
- RepairKey index is int64; RepairRecord {md5, index, offset, size};
  RepairEntry has no flags field (0x440B10/0x440BD0)

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 17:22:16 +02:00
SatyandClaude Opus 5.5 c790ecb4a0 Port Streaming/Storage/Transport/HTTP, Mopaq write path and missing-function batches
- Streaming: StreamingManager, Manifests, Storage (.part files, write queue),
  Transport (HTTP split download, throttle), Tracker/StartupReport, streaming
  filestack verbs (s_streamstack, StreamingOpen), RepairCache static
- URL: HttpRequest, InternetCallback, ReadResponseData, DownloadURL
- Mopaq write path: SFileCreateArchive/CreateFile/WriteFile, IOMpqWriteUnit,
  WriteArchiveChanges, RebuildHashTable, listfile acquire/release;
  SComp::Compress with RLE/zlib/bzip2/pkware compressors; MPQEncrypt::Encrypt
- LaunchChildProcessWithArguments, Debug::DefaultCallback/Breakpoint
- Earlier batches: ComSat, Battlenet Tumor, Glue/Ui/WowServices fixes,
  luaL_error returns in Script_ files

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 16:51:23 +02:00
SatyandClaude Opus 5.5 2fc01591aa Fix bugs found by asmwalk/semdiff, add luaL_error returns, typed template tags
- luaB_getfenv: look up __environment metafield like 12340
- DSPSfxReverb::setParameterInternal: set mUpdate for REFLECTIONSLEVEL and REVERBLEVEL
- CGGameUI::DestroyTotem, Script_SetTotem: test the totem GUID, not unk_0004
- Missing return 0 after luaL_error in script functions
- OFFSET tags of template instances carry their instance type: [0xXXXXXX<Type>]

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 10:11:32 +02:00
SatyandClaude Opus 5.5 312ab9ac65 Port batch 1 missing functions and add missing luaL_error returns found by semdiff
Batch 1: weather templates, client console commands, loading screen paths,
glue script events, AddOns/AccountData/Battlenet getters, simple camera and
camera vehicle offsets, Warden module path, BLL loader, FFX effects, Grunt
and GruntLogin matrix/file handlers, CGlueMgr char customize/faction change/
kick reason.

semdiff: 251 Lua script functions called luaL_error without the return 0 that
12340 has after every call site (each confirmed per call site in the binary).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 05:48:17 +02:00
SatyandClaude Opus 5.5 b76f1b443a Port packs w3-w5: objects/vehicles, LCD stack, ComSat voice chat, map dtors, misc missing functions
- Object/vehicle/spell-visual/world/MapObj functions from pack w3
- Logitech LCD stack (CLCDBase..CLCDConnection, CLCDText/Bitmap/Page, CEzLcd, CEzLcdPage, CLCDUtils) and CGLCD
- ComSat client: voice start/stop, mute, sound group fade, tick, event dispatch; s_comsatCallbacks is a growable array
- ShipPath pause/offset, Transport state progress, vehicle bone anim/passenger removal, NetClient redirect
- Map class destructors (CMapArea/Chunk/DoodadDef/Entity/ObjDefGroup), CMapChunk +0xB4 is a TSLink
- Character rename/customize, ClientServices login/survey wrappers, glue Lua scripts, DayNight light overrides
- Template instance and deleting-dtor OFFSETs

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-03 03:16:42 +02:00
SatyandClaude Opus 5.5 7c83a8297a Port Ui missing functions: KB, AccountMsg, Minigame, Dance, EquipmentManager, InstanceEncounter, macro conditions, Trade, Rune, misc LeaveWorld handlers
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 18:37:56 +02:00
SatyandClaude Opus 5.5 d9e4c5f644 Fix signed/unsigned count types and KB luaL_error returns found by the harness
Counts the binary converts as unsigned (fild + jge + fadd 2^32) or signed
(sar, plain fild) now use the matching types; KB count scripts return
luaL_error's result like the binary.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 16:40:46 +02:00
SatyandClaude Opus 5.5 393769ff36 Port single-missing-function modules
LeaveWorld handlers, game object type checks, corpse/dynamic object
virtuals, loot/voice/macro helpers, declined words, ProcessAgreement,
ObjectCreateStaticEx, FFX death/fog-seed/nether-blur passes, software
snow renderer, streaming decal, QuestCache copy, trajectory encoder and
deleting destructor tags. Fixes the missing CMapStaticEntity destructor
model release.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 14:39:43 +02:00
SatyandClaude Opus 5.5 46b5adf64f Port FriendList, Player_C, Unit_C and GameObject_C modules
- FriendList: remaining methods and 28 Lua scripts, FriendListModuleLoaded
- Player_C: remaining functions incl. click-to-move (ClickToMove, CTMFace,
  CTMClickTerrain, CTMAttackUnit, CTMInteractGO), dance, virtual items,
  sound and skill-rank overrides
- Unit_C: tracking (HandleTracking and helpers, SetTrackingTarget/Direction),
  selection circles, spell visual overrides, mirror image, flag-2 changes,
  scale update, missile trajectory (ComputeMissileTrajectory,
  SendFinalMissileTrajectoryUpdate, StartMissileTrajectoryTargeting) and
  CMissileCollision (Init, unit ranking, hit spheres)
- GameObject_C: IsLocked, UseObject, TypeBase CanUseNow/CheckRange/Use/
  CanChangeCursor, Ritual and MeetingStone types, virtual overrides,
  property helpers named from the binary's property table
- Dependencies: ProjectTex::Render2d, weapon trail chain (SWING,
  WTOBJECT::SetDrawTrail), GxSwizzleColor, CAaBox::Expand/Center,
  CVehicle_C::PlayBoneAnimOrFallback, RuneInfo/PetitionInfo/ClassTrainer/
  ComSat helpers, CalendarEventTables ctor
- DBCache: InvalidateIntKey, RetryItem, SetTemporary, ~DBCACHEHASH
- Template instances, deleting dtors and TSHashTable/WowClientDB instances
  recorded in their OFFSET lists

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 12:07:58 +02:00
SatyandClaude Opus 5.5 bbf3de4926 Record skipped template instances and ChatChannel ctor
Template instance addresses added to stpl.h (TSList::UnlinkNode,
~TSHashTable deleting destructors, TSGrowableArray::SetCount,
~TSFixedArray) and WowClientDB::GetRecordByIndex. ChatChannel default
constructor 0x502960 ported (user-provided: sets +0x9C/+0xA0 to 1).
M2Shared.cpp: VERIFY re-stamp only.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 09:11:39 +02:00
SatyandClaude Opus 5.5 74f50d713b M2Shared: allocate x64 .anim and vertex overflow buffers near m_data
M2Array stores a signed 32-bit self-relative offset. On x64 a separate
heap block can lie more than 2 GB from m_data, so relocated low-priority
.anim sequence data wrapped and crashed in ProcessEventCallbacks.

Add OsAllocNear/OsFreeNear (Win64): reserve a block within 1.5 GB of an
anchor. x64 now uses it for .anim buffers (load, cancel, destructor) and
for the skin vertex overflow, which again follows the Win32 structure
(m_flags |= 8, freed in ~CM2Shared). Texture combo arrays keep growing
m_data. All new code is under WOWDECOMP_ARCH_64.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 08:35:26 +02:00
SatyandClaude Opus 5.5 0470ad7933 M2Shared: x64-safe combo/vertex arrays, ignore runtime header bits from files
- x64: texture combo, transform combo and converted vertex arrays are
  appended to a grown m_data buffer instead of separate heap blocks, so
  the self-relative 32-bit M2Array offsets always reach them; they are
  freed with m_data (destructor frees only on Win32)
- FinishLoading clears header bits 0x20/0x40 from the file; the client
  uses them to mark arrays it allocated, and later-expansion models set
  them, which made the destructor free a pointer into the file buffer

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 07:11:14 +02:00
SatyandClaude Opus 5.5 e9c8ecab21 Add WOWDECOMP_DISABLE_SIGNATURE_CHECKS build option
When ON (DISABLE_SIGNATURE_CHECKS=1), the client skips the signaturefile
MPQ MD5 checks, FrameXML_CheckSignature reports .toc files as valid with
the digest of the files on disk, and GlueXML, FrameXML and AddOn loading
skip their post-load digest comparison. OFF keeps the original checks.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 06:54:51 +02:00
SatyandClaude Opus 5.5 6027112a59 Port stand-ins after run 85: UI script modules, AuctionHouse, Commentator
Ports the stand-ins hit since run 85 and the follow-up script batches:
RaidInfo, PartyFrame, BarberShop, ArenaTeamInfo, SkillInfo, InputControl,
petitions/guild registrar, ItemText, Tutorial, ContainerFrame, QuestLog,
ActionBar, ClassTrainer, UIMacros, GuildBank, AuctionHouse and Commentator.

Fixes found on the way: AuctionHouse sell items are a fixed inline array
(IsItemForSell read garbage), GetSellItem returns the container GUID,
Commentator instance key is read/written as u32/u16/u8 and skirmish
commands send a u32 flag, GetArenaMember returns uint64 in edx:eax.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 04:14:58 +02:00
SatyandClaude Opus 5.5 6a3666e4b6 Port run-83 hit stand-ins and fix phantom terrain walls blocking movement
- Fix CMap::GetChunkFacets: impassable test uses the chunk MapObjFlag
  (MAPOBJ_FLAG_IMPASSABLE at +0xC) like 12340, not MCNK header flag 0x40
  (vertex colours). Most chunks got 32000-high wall facets, so the player
  could jump but not walk.
- Ship paths: GetPosition, path time, accel/decel distance, roll/pitch.
- Transports: Transport::UpdateMovement, CollideWithTransport, owner matrix.
- Map objects: IsAllLoaded, footprints, TriData query chain (QueryTris,
  GetTrisTerrain/Chunk, GetTriSubchunk, QueryTrisMapObjDefs),
  QueryIntersectingModels.
- Water ripples, projected-texture shadow drawing (shadow.cpp).
- World states, LFG best random dungeon, quest POI, ComSat session lookup,
  blood record, virtual items, guild roster query.
- Logout path: tradeskill close, LCD, DBCache_ClearPending, chat/macro/
  saved-variable/account-data saving, tracked quests/achievements/
  tutorials, UnloadAddOns, SaveAddOnEnableState, ~CGWorldFrame,
  SmartScreenRectShutdown.
- Fixes: TriData batch heights stored as float* (was truncating uint32 on
  x64), TimeInRange is a ShipPath member, ComSat lookup takes the session
  type, roll/pitch names swapped in MapObjTransport::UpdateMovement,
  removed windows.h from Object/Passenger.h.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 15:33:24 +02:00
SatyandClaude Opus 5.5 f24e731415 Port hit stand-ins: unit swim/flight/vehicle, footprints, shadow query, liquid sounds, weather, world states, game object types, friend list packet
Old list #26-#77 and new list #1-#25: unit movement/vehicle passengers,
missile trajectory, trade skills, corpse/spirit healer UI, map flight
bounds, footprints, low detail render, shadow query gather/render,
CMapArea liquid sounds, weather type/pos deltas, world state init/set,
transport/chair/animated game objects, contact list packet, macros,
tracked achievements, tutorials, dungeon difficulty.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 10:10:31 +02:00
SatyandClaude Opus 5.5 37d966a503 Port hit stand-ins #1-#23: LFG, autocomplete, nether/fog FFX, BN friends, skills, account vars, macros, area triggers, FriendList, auto mouseover, GameUI message handler
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 08:02:45 +02:00
SatyandClaude Opus 5.5 9ddddebc34 Port minimap, item moves, cursor, character info, names, nameplates, combat text
- Fix RsSet render-target upload check (indoor rendering corruption)
- Minimap tracking/hover, world map refresh
- Bag/bar item moves, swaps, equip, item sounds, spell on cursor
- Character info stats, titles, model preview
- Unit/player names (PLAYERNAMEDESC render, name strings, raid icons)
- Nameplates: CGNamePlateFrame, CGSimpleHealthBar, unit glue, SmartScreenRect overlap solver
- Floating combat text: WORLDTEXTSTRING, render batch, PlayerName text slots
- Fix unescaped raid-icon texture path in PlayerNameInitialize

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 07:00:36 +02:00
SatyandClaude Opus 5.5 175f55b399 Port spells, loot, effects, missiles, level-up and non-gameplay UI stand-ins
Gameplay:
- Spell system pieces, spell effects lifecycle (CEffect), special effects,
  procedural/loot effects, impact visuals
- Unit anim events: AnimEventCallback, HandleAnimEvent, HandleCombatAnimEvent,
  parry anims, vehicle bone grab/throw events
- CGUnit_C::CreateMissile (target, point, point-array overloads)
- Loot: CGLootInfo/LootWindow/LootDisplay, loot rolls, loot packets and scripts
- Bags/items: FindItem, container/inventory mirror handlers, UseContainerItem
  (sell/bank/mail/trade/auction/guild bank), UseItem, item lock/unlock
- Threat, power regen, XP gain, quest item updates, skill changes
- Packet_Group_9 (level up, item push, exploration, taxi, bind, roll, ...)
- ChatBubbleShow/Remove
- x64 fix: map entity callback param is uintptr_t (pointer was truncated)

Non-gameplay (parallel batch): chat channels/settings, chat bubble frame,
game/server time, minimap POIs and init, mail, class trainer, skills,
achievements, currencies, calendar, world states, world map arrow/ping,
commentator, merchant buyback, battleground/arena info, EnterWorld for
~15 UI modules

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-01 03:06:16 +02:00
SatyandClaude Opus 5.5 b5ee377ba5 Tooltip: port spell tooltip, spell description parser and formula engine
CGTooltip::SetSpell (split into inlined section helpers), Lua SetSpell/SetSpellByID,
QuestTextParser spell text parser, MathState formula engine with MATHOP enum,
spell math (min/max points, duration, cast time, range) and talent tooltip text.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 08:00:10 +02:00
SatyandClaude Opus 5.5 3b76648777 Client bring-up: Lua stand-in ports, add-on loading, world map, combat log, locale fix
- Port hit-order Lua stand-ins (unit tokens, tooltips, combat log filters and
  current entry, bags/containers, quest POI, minimap, titles, world states,
  trade, group roles, runes, mirror timers, saved-variable registration, Quit)
- LoadAddOn: real add-on loading (Blizzard_CombatLog etc. now load)
- CombatLogEntry::PushEvent: COMBAT_LOG_EVENT arguments
- World map chain: SetMapToCurrentZone, SetMap, GetWorldPosition, landmarks,
  overlays, highlight, zones, dungeon levels, player position
- OpenArchives: locale index was off by one (enUS read the koKR DBC slot,
  leaving zone/map names empty)
- Zone/area sound chain, invisible units (spline mode read size), raid/bag
  crash fixes, stand-in console, waystone icon for all executables
- Coding-rule cleanups: statics/includes at the top, event enums, Lua
  _Scripts layout

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 06:31:10 +02:00
SatyandClaude Opus 5.5 18c46cb87e Client bring-up: in-world camera, input, movement, unit rendering
Ports verified against 12340 that take the x64 client from character
login to a playable world:

- Camera: SetView/ResetView, motion, free-look facing, tracking, bobs,
  liquid bump, world collision; camera Lua scripts
- Input: world frame key/mouse layers, default action, mouselook,
  turn/pitch player, TurnOrAction/CameraOrSelectOrMove scripts
- Movement: legal facing range, turn/pitch/raw facing events, transport
  status, move spline copy, unit update info, smooth facing, anim end
- Units: component and extended display init, model fade/scale,
  entity sort table, RenderEntitys, split-body culling
- Interiors: WMO group bounds, BSP segment link query, face linking,
  interior lighting
- Collision: CMap::QueryFacets closure with frustum queries and NDCClip
- UI: game UI mouse filters, client control state, faction standing
  packet, many *_Scripts.cpp Lua tables; name generator dictionary fix

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-29 23:04:53 +02:00
SatyandClaude Opus 5.5 3b857f3eb0 Object port: object classes, object manager, input control, WOWGUID type
- CGObject_C base, CEffect, CObjectEffect/CObjectEffectManager effect states
- Unit, Player, Item/Container/Bag, Corpse, DynamicObject, GameObject and
  all GameObject type classes (vtables matched slot by slot), Movement,
  MovementShared, Missile, Vehicle/Passenger/Camera, combat log, caches
- Client object manager (0x4D3100-0x4D7880) incl. SMSG_UPDATE_OBJECT,
  SMSG_COMPRESSED_UPDATE_OBJECT, SMSG_DESTROY_OBJECT; type ctors/PostInit
- CGGameUI::CanPerformAction and the ready part of CGInputControl
- Layouts named from descriptor fields and code; CM2Model 0x134 matrix,
  CClientObjCreate tail, CGUnit_C/CGPlayer_C sizes 0x1008/0x1958
- WOWGUID struct replaces the IDB's WGUID low/high pair and guid uint64_t;
  SmartGUID derives from it; member functions returning a guid keep
  uint64_t (MSVC returns class types from members via hidden pointer);
  structs with 4-aligned guids in 12340 use pack(4)

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-29 12:27:05 +02:00
SatyandClaude Opus 5.5 4a571e727c World port: WMO water, fog, area updates, purge chain, detail doodads
- Barriers, shadow/portal queries, underwater selection, hit testing
- Interior water: PolyClipper, ClipGroupGeometry, liquid index fix
- Area updates, barrier updates, purge/free chain for areas, chunks,
  doodad and map object defs, detail doodad update list
- Water ripples, terrain pixel shader path, liquid shader toggles
- Detail doodads: creation per chunk, pools, batching, vertex/index
  fill, shader and fixed-function render state, RenderDetailDoodads
  (trailing occluder/debug draws still to port), CMapChunk::SelectLights
- DayNight moved to WoW/Source/WorldClient
- MapViewer: fog, WMO water, detail doodads; diagnostics removed

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-29 07:43:15 +02:00
SatyandClaude Opus 5.5 f6d07ea346 World port: liquids, map load chain, terrain rendering in MapViewer
Liquid system ported from 12340 (LiquidSystem module, chunk/WMO liquid, wave
manager, geometry factories); CMap load chain (Load, LoadWdt, low-detail WDL,
lights, CreateMapObjDef, PurgeMaps); CMapChunk create/batch/vertex/index code;
CMapRenderChunk; frustum stack and scene cull helpers. MapViewer renders
terrain through a viewer-only shortcut (ViewerWorld.cpp). Engine fix: int
render-state setters write the full pointer-sized slot (x64 texture crash).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-28 08:07:38 +02:00
SatyandClaude Opus 5.5 d39896a422 Move CWFrustum to Tempest; remove unused SHA1Broken and XML headers
- CWFrustum (CFrustum + free-list link at 0xF4, RTTI .?AVCWFrustum@@) moves from
  _Triage to Engine/Source/Tempest; the redundant forward declaration is gone
- _Triage/SHA1Broken.h and _Triage/XML.h had no users

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-28 02:53:08 +02:00
SatyandClaude Opus 5.5 095603ff2b Client bring-up: login, realm list, world auth, character select
- Grunt login ported end to end (SRP6 challenge/proof, version checksum,
  realm list) and tested against a live server: authenticates, connects to
  the world server (auth session with proof-of-work, header crypt), receives
  the character list and shows character select
- Glue: realm list UI, character select (list, models, scripts), character
  create screen + name generator, delete/rename/decline, Enter World up to
  the loading screen; loading screen drawing and progress
- AccountData (times, update, upload/download), BannedAddOns, addon scan and
  addon info, client cache version, tutorial flags
- Shutdown path at login state: world/map/liquid/weather teardown, NetClient,
  ComSat, streaming stop; Logitech LCD no-device path in Ui/UILCD/Windows
- PCRE 5.0 vendored (core stock; chartables and the posix layer from 12340),
  ValidateName
- Fixes: TSGrowableArray::CalcChunkSize clamps to >= 8 (crash on char list),
  CWorldScene liquid renderer allocation, CMapFootprintTexture element ctor,
  pointer render states on x64, CFrustum/CWFrustum layout, M2 draw callback
  arguments, 37 class/struct forward-declaration mismatches
- IDB name sync (1217 names), verify aliases, harness large-element
  instantiation

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-28 02:39:56 +02:00
SatyandClaude Opus 5.5 2e418f9e08 Client bring-up: glue screen, EULA/TOS, shutdown chain, LCD, x64 fixes
- Stand-in client reaches the glue screens (intro movie, EULA/TOS accept,
  login screen) at 16:9; stand-ins are report-only on x64
- Ports on the startup/idle path: GlueScriptEvents/CharacterSelection/
  CharacterCreation/RealmList/AccountMsg/VideoOptions _Scripts, CGlueMgr
  (Initialize/Resume/Idle/Accept*/Shutdown), ClientServices, NetClient/
  WowConnection, DBCache + instances, WorldParam/World/Map/Liquid/Weather/
  shadow, InputControl, Scrn, ConsoleClient, SysMessage, LoadingScreen,
  SystemRegisterFunctions, CGameTime, Screen::GetAspectRatio
- Shutdown chain: BeginCloseGame, DestroyEngineCallback, DBCache save/
  destroy, SpellVisuals/Effect/World/Glue teardown
- Logitech LCD no-device path in Ui/UILCD/Windows (Windows-only dir);
  lgLcd is a stub library in ThirdParty/lgLcd
- CVar and console commands split into <Module>_CVar.cpp / _Console.cpp
- DivxDecoder.dll (Win32, original) and XvidDecoder.dll (x64, port with
  vendored xvidcore) both copied to the build folder
- Warden: Win32 faithful port, Win64 stub
- x64 fixes: lua_newstate gcusage/gctime init, pointer render states reset
  with nullptr, g_rndSeed defined
- 37 class/struct forward-declaration mismatches fixed (false stand-ins)

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 21:47:34 +02:00
SatyandClaude Opus 5.5 472530e785 Client bring-up: WinMain to event loop, Engine/FFX port
Tool client (Tools/WowClient) with generated stand-ins now runs
InitializeGlobal completely: config, locale, MPQs, signature file,
hardware detect, D3D device, Storm log. Stops at InitializeEngineCallback.

- entry start 0x401000 (StormRtlInitialize before CRT), /ENTRY:start
- ConsoleDevice + ConsoleDetect module, GxDefaultApi
- SFile signature path (ClearAllFileFlags, SetFileSignature, HashMap insert)
- WowLogHeader + helpers, SMemIsValidPointer, ClntObjMgrIsValid
- ConsoleWrite line list, CGObject_C vtable declarations
- crash handler prints symbolized x64 stack
- Engine/FFX port (FFX agent), Pass headers moved out of _Triage

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 17:23:27 +02:00
SatyandClaude Opus 5.5 6ee0c14d69 Verify remaining functions; SI2::ChaosModeUpdate; SE2::StopAllSounds arg
ChaosModeUpdate (0x4C74F0) reordered to the binary's switch case layout
and case 15 written as 8 statements; verified. SE2::StopAllSounds takes
the unused int every 12340 caller pushes. Approval stamps for the
functions unblocked by the IDB splits (Button/Checkbox IsA, Checkbox
dtor, CSimpleFrame::NotifyDelayedLoad, CGxDeviceD3d9Ex ctor,
CM2Cache dtor) and for the re-reviewed IsSequenceLoaded,
OsGuiMessageBox, TexturePickAlternateFilename, three FMOD ctors and
luaG_concaterror.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 15:51:40 +02:00
SatyandClaude Opus 5.5 34770ee7ab Frame: port Engine/Frame (waves 1-4), 1667 of 1669 functions
Core (CSimpleFrame + Lua, CSimpleTop/CFrameStrata/CSimpleRender/
CRenderBatch, CSimpleRegion/CBackdropGenerator/CScriptRegion), animation,
text (FontString/Font/Fontable), texture and model, buttons, EditBox,
MessageFrame/MessageScrollFrame, MovieFrame/ColorSelect/StatusBar,
Slider/ScrollFrame/HTML/HyperlinkedFrame, all Lua method tables and
RegisterScriptMethods. Layouts, vtables and sizes rebuilt from the
12340 ctors, vtables and allocator initializers; CScriptObject vtable
slots 5/6 fixed; CSimpleFontedFrame is a real secondary base. Lua error
paths return after luaL_error as in 12340 (209 sites; 5 fall through).
Binary quirks kept and documented in docs/.

Supporting additions: Event key/char/ime/focus/size event headers,
Scrn/Scrn.h (ScrnLayerCreate), DivxDecoder import declarations,
C2Vector/CRect helpers, CM2Light dtor, OsInputEnableSecureMode, stpl.h
instance addresses, FrameXML LoadXML_AnimGroup/Create_SimpleMovieFrame.
Engine->WoW includes where 12340 calls directly: CSimpleModelFFX,
StringToMouseButton, GetDeclinedWord, EmblemTextureUpdate.

Also drops stale VERIFY stamps found invalid by the harness recheck.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 15:32:18 +02:00
SatyandClaude Opus 5.5 7c1b3b9858 WoW/Common: WowTime, TextureCache, Lightning, AaBsp, ComponentCore
272 definitions, 111 pass and 161 approved with per-function reasons,
0 fail. CCharacterComponent and ComponentUtils started from the
thunderbrew port and were checked against 12340: adds the threading and
compression paths (CComponentRequest, CComponentMipBits, SSE and scalar
DXT1 compressors), static cdecl helpers, bool SetRandom*, signed prefs
modulo, fixed main/off-hand sheath links. CLightning/CLightningManager
moved here from Services (Common\Lightning.cpp); SetCount fixes the
never-filled joint arrays, alpha rounds via fint_. ItemDisplayInfoRec
ctor carries the folded GetRow OFFSET; 0x4F1650 joins the stpl.h list.
Stand-in declarations in World.h, ComponentData.h and Player_C.h.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 05:02:09 +02:00
SatyandClaude Opus 5.5 d02b135887 BlizzardCore: SFile::FileExists and FileGetIsLocalAmount
Ports SFile::FileExists (0x424E50), SFile::FileGetIsLocalAmount
(0x4217E0) and the Mopaq helpers SFileGetFileDetails (0x460F00) and
SFileGetIsLocalAmount (0x461040). The older 0x421FC0 FileExists is
renamed FileExistsInArchives. Blizzard::Streaming::GetIsLocalAmount
(0x44F370) is declared only; BlpTest, DbcTest and MpqTest get stand-ins
so they link.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 05:02:09 +02:00
SatyandClaude Opus 5.5 2df85b1eb9 fmodex: define FMOD_DEBUG_DISPLAY_THREAD for the Debug build
fmod_debug.cpp (compiled only with DEBUG) uses the thread-id display
flag; 4.09's fmod.h lacked it. Defined as 0x08000000, the unused bit in
FMOD_DEBUG_DISPLAY_ALL (0x0F000000). Not in 12340 (release lib).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 04:03:46 +02:00
SatyandClaude Opus 5.5 c1b17906f2 Frame: link freetype for the Gxu font headers
Frame now includes GxuFont.h (freetype/freetype.h), same as Services.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 04:00:29 +02:00
SatyandClaude Opus 5.5 311c63bdf7 Frame: round 2 - script registration, CScriptRegion, render batch, leaves
SimpleFrameScript_Scripts.cpp (7 Lua functions, register/unregister),
CreateScriptMetaTable/DestroyScriptMetaTable, IsA, GetObjectTypeName and
GetScriptMetaTable for 25 classes with their statics. CScriptRegion dtor,
LoadXML, anim hooks and its 25 script methods; UnflattenFrame, DragBy,
GetRectFramePoints (0x512410, name ours); CRenderBatch and the strata
node; small CSimpleFrame/CSimpleTop/FontString/Texture/Font leaves.
Anim-family, CSimpleTitleRegion and CSimpleMovieFrame headers rebuilt
from the binary. Frame includes CSimpleModelFFX.h because 0x81B870 calls
CSimpleModelFFX::CreateScriptMetaTable directly. Button/Checkbox IsA
unchecked until the IDB splits 0x9621E0-0x962300.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 03:15:03 +02:00
SatyandClaude Opus 5.5 c18774684b Gx: port remaining CGxDevice, D3d, D3d9Ex, OpenGl and draw-list code
474 definitions, 0 fail; only the CGxDeviceD3d9Ex ctor is unchecked
(IDB has it as a chunk of NewD3d9Ex). Adds the Gxu draw-list module,
GxScenePresent, GxDevDestroy, OpenGl VBO broker and GlExt (moved under
CGxDeviceOpenGL). Binary-backed fixes: GxTexCopy tests m_renderTarget,
TexStretch compares widths first, fullscreen style 0x87000000, pixel
format reject mask 0x50, DeviceOverride case 0 field, filter constant,
D3d9Ex window class name, four thiscall members. Draw-list enums moved
from WoW Ui/Types.h to Gx/Types.h. OpenGl linked on WIN32.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 03:11:20 +02:00
SatyandClaude Opus 5.5 e2038cdec5 Services: port Profile, TextBlock, Camera, particles and ribbons
Profile, TextBlock, Camera (+CameraInt.h), ParticleSystem2 (emitters,
track sampling, sort queue), RibbonEmitter, GfxSingletonManager managers
and the v1 CParticleEmitter destructor. All pass or approved with
explained diffs; 0 fails. Callee-cleanup helpers declared __stdcall,
float->int paths use CMath::fint_ (binary uses fistp). CLightning fields
named only; it is WoW/Common code. _Triage CAngle removed, Camera.h
repointed to CameraInt.h. CM2SceneRender Render calls cast for the new
signature. Services links freetype for the Gxu font headers.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 03:08:52 +02:00
SatyandClaude Opus 5.5 9243e0507a SoundInterface: port SI2 into WoW/Source/SoundInterface
232 SI2 functions (0x4C5900-0x4D2780 plus the DSP, voice chat, zone sound,
advanced kit property and internal code), in files named after the 12340
__FILE__ strings (SoundInterface2*.cpp) and best-guess splits after the
Mac SI3 files. Replaces the _Triage shells. External WoW callees are
declared only (GameTime, DBClient, Unit_C, Item_C, ObjectMgrClient,
ChatFrame, GameUI, CGWorldStateInfo, ComSatClient, SFile name overloads)
and tracked as open items.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 03:07:31 +02:00
SatyandClaude Opus 5.5 432e950eee SoundEngine: SESoundUserData base destructor and empty Release
The base vtable 0xAABB60 has an empty Release (0x5EEB70), not a pure one;
the destructor maps to its scalar deleting destructor 0x9C1820.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-27 03:04:04 +02:00