263 Commits
Author SHA1 Message Date
Martin BallandClaude Opus 5.5 8a047c333b mcp: --connect=… gets the --connect refusal, not unknown option (#7186)
Co-authored-by: Claude Opus 5.5 <[email protected]>
2026-11-21 10:55:17 +00:00
70ecef86df #7124: mcp refuses to start without both automation roots, and refuses --connect (#7157)
* #7124: mcp refuses to start without both automation roots, and refuses --connect

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* #7124: control protocol says --connect is refused; test folder comment matches

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* #7124: refuse --connect without a value; test folders removed by Drop guards

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* #7124: scratch folders retry only a name that exists

Scratch::new and Folders::new retried every create_dir failure, so a
missing or read-only temp folder looped forever instead of failing the
test (CodeRabbit). Retry only AlreadyExists; any other error panics with
the path.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* #7124: mcp's headless session is built by a function the unit tests reach

SonarCloud's new-code coverage was 57%: the session set-up after the
root checks ran only in the subprocess integration tests, which coverage
does not see. headless_mcp builds the confined session and applies
--author; mcp_headless_session_takes_the_author_flag covers it without
confining the test process.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

---------

Co-authored-by: Claude Opus 5.5 <[email protected]>
Co-authored-by: FredApps <[email protected]>
2026-11-21 10:08:42 +00:00
685869239f Proofing: support freestanding custom.dic dictionary files (#5840) (#5899)
* Proofing: support freestanding custom.dic dictionary files (#5840)

- Add freestanding custom dictionary loader and saver in custom_dict.rs
  supporting UTF-16LE with BOM, UTF-16BE with BOM, UTF-8 with BOM, and UTF-8.
- Detect BOM-less UTF-16LE via NUL-byte heuristic and preserve encoding on save.
- Preserve original dictionary lines and casing (NASA, McDonald, multi-word
  lines, lines > 64 chars) and merge disk additions on save.
- Add bounded reading (4 MB and 100,000 words limit) and graceful error handling.
- Validate read and write access, probe OS write permissions, and reject
  symbolic links and read-only files in check_regular_file_setting.
- Add customDictionary preference in file.options and Proofing options UI.
- Provide wasm fallbacks in crate::io.
- Add comprehensive engine integration, UI Kittest, and unit regression tests.

* Proofing: keep a bound custom dictionary as the source of truth (#5840)

- Do not restore the ui.json word backup when customDictionary is set, so a
  missing or unreadable file cannot leak its words into custom-dictionary.txt.
- Document the supported encodings, write-access checks and logged save
  failures for the review.
- Add a UI regression test for the backup words.

Co-authored-by: CommandCodeBot <[email protected]>

* Proofing: decode a custom dictionary before applying options (#5840)

file.options validated the customDictionary path's metadata but read the
file only while applying settings, so a writable file with malformed
UTF-8 refused the call after author, initials, units, region and
dictionariesFolder had already changed. Decode the requested file (and
the default one for auto) alongside the other parameter checks, then
apply nothing if it fails.

Regression: refused_custom_dictionary_leaves_every_other_option_unchanged
compares every setting, the bound path and the proofing words before and
after a combined refused call.

* Proofing: preserve custom dictionary persistence target during fallback (#5840)

* ROADMAP.md: remove conflict-resolution debris

* Format the custom dictionary tests

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* Commit the custom dictionary path on Enter, and test the startup fallback

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* Show the saved custom dictionary path when no edit is open

Co-Authored-By: Claude Opus 5.5 <[email protected]>

---------

Co-authored-by: CommandCodeBot <[email protected]>
Co-authored-by: batistalucasv <[email protected]>
Co-authored-by: Claude Sonnet 5.5 <[email protected]>
2026-11-20 20:37:12 +00:00
Martin BallandClaude Opus 5.5 b5e0be7879 Port the UI onto the craft framework (#7101)
* canvas-w21: net change of 3 commits

- canvas-w21: written from its sheet
- canvas-w21: repair 1
- canvas-w21: review fixes (review-1)

* chrome-w8: net change of 2 commits

- chrome-w8: repair 1
- chrome-w8: review fixes (review-1)

* mini_toolbar tests: import egui pos2 and Vec2 the tests use directly (production imports only Rect, Ui)

* App compile: open context_menu, font_box and ribbon::common to their callers; Label and Value import from their framework homes; balloons read command_enabled; wordart test runs fired commands through WordApp::run_fired; delete rtl.rs, which has no reader

* Fix imports (palette, picker, icons, color), expose find helpers, drop old keytip phase state per S-L365

* keytip_places: removed with the old keytip phase machine (S-L365); WordApp, WindowUi and the destructurings no longer carry it

* ribbon submodule imports: Value, Target, Remember, egui geometry, Label, TypeRole, DisclosureGlyph and kittest Node come from their own modules, not the ribbon.rs re-exports ribbon-w8 dropped

* context menu: CanvasState keeps the open point so the menu anchors where it was asked

* Palette derives Default: dialog forms hold an empty palette until prepare fills it

* ribbon: Stack/Row/Menu show need ShowContainer in scope

* canvas Read Mode: reading metrics come from a probe component measured under the theme (S-L355)

* Dialog and mini toolbar call sites follow the framework: Mode into style previews, owned colour key, non-exhaustive DialogResult, struct EditEvent variants, IconButton::command, Props::command on bound toggles

* canvas: the mini toolbar shows inside the page view body, where it maps its anchor through the canvas view

* ribbon: runtime labels as owned Strings, Props in scope for MenuItem::label, RibbonGroup icon 'static

* Tests read the canvas zoom through CanvasState::zoom and pass the context to qat_enabled

* More Colors settle hook returns Settle (S-L280) so it registers as a DialogHooks settle

* ribbon: wordart/shapes galleries take the menu body cx; TextRun built with its builders; symbol tile paints centred by the run's alignment; paint_style gets the content painter cx

* math pictures: MathSource takes an aspect and sizes its layout box from the thumbnail request, with thumb_aspect for the tile or button (S-L393)

* CatalogRef: Debug says whether a catalog is held, since the framework's Catalog has no Debug

* mini toolbar tests: read accessibility labels and popups through kittest's NodeT::accesskit_node

* tests.rs: readers move to the framework and canvas accessors that exist (ScriptedFiles held/queue/answer_to, Host::builder, page_rects()/canvas_rect(), drain_inbox, DefaultAppError, pixel-sized auto_scale_limit_over, ClipItem::Image, DropTarget::Elsewhere, dialogs::close_all)

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* Reading probe returns an Outcome output; context menu rows label via MenuItem::new; colour preview matches cover non_exhaustive Preview; mini toolbar toggle icon is static

* fu2-app: app batch 2 rulings on batch 1 sets (S-L412, S-L365, S-L410, S-L411, S-L414, S-L419, S-L372, S-L368, S-L364)

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* Ribbon menu rows take owned labels: framework Label is String or 'static str, not a borrowed &str

* QAT command menu request drops the removed opener field

* Colour child answer: DialogResult is non_exhaustive, so any other result is ignored

* Thickness menu face: Button has no icon_only, so it shows icon and label

* Tests: By filter helper with an explicit lifetime; accessibility label compared as Option<String>

* lead: last compile fixes (menu label lifetime; perf test reads the page view's resident pictures, S-L352)

* lead: binary compile fixes (egui DroppedFile trait, Lang accessor, print test binding)

* lead: dropped file bytes as Arc

* lead: examples reach the framework through craft:: (S-L230)

* lead: examples reach the framework through craft::ui::shell::embed (S-L230)

* lead: ui_shot example runs its main under the test build cl uses (harness = false)

* rr-app-ribbon: the ribbon slots are sized by their content (SlotSize::Content)

The default top slot is one options bar high with a one-line layout: the ribbon's groups landed beside the tabs and all
collapsed. Needs the framework's SlotSize::Content (branch red/ribbon-place).

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* app tests: one harness that installs the craft runtime before the first frame

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* lead: WordApp::new registers the app icon set (ribbon-w13 icons::register had no caller)

* red app-t2 g4: tests step with the app's command input; print preview is a group; neutral SmartArt error

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t2 g6: tests step with the app's frame input; integrated frame for the title-bar test; undo list caps rows; table press hold released; test clipboard answers files

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t2 g3: dialog collections cap their rows, tests give dialogs their context and focus, glyph scan skips test data

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t2 g5: tests step frames through frame_input; split-button arrows named; collections capped; stale premises rewritten

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t2 g8: closing guard outlives window swaps, root focus/close, web save undo, collections natural height, test premises

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t2 g2 (lead commit)

* red app-t2 g1 (lead commit)

* red app-t2 g7 (lead commit)

* lead: backstage test row query borrows the name as long as the harness

* red app-t4 g2: key tests step through the app's frame hook; draw paths read format state without running a command

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t4 g8: custom dictionary caps its rows; chrome/language-pack tests press as a person does; sources test steps through the frame hook; audit and pane tests follow the framework's layout

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t4 g3: dialog test premises and Custom Properties labels, colors route, macro names, bookmark delete

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t4 g6: md_source focus waits for a non-measuring pass; window rig reports inner rects; smoke sends a close request; switch windows label; i18n tests

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t4 g5: table borders above selection areas, ruler markers follow drags, proofing list click-activates, test premises (focus, Enter=OK, extra buttons stay open)

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t4 g7: failed web save keeps clean state, symbol dialog fields, table margin hold release, object release keeps Alt placement, test premises (toggle off, Escape chord, CJK glyphs, palette swatches, frame gesture)

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t4 g4: frame hook in keytips tests, held list previews, crop keys and handles, read-mode context menu, keyboard overrides notes

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t4 g1: frames run the app's input hook and close path; page focus survives measuring runs; stale prompt dropped; recipients/styles collections capped

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* look-backstage: File pages as production: menu rows at the reading start, Discord above About, page titles over sections, Info property labels, Print preview fills the page

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* look-dialogs-b: TOC levels label, Options/Modify row and sample card metrics; watermark layouts in a row; About listed layout and version line

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* look-ribbon-1b: Styles gallery tiles are 2:1 and named under the sample; Paragraph shows whole at 1440 pt

The style gallery asks the framework gallery for 2:1 pictures (the sample crop, STYLE_TILE_W, at the
medium thumbnail height) with the style's name under each, instead of square tiles that shrank the
sample. A test pins the Home tab showing the Paragraph group whole in a 1440 pt window (framework:
red/ribbon-look's ribbon place, short font and size boxes, flat close ribbon buttons).

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* look-backstage: the File side menu is as tall as the window (Sizing::FillHeight), About and the community link at its foot

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* look-chrome: title in a native frame; status bar view icons, fonts warning icon, plain zoom rail

The title bar shows the document title under the OS's title bar too
(TitleBar::title_when_native), as the old bar always did. The status bar's
view buttons are icon-only toggles in the old order (Read Mode, Print Layout,
Web Layout) with the current view pressed; the missing-fonts item has its
warning icon; the zoom slider has no fill up to the thumb. Tests
the_title_shows_in_a_native_frame and
status_bar_view_buttons_are_icons_with_the_view_pressed.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* look-backstage: File page controls at stacked-row spacing, as production's

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* look-backstage: one contract import in pages.rs

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* look-dialogs-a: Zoom opens on the view's percent (fraction x100), radios in a row, slider with its field inline, fit buttons in the body; Word Count as a plain label/count table over Close and Cancel; Font dialog as the old framed boxes: label table, kerning size and Points and above on the check box's line, Effects two to a line, preview at its own size; tests

* backstage test: import NodeT for accesskit_node

* red app-t5 g6: window rig reports the real child, ruler drags free of the framework snap

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t5 g4: smoke drops texture deltas, md_source tests step the hook frame, font list rows are tree items, Escape closes bar then menu, symbol pick confirms twice

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t5 g5: rotate objects about their centre, CJK stand-in in ribbon fit test, caret blink restart, Switch Windows node pair

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t5 g7: nav lists take natural height; menu/keytip tests step the frames the runtime needs

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t5 g8: Size dialog tests step through the app frame hook, Styles pane test scrolls its capped list, pack tests end the agent's injection

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t5 g3: dialog tests read the page's preview, the input hook, framework About key; Alert on refused custom property; Text Pane focus via framework stop

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t5 g1: harness hands app input before the pass; confirm via passes; pane/close/clipboard test premises

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t5 g2: keys tests follow the framework's IME ordering, interrupt and reset; undo folds an open SmartArt run; join survives a later pass

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* look-rest-2: File side menu rows in the side menu place at the side menu's width (production's 200 pt rail of 38 pt rows); Print settings column wraps its notes at the column width

* look-rest-2: side menu imports formatted; test pins the rail's width and row height

* panes test: MouseWheel carries its source

* red app-t6 g8: ribbon end order, cjk stand-in any family, capped findings list

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t6 g6: smoke finds the platform's answer button, info/side-menu tests use the framework's mechanisms, pack-bar click settles

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t6 g3: menus open from their opener, view buttons given, caret test animation time, switch windows rows

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t6 g2: icons dialog owns its scroll, effects grid fills, search opens in place, macros press runs once

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t6 g5: symbol pick OK, md pane Undo/Redo enabled by the field, live rotation pixel preview, text-box turn tolerance

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t6 g7: mini_toolbar and table_resize tests settle on the framework's layer and marker timing

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t6 g4: Alt+Q row follows the engine's build-time binding

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t6 g1: CJK stand-in in the shared harness, late-paste test clipboard, web-layout gutter, search dropped in Focus, split-button and held-Return tests

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* look-rest-3: Print settings column as production's: one Pages heading over both page lists, the page count muted, a rule above the export formats; Word Count rows a control's height apart

* look-ribbon-3: Design's style-set tiles and Home's style samples at the large thumbnail size (Gallery::thumb), as large as the old ribbon's; the samples show unscaled

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* Ribbon: the Zotero tab is called Citations; Zotero is its provider

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* Citations: a Provider menu with Zotero as its one provider

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* citations tests: hold the layout the tabs borrow; import NodeT

* red app-t7 g6: settle the Install button before the person's click; wait for the caret glide; coverage check skips symbols kept from the English source

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t7 g5: smart-art category list natural height, print panel FillHeight, ribbon fit test checks on-screen controls

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t7 g2: Alt+Q test back on the Focus dialog, Tab hand-off owned by the framework, macros name read from the box, effects as pair rows, caret test waits for focus

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t7 g4: Size dialog fields take edit events, font list opens from the field, test keys release

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t7 g3: keymap test assigns through the keymap's Steal policy; smoke finds the prompt button by its resolved name

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* red app-t7 g1: Escape reaches select.collapse and the window's untaken Cancel (File page, Focus, Full Screen); web width settles after a drag; prompt helper asks the shown window; chord tests step the framework's frames

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* look-ribbon-4: the tab row's Comments and Editing are outlined and Share a filled accent button, as the old strip drew them (StripEnd::variant)

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* look-rest-4: Font dialog's Effects columns as wide as their check boxes (production's table, Italic just past Superscript); File page section headings in the heading role (production's 15 pt) and page titles, Options' too, a step above them

* look-5: Home's Font and Paragraph button rows close up as the old ribbon's; Layout's Paragraph group as two label/field grids of small fields, indents to two decimals, a section gap before Spacing

* red stub g2: caret glide compares the view, which the page view reports on every pass

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g2: crop overlay takes the box as given so a drag survives to its commit

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g1: Alt+Q to Search Commands off macOS, ui.print state, scripts open no dialogs, equation state read without a command, size and New Label tests on the framework fields

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g2: collections in scrolling bodies cap their rows or take their natural height, as production shows them

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g2: Escape on the page dismisses an open text menu first

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g1: format.enclose gives a script an error without a shape, as the engine always has

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g2: the caret marks are shown over the view, so their strokes are not clipped to an empty rect

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g2: header/footer presses keep their release; the caret follow settles after a page jump; a wheel zoom keeps its exact zoom

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g2: tests find the framework's controls by their real roles and names; the ribbon group check covers the ribbon's groups

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g2: the canvas keeps the whole layout's page rects; the side-by-side test reads every page as production did

* red stub g2: the perf wheel helper sends point travel over the touchpad factor the framework now applies, as production's host did

* red stub g2: the alignment test steps once more for the fired command to run, as the port's command board does

* red stub g2: the Zoom dialog's programmatic OK answers with the percent it shows

* red stub g1: tests install no gallery story command sets (they took Mod+F from Find); the Navigation pane keeps its focus request until a pass takes it; Field Code opens before the first frame; report rows of the input-dialog test expect the report's data

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g2: a WordArt style pick hands the keyboard to the page

* red stub g1: the language pack bar's slot takes the bar's height, so a failure's line no longer clips Install out of reach

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g2: a tab click and a dismissed status-bar language menu give the page the keyboard back after the pass; the test reads the framework's open menus

* red stub g2: the caret follow waits for the page's settled rect and places an unplaced page's caret from the whole layout

* red stub g2: the canvas reports the area the pages show in; the wheel-zoom test points at its centre, as production's canvas rect was

* look-6: a script's launcher command (format.fontDialog, Zoom, Page Setup) opens its dialog as production did; commands lacking input still open none

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* look-6: the File page body stands on the window background (production's #f9f9f9), not the white panel

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g2: the app's Host carries the embedded catalogs, so framework words translate; catalog labels and command hints are translated; the canvas's zoom chords are dropped for Word's

* red stub g2: the caret glide test catches the caret the frame after it sets off, as on main (the set-off frame draws it where it was)

* red stub g2: Manage Styles and Customize Ribbon lists scroll their own rows (row caps as main's boxes); the Arabic Go To check compares the targets with the framework dialog's button column

* red stub g1: Alt chords fire from the page (PlainKeysWait; Alt+F7/Alt+F8 left to Word's commands), Macros reopened keeps its hooks, the recipient grid holds its rows through the click that ends an edit, ui.clickText maps page points by the page's scale; chrome tests read the title bar outside the File page and open the desktop chooser as its pump does

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g2: watermark, citation style, TOC level, Zotero, caption, cross-reference and icon category labels are translated; the audit reads a wrapped marked label's second line as marked, and allows a hover hint's shortcut and separators, listed or cut-short names and trimmed licence texts

* red stub g1: the Print page decides what an opening holds back in the opening frame's first pass, as appeared() now holds through all of that frame's passes

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g1: tests give a key and its text (or one IME batch) one frame, as kittest's event runs a frame per event; Paste Formatting's key reads its chord when the modifiers are already up; ⌘Q is the runtime's close (S-L332); Search's Escape meets the draft rule first

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g1: wrap the command board's import at the repository width

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g1: the PDF bytes test expects the equation's x the math face can draw (plain x on a host with no math font, as in the pre-port baseline)

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g1: the smoke test turns AccessKit on for its own context, so the Save Changes prompt's buttons are in the tree it searches

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* look-7b: Custom Watermark's text field asks for 38 characters (Param::field_chars), about the old dialog's 280 pt; the field length gave about 195 pt

* look-7a: File pages: titles at production's 26 pt (WordCraft's display size), the page's 40 pt margin clearing the move band, the rail's footer in the side menu place (white ink), Protect Document a section apart on Info, the Print settings a frameless 380 pt column with chevrons for the sheets; tests

* red stub g2: Shift+Delete cuts the selection and does nothing without one (EditorInput::Delete.shift); the page reports its marked text (EditorState::marked); one-frame input back in the refused-delete and disabled Alt chord tests; a Delete after a commit waits out the framework's composition-key guard; a user binding reaches the keymap a harness frame later; window.move/size keep their defaults

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g2: Ctrl+wheel zoom test keeps the place under the pointer at each notch: a reflow centres the rows, so the page under the pointer is taken when the notch comes, and a pointer over the centre gutter moves onto a page first

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* merge app-ui: resolve production main into the port's UI

- ribbon/home.rs (4e8c9d55, #3172): the Paste face is named "Paste"; its tooltip adds
  edit.paste's chord as the platform writes it (commands::resolve + tooltip::with_chord).
  tests.rs: the_paste_button_is_named_without_a_mac_key rewritten on the port harness.
- dialogs/paragraph.rs (32b4ab57): the framework ParagraphDialog's Special box does the work;
  intersect leaves By blank when the paragraphs' kinds differ, so a kind picked then starts at
  the half inch. dialogs/tests.rs: the three Special-box tests rewritten on the dialog host.
- dialogs/dialogs_review.rs (bce64c0e): the port's Compare form already names its fields.
- canvas.rs, canvas/tests.rs (07c0a893): keep the port's composition painter and state;
  production's egui composition painter, its fields and its tests are dropped (framework items).

* merge app-shell: resolve production main into the port

- engine lib.rs: export set_bookmark_error/set_reference_error beside system_locale
  (the port dropped the KeyMap re-export; it stays dropped).
- app.rs: logic() sets the PAGEREF/REF error texts in the interface language.
- file_dialogs.rs: Save As starts in the open file's folder, made absolute
  (#4143), through PickRequest::directory; tests carried to ScriptedFiles.
- window_geometry.rs: 600 pt minimum width (#5886) and its test.
- chrome/status_bar.rs: Page item bound to edit.goto so its tooltip shows the
  platform's Go To key (#3172); language tooltip names the language in full.
- chrome/tests.rs: narrow-window title bar and status bar tests rewritten
  against the app harness.
- a11y.rs: test expects zero-based AccessKit levels (#3173); the mapping
  fix is the framework's.
- chrome.rs, theme.rs, app/fonts.rs, windows.rs, windows/tests.rs,
  keytips/tests.rs: production's replaced egui code and cut tests dropped.

* land sync: canvas.rs declares its tests module again (dropped in canvas-w9, so canvas/tests.rs, markup.rs and overlays.rs never compiled)

* land sync: the app takes craft gpu-startup (the sync moved craft::gpu::configure behind it)

* red stub g1: canvas tests compile against the ported canvas (imports, kurbo/Env/commands paths, equation_frame sizes, page_grid)

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g1: canvas tests step through the app's input hook; caret reports the editor from an off-screen page

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g1: candidate window at the composition cursor; page keeps its keyboard across a document switch; IME, tip and Hide White Space tests on the ported mechanisms

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g1: a pass whose input edits the document runs again so its frame paints the edit; read-only balloons open no edit; balloon tests type in the card's field

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g1: a right click selects what it clicked before its menu opens; the page under a point is the nearest shown band; the status bar's page in view measures from the view's top edge

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g1: Hide White Space gets the page bodies; a refused balloon draft stays when the balloon is left; context menu, crop and ruler tests on the ported mechanisms

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g1: comment drafts stay with their document across a window switch; Hide White Space test probes the overlap inside the text areas

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g2: rotated effect-extent fixtures use Word's exchanged-frame measure (craft-libs #2227)

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* red stub g1: the title bar's search and Discord and the status bar's zoom slider and Focus give way in a narrow window (#5886 fit, measured per step); the IME composition draws in the text's face, size and baseline through Draw::face_run; narrow-window tests read the bar row and the painted texts; production's three composition tests

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* land sync: a refused input-method edit asks the framework for the interrupt (ToolPass::ime_interrupt), so the commit keeps its InputMethod cause

* port build loop: craft-i18n and craft-fonts come from the environment (CRAFT_I18N_DIR, CRAFT_FONTS_DIR), not machine paths in the manifest

* Resolve the craft framework from https://github.com/storytold/craft-libs next at 362eb2820996b475e6f21967c561219dbde24343

Every framework path dependency and patch is now a git dependency at that revision.
Cargo.lock is regenerated against it separately.

* Cargo.lock: resolve against craft-libs next at 362eb2820996b475e6f21967c561219dbde24343

* port: cargo fmt

* fonts: drop the face_names re-export the ported UI fallback no longer uses

* Restore the [patch.crates-io] block: the egui and winit forks and the vendored crates the framework builds with

* Workspace clippy: dead code and unused imports the port left, test-only helpers under cfg(test), the examples report a failed install

* Tests: headings read in tree order, not egui id-map order; the picker Install is aimed after downloading goes off, which adds a licence line to each row and moves it

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* Ribbon: own icons under wordcraft.* names so the catalog no longer shadows them; 32/17-pt ribbon icons and corner launcher

* Ribbon: filled menu arrows right after the label, as the old ribbon

* Ribbon: 22-point small-row pitch (20-point rows a tight gap apart), RibbonLook

* Ribbon: Draw colour/thickness and Layout align/group/rotate show icons alone; Window collapses to the more icon, as the old ribbon

* Styles gallery: sample letters on the ribbon with no white paper box, as the old ribbon

* Title bar: tool-size QAT icons, the filled undo-list arrow and the small AutoSave switch, as the old title bar

* Ribbon: tabs in the text colour over a 3-point underline

* Ribbon: body on the old lighter band with its rules

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01FypgCZhHKRuRB5wZUiw6BE

* Ribbon: framed Styles gallery; Style Sets drop their buttons while all show

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01FypgCZhHKRuRB5wZUiw6BE

* wasm: gate native-only craft features (dialogs, update, automation client, default app) off wasm32

craft-dialogs (rfd folder picker, file paths) and craft-update (ureq/ring, getrandom 0.2) are
documented native-only, as are craft::automation's client/security/args/dialogs and
craft::platform::default_app. ui-egui takes `dialogs` and `update` through a
non-wasm32 `craft` dependency; wordcraft-mcp's `Remote` bridge moves to backend/remote.rs,
native only. The code that used them is gated the way production main gated its
native-only paths, with a plain fallback on the web. Also drops dead-code/unused-import
warnings on wasm32 and keeps chrono's parser available there.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* MCP: pin the shared server refusing a request without the JSON-RPC version (craft-libs #2444)

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* Resolve the craft framework from https://github.com/storytold/craft-libs next at a5f6cd7f6ccd560438e3bbeb1209aa117ba957dc

Every framework path dependency and patch is now a git dependency at that revision.
Cargo.lock is regenerated against it separately.

* Cargo.lock: resolve against craft-libs next at a5f6cd7f6ccd560438e3bbeb1209aa117ba957dc

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* port: the default-chords rows stay mutable only where the off-macOS rows extend them (macOS clippy)

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* port: the web build embeds its Japanese interface face when the craft-fonts checkout has one, CRAFT_FONTS_REQUIRED binds the native build

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* port: wordcraft-web builds against the ported UI: the host takes the framework language, the legacy prefs parser is imported, no native-window hook on the page

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* ui-egui: use the framework constructors for non_exhaustive types

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* port test: the files clipboard keeps any absolute path from a uri-list, so the copied-files trials run on Windows

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* Resolve the craft framework from https://github.com/storytold/craft-libs next at 1e48c0807e18c5f5ae25b6227fde52281942f288

Every framework path dependency and patch is now a git dependency at that revision.
Cargo.lock is regenerated against it separately.

* Cargo.lock: resolve against craft-libs next at 1e48c0807e18c5f5ae25b6227fde52281942f288

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* port test: on macOS the smoke close goes to the platform quit, so Don't Save shows as no second prompt

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* Resolve the craft framework from https://github.com/storytold/craft-libs next at 1e48c0807e18c5f5ae25b6227fde52281942f288

Every framework path dependency and patch is now a git dependency at that revision.
Cargo.lock is regenerated against it separately.

* Cargo.lock: resolve against craft-libs next at 1e48c0807e18c5f5ae25b6227fde52281942f288

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* Resolve the craft framework from https://github.com/storytold/craft-libs next at 27c1c0ebb1d16adf97d09952bb781e69f9962e46

Every framework path dependency and patch is now a git dependency at that revision.
Cargo.lock is regenerated against it separately.

* Cargo.lock: resolve against craft-libs next at 27c1c0ebb1d16adf97d09952bb781e69f9962e46

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* Resolve the craft framework from https://github.com/storytold/craft-libs next at 243d68e12d05e89122db6d154924bf1992e10d38

Every framework path dependency and patch is now a git dependency at that revision.
Cargo.lock is regenerated against it separately.

* Cargo.lock: resolve against craft-libs next at 243d68e12d05e89122db6d154924bf1992e10d38

Co-Authored-By: Claude Opus 5.5 <[email protected]>

---------

Co-authored-by: Claude Sonnet 5.5 <[email protected]>
2026-11-20 14:02:07 +00:00
batistalucasv 15d315e3f8 Wayland: 600 pt minimum width for GNOME split window tiling (#5886) 2026-11-17 21:49:07 -03:00
30584c81ad #778: pin craft-libs main with the shared cutover prerequisites (#6954)
* #778: take craft-libs integration/wordcraft-778 at beeea924

Every craft-libs git dependency (workspace, ui-egui, wordcraft, wordcraft-web,
krilla patch) moves from 453b0da782 to beeea92451 (craft-libs main 0649a07aa
plus open PRs #2061-#2064). Cargo.lock: only craft-libs sources move, plus
windows-sys edge changes inside craft-libs crates; no crates.io versions change.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* #778: docx stacking-order test follows the shared reader's one-more z

craft-libs 5f453efa9 (craft-docx: a relativeHeight of 0 stays the lowest
stacking order) reads Float::z as one more than the file's relativeHeight and
writes stored orders one less, so a file's 0 is no longer "none". The test
expected the old values; relative order and the round trip are unchanged.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* #778: take craft-libs integration/wordcraft-778 at 24a15211

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* deps: pin craft-libs to the merged shared cutover prerequisites

* #778: pin craft-libs main at 93dac78c (with #2061-#2064)

Co-Authored-By: Claude Opus 5.5 <[email protected]>

---------

Co-authored-by: Claude Opus 5.5 <[email protected]>
Co-authored-by: Dylan M. Taylor <[email protected]>
2026-11-17 15:45:46 -05:00
Aleksander HelgakerandClaude Fable 5.2 8331f2e68d Fonts: tell where a missing font can be downloaded (Get the Missing Fonts) (#6826)
* Fonts: tell where a missing font can be downloaded (Get the Missing Fonts)

A document opened from a file that is missing fonts their publisher gives
away (Microsoft's Aptos family, Cascadia Code and Mono) brings up a box
naming each font, the font drawn instead, the publisher's download page and
how to install the download. Once per document; never for a new document or
one a script opened. "Don't show this again" turns it off (File > Options >
General turns it back on); the status bar's missing-fonts menu opens it by
hand (ui.dialog fontDownload).

font.missing reports the same page as "download", so agents get it without
the box. WordCraft links to the page only: nothing is downloaded or bundled.

The desktop and web apps switch the box on at start-up
(tell_about_font_downloads); tests and ui_shot don't, so what they show
doesn't depend on the fonts installed where they run.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
Claude-Session: https://claude.ai/code/session_01GBVQLv63guWCuWUM3SctPP

* Get the Missing Fonts: the box with nothing to download is one row tall

Its Close button's far-side layout took the rest of the window's height.
The button row is now a row of its own, shared by both forms of the box.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
Claude-Session: https://claude.ai/code/session_01GBVQLv63guWCuWUM3SctPP

* Floating windows: a flat title bar and room around the content

Dialogs, the Read Aloud player and the built-in file browser had a grey
band behind a centred title and 6 pt margins. The title bar is now the
window's own colour with no band or line under it, and the title and the
content have 18 pt of room. The close box follows the new title bar height.

egui fills the front window's title bar with the colour of an open menu
button, so show_window makes that colour the window's while the title bar
is drawn and puts it back before the content is.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
Claude-Session: https://claude.ai/code/session_01GBVQLv63guWCuWUM3SctPP

* Get the Missing Fonts: a headline, a card to each download, numbered steps

The box was a plain table and a paragraph of steps. It now opens with the
warning mark and how many fonts are missing; lists each download once
(Aptos and Aptos Display come in one) with the fonts drawn instead, the
publisher and a Download button that opens the publisher's page; and gives
the two steps that add the download, with Add Font… beside its step.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
Claude-Session: https://claude.ai/code/session_01GBVQLv63guWCuWUM3SctPP

* Fonts: the download pages are a JSON list (font_downloads.json)

The list of fonts their publisher gives away, and each publisher's page,
was a table in the code. It is now crates/fonts/src/font_downloads.json,
built into the app: adding a font is a new entry there. Entries without a
family, a publisher or an https page are left out, and a list that isn't
JSON has no downloads rather than failing.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
Claude-Session: https://claude.ai/code/session_01GBVQLv63guWCuWUM3SctPP

* Get the Missing Fonts: licence notice, and fonts offered with limits

The box says that fonts come with licence terms and that following the
publisher's terms is up to the user. A font whose publisher limits who may
use it is marked "restricted" in font_downloads.json, says so on its card
and in font.missing ("restricted"), and has a card of its own.

The list gains Selawik (Microsoft's open-source font) and, marked
restricted, Segoe UI Variable, Segoe Fluent Icons and Segoe MDL2 Assets
from Microsoft's Windows design downloads page. Plain Segoe UI is not
offered for download and is not matched.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
Claude-Session: https://claude.ai/code/session_01GBVQLv63guWCuWUM3SctPP

* Get the Missing Fonts: the downloads scroll in a short window

With many downloads in a short window the box ran past the bottom of the
screen, leaving the steps, Add Font…, Don't show this again and Close out
of reach. The cards now scroll in the room the window has left, between
96 and 320 pt, and the rest of the box stays in view.

Co-Authored-By: Claude Fable 5.2 <[email protected]>

* Get the Missing Fonts: all above the Close row scrolls in a short window

Only the download cards scrolled, within fixed limits, so in a window
shorter than about 480 pt the opt-out and Close could still fall off
screen. Everything above the row with Don't show this again and Close now
scrolls in the room the window has left, and that row stays on screen.

Co-Authored-By: Claude Fable 5.2 <[email protected]>

* Floating windows: the flat title bar and wider margins leave this change

Reverts 2d39c54e and its revision-history row. The restyle changes every
dialog, the Read Aloud player and the file browser, and is to be reviewed
on its own.

Co-Authored-By: Claude Fable 5.2 <[email protected]>

* Get the Missing Fonts: the headline counts the fonts that can be downloaded

The box lists only the missing fonts with a download, so "1 font in this
document isn't installed" was wrong for a document missing others too. It
now says "1 missing font can be downloaded", and the line under it no longer
mixes one and many.

Co-Authored-By: Claude Fable 5.2 <[email protected]>

---------

Co-authored-by: Claude <[email protected]>
2026-11-17 21:05:13 +01:00
.CooCoo 1a56d041de Dependencies: take craft-libs main at 453b0da782 (#6886)
* Dependencies: take craft-libs main at 3af2280ee3

Every craft-libs git dependency (the workspace's 25, ui-egui's 3, the app's
craft-print, the web build's 2 and the krilla patch) moves to craft-libs main
at 3af2280ee3 from the 8 revisions they were pinned at. Cargo.lock changes
those sources, moves winprint and craft-winprint-gdi with craft-print, drops
the second craft-tiff, and adds cap-primitives and its dependencies, which
craft-font-store's Language pack recovery uses on native builds.

- craft_print::Job has two new fields. WordCraft sets grey_pages to false,
  since it does not turn the spooled pages gray, and driver_settings to None.
- DOCX text boxes, rectangles, rounded rectangles and ellipses are now
  written in mc:AlternateContent with a VML fallback that repeats the text
  box's text. Two tests that counted w:txbxContent elements, or the story
  text, now count the fallback copy as well.

* Printing: the isolated print helper keeps the job's grey pages and driver settings

The Windows print helper process rebuilt each job with grey_pages off and no
driver settings, whatever the job carried. Its request now carries both: the
driver settings travel as the printer's name and the DEVMODE in hex, and
damaged settings are an error. The request file may now be up to 2 MiB larger,
the size of the largest driver settings craft-print accepts, written as hex.

Comments in Cargo.toml and apps/wordcraft/Cargo.toml now describe the shared
craft-libs commit, and the shared-story text box test says where its two copies
are written.

* DOCX: open picture frame shapes and keep chart formatting from craft-libs

At this craft-libs commit the DOCX reader returns a picture frame shape
(`frame` preset) as its own shape kind, and charts carry series formatting
and axis settings. WordCraft's model had neither:

- A document with a picture frame shape failed to open with "unknown
  variant `frame`". The model bridge now reads it as a rectangle, as the
  earlier reader did.
- The chart model drops nothing the shared chart model holds: series fill,
  line width, line and fill off, markers, smooth lines, data labels and
  number format, and the category and value axes. Before, saving a chart
  with any of these wrote the chart again without them.
- A new scatter series is drawn as markers without a line, as before.
  Change Chart Type sets this when a chart becomes a scatter chart or stops
  being one, Edit Data keeps each replaced series' formatting, and Data
  Labels replaces each series' own label setting.

* Charts: draw turned axis titles and keep stored scatter charts without lines

At this craft-libs commit a chart's vertical axis title is a text item
turned -90°. WordCraft's graphic text item now carries that angle, and the
text is laid out along its box and drawn turned about the box's center.

Scatter series saved in a .json document or a recovery snapshot before
series formatting existed have no `noLine` value. They now read as markers
without a line, as they were drawn when saved.

* Charts: draw opened ODT scatter charts without lines

The ODF reader at this craft-libs commit does not read a scatter chart's
line setting, so a scatter chart saved as ODT and opened again was drawn
with lines between its points. The ODF writer writes every scatter series
as markers without a line, and the opened chart is now drawn that way.

* Charts: set scatter series to markers only for opened ODF files alone

Opened ODT, OTT and FODT files set their scatter series to markers
without a line, since the ODF reader does not read a series' line
setting. Other formats that go through the same import path keep their
series as read. A series that arrives with its markers turned off gets
them back, as Change Chart Type does, so it is still drawn.

The test for an opened scatter chart now also covers flat ODT, checks
the drawn items against the markers-only drawing, and checks that the
chart's paragraph is still written as read.

* Dependencies: take craft-libs main at 453b0da782

Every craft-libs dependency, and the craft-proof note in Cargo.toml,
moves from 3af2280ee3 to 453b0da782. Cargo.lock adds craft-dds, which
craft-image-codecs now uses; no crates.io version changes.

- craft-xls builds its test fixtures only for tests and its
  test-support feature, and they return a Result. wordcraft-formats
  gets a test-support feature that turns it on; sheet::xls_fixture is
  behind it and returns Result, and wordcraft-engine's tests enable it.
- craft_metafile::Picture has new report fields; the render tests'
  literals fill them with Default.
- The docx tests follow the writer: the font table is kept as read,
  the flat OPC comparison allows a kept part without its XML
  declaration, and the bibliography store is related from the main
  part, once, after a second save too.

* DOCX: gutter position Top is kept when a document is opened and saved

craft-libs now reads w:gutterAtTop into its settings model instead of
keeping it as unread XML, and WordCraft's settings had no field for it,
so opening and saving a document dropped the setting. Settings gets
gutter_at_top (off by default), which the document bridge carries both
ways. Layout still puts the gutter on the left.

* Charts: Change Chart Type gives a pie chart's value axis the new type's gridlines

A pie or doughnut chart keeps a plain value axis (no gridlines, axis
line on), and a new chart of any other type has gridlines and no axis
line. Change Chart Type kept the old axis, so a pie chart changed to a
column chart was drawn and saved without gridlines and with an axis
line. Change Chart Type between a round chart and another type now sets
the value axis to the new type's when it is still the old type's; an
axis that was changed stays as it is.

The progress log gets a line for the chart formatting, turned axis
titles, picture frame shapes and gutter position this branch brings.
The gutter_at_top doc comment states only what the field holds.
2026-11-17 07:24:29 -05:00
Mex 880cda902f M14: clarify finite positive CLI scale errors (#6691) 2026-11-17 13:16:17 +01:00
Ahmad Bagheri 53e05c2420 Linux: draw on the GPU that drives the screen (#6016) (#6158) 2026-11-17 10:40:08 +01:00
Mex ca075db458 M14: report missing --cmd values before CLI options (#6686) 2026-11-17 07:54:43 +01:00
ljkxandClaude Opus 5.5 93bf14883c #3773: a WordCraft process saves only the preferences it changed (#5258)
Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-11-17 06:06:04 +01:00
Mex 8e8ab631fd M14: document optional run commands and PNG save options (#6687) 2026-11-17 04:16:20 +01:00
FredApps 1ed889c24c Merge pull request #6448 from batistalucasv/fix/control-server-reset-closed
Tests: a reset control connection counts as closed (Windows Print flake)
2026-11-16 10:23:29 +01:00
Dylan M. Taylor 42a5df5f94 chore: cut over image codecs and zip to craft-libs (#6661)
* chore: cut over image codecs and zip to craft-libs, fix main test regressions

* tests: store ODS mimetype and use standard ODF namespaces in mailings test

* Remove unused quick-xml workspace dependency

* fix: use standard ODF namespaces in file_dialogs test and preserve trailing line in markdown import_on_with_lines

* fix(geom): use png_chunks for PNG dimensions and p.fits(budget) in decode_for_drawing
2026-11-14 14:51:35 -05:00
Dylan M. Taylor d1a36fd0c6 test(cli): update strict error-escaping test for XML 1.0 character filtering 2026-11-14 05:37:27 +00:00
batistalucasvandQwen-Coder bd188c19d8 Tests: only closure errors mean the control peer closed (#6448)
CodeRabbit pointed out that read_line returns InvalidData for bytes that are not UTF-8 while the socket stays open, and the helper treated every non-timeout error as a close. closed_by_peer() now accepts only ConnectionReset, ConnectionAborted, NotConnected and BrokenPipe, and the regression test pins InvalidData, TimedOut and WouldBlock as still open; the new assertion fails without the stricter match.

Co-authored-by: Qwen-Coder <[email protected]>
2026-11-12 16:42:47 -03:00
batistalucasv 56a28f33b7 Merge remote-tracking branch 'upstream/main' into fix/control-server-reset-closed 2026-11-12 16:35:04 -03:00
batistalucasvandQwen-Coder cd4ab71552 Tests: a reset control connection counts as closed (Windows Print flake)
The Windows Print job on #6232 failed in a_silent_connection_is_closed: quiet.closed() only accepted end of stream, but Windows can deliver a close with nothing to read as a reset. The test binary finished in 0.81 s, so it was not the 5 s read timeout. closed_by_peer() now counts a reset, abort, not-connected or broken pipe as closed, and only a read timeout as still open; the new regression test fails before the fix with ConnectionReset. A loaded Windows runner can also take seconds to schedule the connection thread, so the silent test waits up to 20 s and still requires the close within 10 s (the production budget is 30 s).

Co-authored-by: Qwen-Coder <[email protected]>
2026-11-12 16:13:42 -03:00
batistalucasv 139aa7a51b Merge branch 'main' into fix/6205-image-copy-paste 2026-11-12 15:30:43 -03:00
FredApps 11318f9226 Merge main and preserve both UI parity histories (#6225) 2026-11-12 18:13:35 +01:00
FredApps 0196647dc6 Merge main and preserve both UI parity histories (#6232) 2026-11-12 18:13:35 +01:00
10e5bb8bce View: editable Markdown source view for .md files (#5826) (#6004)
* View: editable Markdown source view for .md files (#5826)

Co-authored-by: oldgranola <[email protected]>

* Address review feedback on Markdown source view

- Fix view.markdownSourceText purity and input validation
- Single-pass block line mapping in markdown parser
- Reuse parsed documents and block line ranges on apply and leave
- Bound memory usage with MAX_SOURCE_BYTES and clamp caret byte offsets
- Isolate temp directories in tests and test caret validation
- Preserve dirty state while markdown text edits are pending
- Flush pending markdown text edits in swap_doc

* Address CodeRabbit review feedback on Markdown source view

- Exempt view.markdownSourceText in command refusal
- Preserve original source line mapping when filtering link definitions
- Map between egui char indices and byte-offset caret in history and undo

* Remap block line numbers in a single linear pass

* Refuse over-limit Markdown Source edits to prevent document truncation

* Keep a Markdown file's own text when it is opened from handed-over bytes

`file.open` kept a Markdown file's exact text only for path-backed opens, so a
platform that hands the bytes over (data) lost front matter, comments and the
author's line endings on the first save, and the rewritten flag could not say
so. The kept text now comes from the same bytes `read_document` decodes, still
bounded by MAX_SOURCE_BYTES through FileText::from_bytes; the path read stays
for opens without data.

---------

Co-authored-by: oldgranola <[email protected]>
Co-authored-by: CommandCodeBot <[email protected]>
2026-11-12 17:59:04 +01:00
batistalucasv 664b033071 Save As: don't open the rfd fallback after the portal dialog was given up (#6180)
Giving the dialog up cancels the request. If the portal then fails with an
error other than its cancellation code, the worker opened the rfd dialog even
though nothing was waiting for the answer, leaving an unwanted Save dialog on
screen. The fallback now checks this request's cancellation token first.
2026-11-12 12:52:55 -03:00
batistalucasv 2d286fe252 Save As: only the request that armed the portal cancel token disarms it (#6180)
An abandoned portal request finishing late cleared the token of a newer
request in the shared slot, which left the newer Save dialog uncancellable.
Each arming now carries an identity and only its owner clears the slot; a
regression test arms two requests and disarms the older one.
2026-11-12 12:36:00 -03:00
batistalucasv 02f8022e57 Merge remote-tracking branch 'upstream/main' into fix/6205-image-copy-paste
# Conflicts:
#	docs/gaps.md
#	docs/ui-parity.md
2026-11-12 10:41:04 -03:00
batistalucasvandCommandCodeBot 4671e47b50 Save As: cancel a stalled portal request and recognize the Flatpak document portal (#6180)
- Recognize the XDG document portal mount inside a Flatpak sandbox
  (`/run/flatpak/doc/`), so a changed extension reopens the dialog for the
  overwrite confirmation like the host mount does.
- Give the portal SaveFile request a real cancellation path: the CancelToken is
  armed before the waiting thread starts and cancelled when the system dialog is
  given up (File > Open > Browse in WordCraft...). The request closes and the
  answer reads as a cancel, so a portal that stops answering cannot keep Save As
  stuck; a late cancel after the answer is ignored.
- Map the cancellation error to a cancelled dialog instead of the rfd fallback.
- Regression tests for the Flatpak mount, the CancelHandle arm/cancel/disarm,
  and the UI calling the host's cancel hook when the dialog is given up.

Co-authored-by: CommandCodeBot <[email protected]>
2026-11-12 10:15:36 -03:00
batistalucasv cd4e63849e Clipboard: qualify the CF_HTML helper in the Windows host (#6205) 2026-11-12 10:06:07 -03:00
batistalucasv a1d4495cfb Clipboard: account for fragment media and test CF_HTML offsets (#6205) 2026-11-12 09:53:17 -03:00
batistalucasv cc27f29a01 Save As on Linux: the file type picked in the save dialog sets the extension (#6180) 2026-11-11 18:08:29 -03:00
batistalucasv 7013411a2f cli: skip update-fields with warning on protected document (#5839) (#5849) 2026-11-11 18:53:10 +01:00
bmh129andbmh129 639b8133ea Linux: stay on native Wayland when the X11 libraries are missing (#3359)
The deb and rpm only recommend the X11 libraries, and the release tarball
doesn't install them. When the display-server choice (#2184) or
WORDCRAFT_WAYLAND=0 asked for XWayland without them, the app failed to
start: winit panicked in xkbcommon-dl without libxkbcommon-x11 (seen on
Fedora 44 and Ubuntu 26.04).

uses_x11 now also takes a check of the libraries winit's X11 backend opens
(libX11, libXcursor, libX11-xcb, libXi, libxkbcommon-x11), asked only when
X11 would be forced. If any is missing, X11 isn't forced and the log line
names them. The packages now also recommend libX11-xcb and
libxkbcommon-x11, and the README lists the libraries XWayland needs.

Tests: missing_x11_libraries_leave_the_app_on_wayland (every way of asking
for X11, and that asking for Wayland doesn't run the check).

Co-authored-by: bmh129 <[email protected]>
2026-11-11 12:04:55 -05:00
batistalucasv 28af39b610 Clipboard: preserve system clipboard and ownership when copy has no selection (#6205) 2026-11-11 09:34:43 -03:00
FredApps 45db128c15 fix(wordcraft): satisfy clippy on clipboard.rs after #5441
#5441 (92e0e67f) landed a Wayland clipboard size check in `apps/wordcraft/src/clipboard.rs` that left two clippy `-D warnings` failures on main:

- an unused `self` import in the Unix `platform` module (`use wordcraft_ui_egui::paste_picture::{self, ClipboardPicture}`)
- `items_after_test_module`: `platform::picture()` was defined after `mod tests`

This removes the unused import and moves `picture()` above the test module. Behaviour is unchanged.

Local checks: `cargo fmt -p wordcraft` and `cargo clippy -p wordcraft --all-targets --locked -- -D warnings` on Linux.

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **Refactor**
  * No user-visible changes.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-11-11 08:51:03 +01:00
Dylan M. Taylor 92e0e67f3a Clipboard: size-check a Wayland clipboard picture before anything decodes it (#5441)
* fix(clipboard): size-check a Wayland clipboard picture before it is decoded

* address review: refuse a clipboard PNG the renderer cannot decode within its budget
2026-11-10 21:33:46 -05:00
batistalucasv 22f01131d8 Clipboard: use process-unique token for Windows clipboard ownership (#6205) 2026-11-10 21:47:52 -03:00
batistalucasv 860426adda Clipboard: remap conflicting media keys, format Windows CF_HTML, and complete docstrings (#6205) 2026-11-10 21:33:22 -03:00
batistalucasv 7458a18468 Clipboard: collapse nested checks in Windows clipboard host (#6205) 2026-11-10 21:12:03 -03:00
batistalucasv 49e777cce5 Clipboard: transfer copied images to system clipboard and preserve media across internal paste (#6205) 2026-11-10 20:59:58 -03:00
Martin BallandClaude Opus 5.5 d40d1b2718 CLI: --strict on convert and render refuses missing glyphs and pictures (#6039)
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
2026-11-09 20:16:05 +01:00
dotCooCoo 642f5dd6bf Updates: the updater reports installing, ready, installed and failed, and installs at exit
Moves craft-update, craft-pdf and the krilla patch from storytold/craft-libs
c5a1cbfb to dotCooCoo/craft-libs c7c84230, which is craft-libs main at
0a9d1f48 with storytold/craft-libs#687 and #696 merged in.

- The result window opens whenever the updater's status is not idle: at
  the first start after an update it says the version that was installed
  or why the update failed, and Help > Check for Updates shows Installing,
  Ready and the launcher's choice. A check asked for from the ribbon now
  shows the window on the next frame.
- Restart to Update closes the window and asks the app to quit. An update
  that asks the app to close quits every window, after asking about each
  document with unsaved changes.
- on_exit and the macOS terminate path start the waiting update's helper.
- The update prompt and the result window draw their words through the
  interface catalog.
2026-11-08 10:56:53 -08:00
FredApps 0655e651fb Merge upstream control delivery changes 2026-11-08 17:35:06 +01:00
FredApps be75ee90e3 Merge upstream main and reconcile control documentation 2026-11-08 17:22:59 +01:00
FredApps 480511eaa5 Merge upstream main into control delivery changes 2026-11-08 17:15:38 +01:00
batistalucasvandMartin Ball fde39ab061 Desktop: constrain newly opened window dimensions to available screen width (#5871) (#5876)
Co-authored-by: Martin Ball <[email protected]>
2026-11-08 06:44:01 +01:00
vangel76andClaude Opus 5.5 833c0154aa Merge upstream/main into control-mcp-delivery-1326-1331
Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-11-08 06:18:12 +01:00
Helen Kwok de4ca29309 wordcraft-web: window.wordcraft, the page command API from craft-web-api (#5860)
The web shell queues the page's calls as control requests (the channel the desktop control server uses) and answers them on the next frame. The API is installed in every mode; opening, saving, the file name and the unsaved flag stay with the host messages.
2026-11-08 05:53:01 +01:00
vangel76andClaude Opus 5.5 6367400215 Merge upstream/main into control-mcp-delivery-1326-1331
Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-11-08 04:21:51 +01:00
852e67d587 A template opened from the file manager starts a new document (#3433) (#5698)
A Word template (.dotx, .dotm, .dot) the platform hands the app, from a
double-click in the file manager, the command line or the Finder, opened
as itself: the window called it saved, AutoSave was on, and Ctrl+S wrote
over the template. Word's default verb for a template makes a new,
untitled document based on it.

WordApp::open_from_platform sends a Word template to file.newFromTemplate
and opens anything else as File > Open does; main.rs (also for a name that
isn't valid Unicode) and the Apple Events handler use it.
file.newFromTemplate reads the template as file.open reads a file
(password, data, an empty file) and, with replaceBlank, takes an untouched
blank document's place, so a launch shows one window. The Password box
retries the command that asked for it, so a protected template still
starts a new document. File > Open and drops still open a template itself.


Claude-Session: https://claude.ai/code/session_01LvG6E1XTfHtZDbfYwfREhR

Co-authored-by: Filip Strajnar <[email protected]>
Co-authored-by: Claude Opus 5.5 <[email protected]>
Co-authored-by: Martin Ball <[email protected]>
2026-11-08 03:25:17 +01:00
eb100edfd6 Linux: ignore an AppImage environment inherited from another program (#5653) (#5690)
* Linux: ignore an AppImage environment inherited from another program (#5653)

An AppImage app that opens a document through xdg-open passes its APPIMAGE,
APPDIR, ARGV0 and OWD on to the WordCraft it starts. The self-update trusts
APPIMAGE, so an installed WordCraft replaced the other app's file with its own
AppImage.

The app now starts over without those variables, first thing in main, unless
its executable is under APPDIR. The update then goes through the package or
plain file this copy really is, and a real AppImage keeps its variables.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LvG6E2QwHfTULQtWYgVEXk

* #5653 review: turn the self-update off when starting over fails

If the process can't start again without another program's AppImage
variables, it still carries APPIMAGE, and an accepted update would replace
that program's file. The app now turns its self-update off for that
process: no update is offered, and Help > Check for Updates says why. The
app still opens, so the document the user asked for isn't lost.

Also documents the test helpers.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LvG6E2QwHfTULQtWYgVEXk

---------

Co-authored-by: Filip Strajnar <[email protected]>
Co-authored-by: Claude Opus 5.5 <[email protected]>
Co-authored-by: Martin Ball <[email protected]>
2026-11-08 03:09:52 +01:00