mirror of
https://github.com/storytold/photocraft.git
synced 2026-11-21 20:28:28 +00:00
io: cover Camera Raw settings through PSD save and reopen (#16218)
Co-authored-by: FredApps <[email protected]>
This commit is contained in:
@@ -165,6 +165,54 @@ fn active_unimplemented_controls_and_malformed_curves_stay_opaque() {
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn psd_reopen_keeps_editable_camera_raw_and_preserves_active_unsupported_optics() {
|
||||
use std::sync::Arc;
|
||||
|
||||
use photocraft_color::{ColorMode, SampleType};
|
||||
use photocraft_doc::{Document, Layer, LayerContent, SmartObject, SmartSource};
|
||||
use photocraft_geom::{Affine, Size};
|
||||
use photocraft_raster::Surface;
|
||||
|
||||
let size = Size::new(2, 2);
|
||||
let mut source = Document::new("contents", size, ColorMode::Rgb, SampleType::U8);
|
||||
let mut pixels = Surface::new(source.pixel_format());
|
||||
pixels.fill_rect(source.bounds(), &[0.25, 0.50, 0.75, 1.0]);
|
||||
source.layers.push(Layer::new("synthetic pixels", LayerContent::Raster(pixels.clone())));
|
||||
let bytes = Arc::new(photocraft_format::save_to_bytes(&source, &Default::default()).unwrap());
|
||||
|
||||
// Use the existing generated descriptor, not the optional external PSD. Nonzero MDis cannot
|
||||
// be rendered by the editable Camera Raw filter and must survive even when the layer is saved.
|
||||
for optics in [false, true] {
|
||||
let mut item = source_item();
|
||||
if optics {
|
||||
let mut settings = get_desc(&item, "Fltr").unwrap().clone();
|
||||
set(&mut settings, "MDis", Value::Integer(17));
|
||||
set(&mut item, "Fltr", Value::Descriptor(settings));
|
||||
}
|
||||
let mut smart =
|
||||
SmartObject::new(SmartSource::Embedded { file_name: "contents.pcraft".into(), bytes: bytes.clone() }, Affine::IDENTITY, Some(pixels.clone()));
|
||||
smart.smart_filters.push(filter_from_item(&item));
|
||||
let mut doc = Document::new("camera raw compatibility", size, ColorMode::Rgb, SampleType::U8);
|
||||
doc.layers.push(Layer::new("edited", LayerContent::Smart(smart)));
|
||||
|
||||
let saved = crate::export(&doc, "psd", &Default::default()).unwrap();
|
||||
let reopened = crate::import("saved.psd", &saved.bytes).unwrap().document;
|
||||
let layer = reopened.layers.iter().find(|layer| layer.name == "edited").unwrap();
|
||||
let LayerContent::Smart(smart) = &layer.content else { panic!("the Camera Raw layer must reopen as a smart object") };
|
||||
let [filter] = smart.smart_filters.as_slice() else { panic!("expected the saved Camera Raw filter") };
|
||||
if optics {
|
||||
assert_eq!(filter.command, UNSUPPORTED_FILTER);
|
||||
} else {
|
||||
assert_eq!(filter.command, COMMAND);
|
||||
let settings: CameraRaw = serde_json::from_value(filter.params.clone()).unwrap();
|
||||
assert!((settings.exposure - 1.15).abs() < 1e-6);
|
||||
}
|
||||
let roundtripped = item_for_filter(filter).unwrap();
|
||||
assert_eq!(get_desc(&roundtripped, "Fltr"), get_desc(&item, "Fltr"));
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
#[ignore = "requires a user-supplied Camera Raw PSD"]
|
||||
fn all_sliders_fixture() {
|
||||
|
||||
Reference in New Issue
Block a user